From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/x11r7/xlib_libXfont: work around gcc bug 85180
Date: Sun, 14 Jul 2019 15:07:10 +0200 [thread overview]
Message-ID: <20190714150710.3f4f42fc@windsurf> (raw)
In-Reply-To: <20190713115309.88559-1-giulio.benetti@micronovasrl.com>
Hello,
On Sat, 13 Jul 2019 13:53:09 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> With Microblaze Gcc version < 8.x the build hangs due to gcc bug
> 85180: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180. The bug
> shows up when building xlib_libXfont with optimization but not when
> building with -O0. To work around this, if
> BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y we force using -O0.
>
> Fixes:
> http://autobuild.buildroot.net/results/7c6/7c64becbf06a1e00e41b7ddb95dd0c65bf364eb7/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
> package/x11r7/xlib_libXfont/xlib_libXfont.mk | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/package/x11r7/xlib_libXfont/xlib_libXfont.mk b/package/x11r7/xlib_libXfont/xlib_libXfont.mk
> index a1acfba83b..ba41970289 100644
> --- a/package/x11r7/xlib_libXfont/xlib_libXfont.mk
> +++ b/package/x11r7/xlib_libXfont/xlib_libXfont.mk
> @@ -30,5 +30,13 @@ ifeq ($(BR2_microblaze),y)
> XLIB_LIBXFONT_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D__ELF__"
> endif
>
> +XLIB_LIBXFONT_CFLAGS = $(TARGET_CFLAGS)
> +
> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
> +XLIB_LIBXFONT_CFLAGS += -O0
> +endif
> +
> +XLIB_LIBXFONT_CONF_OPTS += CFLAGS="$(XLIB_LIBXFONT_CFLAGS)"
We normally use the <pkg>_CONF_ENV variable to override CFLAGS, so I
fixed that up and applied. Thanks!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-07-14 13:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-13 11:53 [Buildroot] [PATCH] package/x11r7/xlib_libXfont: work around gcc bug 85180 Giulio Benetti
2019-07-14 13:07 ` Thomas Petazzoni [this message]
2019-07-15 8:49 ` Giulio Benetti
-- strict thread matches above, loose matches on Subject: below --
2019-07-15 8:46 Giulio Benetti
2019-07-15 8:47 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714150710.3f4f42fc@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.