From: Jonathan Cameron <jic23@kernel.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Marek Vasut <marek.vasut@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Arnd Bergmann <arnd@arndb.de>, stable <stable@vger.kernel.org>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms+renesas@verge.net.au>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
linux-iio@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code
Date: Sun, 14 Jul 2019 16:09:08 +0100 [thread overview]
Message-ID: <20190714160908.7443eca6@archlinux> (raw)
In-Reply-To: <20190704195557.GA1338@kunai>
On Thu, 4 Jul 2019 21:55:58 +0200
Wolfram Sang <wsa@the-dreams.de> wrote:
> > >> This is correct but missing that the above 'return ret' is broken, too.
> > >> ret is initialized but 0 in that case.
> > >
> > > Nice catch! Oh well, given enough eyeballs, ...
> >
> > I don't think ret is initialized, reg is, not ret .
>
> It is initialized for the broken 'return ret' *above* the one which gets
> rightfully fixed in this patch.
>
Agreed, 2 broken cases and this is only fixing the second one.
I'm expecting a v2 of this patch which fixes them both, so
won't apply this v1.
Thanks,
Jonathan
prev parent reply other threads:[~2019-07-14 15:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 11:37 [PATCH] iio: adc: gyroadc: fix uninitialized return code Arnd Bergmann
2019-07-04 11:49 ` Geert Uytterhoeven
2019-07-04 12:07 ` Wolfram Sang
2019-07-04 12:10 ` Geert Uytterhoeven
2019-07-04 15:27 ` Marek Vasut
2019-07-04 19:55 ` Wolfram Sang
2019-07-14 15:09 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714160908.7443eca6@archlinux \
--to=jic23@kernel.org \
--cc=arnd@arndb.de \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=knaack.h@gmx.de \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.