From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/cpio: add host version
Date: Sun, 14 Jul 2019 18:39:15 +0200 [thread overview]
Message-ID: <20190714163915.GA29941@scaer> (raw)
In-Reply-To: <20190714162335.12684-1-itsatharva@gmail.com>
Atharva, All,
On 2019-07-14 21:53 +0530, Atharva Lele spake thusly:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> The latest cpio has a --reproducible option, which may come handy when
> we try to, well, be reproducible...
>
> Reported-by: Arnout Vandecappelle <arnout@mind.be>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> [Atharva: Made change pointed out by Arnout: remove HOST_CPIO_CONF_OPTS]
Actually, this is not very intereesting, because it does not say what
was in HOST_CPIO_CONF_OPTS. What we need to know is that we do not need
to force --bindir. So, I'd have written:
[Atharva: don't force --bindir, as noticed by Arnout]
> Signed-off-by: Atharva Lele <itsatharva@gmail.com>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Cc: Atharva Lele <itsatharva@gmail.com>
Except for the minor nit above:
Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
Thanks! :-)
Regards,
Yann E. MORIN.
> ---
> Changes v1 -> v2:
> - Add patch from Yann to my series
> ---
> package/cpio/cpio.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/cpio/cpio.mk b/package/cpio/cpio.mk
> index 9a09279572..cc40838840 100644
> --- a/package/cpio/cpio.mk
> +++ b/package/cpio/cpio.mk
> @@ -17,3 +17,4 @@ CPIO_DEPENDENCIES += argp-standalone
> endif
>
> $(eval $(autotools-package))
> +$(eval $(host-autotools-package))
> --
> 2.22.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2019-07-14 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-14 16:23 [Buildroot] [PATCH 1/2] package/cpio: add host version Atharva Lele
2019-07-14 16:23 ` [Buildroot] [PATCH 2/2] fs/cpio: make cpio rootfs reproducible Atharva Lele
2019-07-14 16:47 ` Yann E. MORIN
2019-07-14 17:21 ` Yann E. MORIN
2019-07-16 12:15 ` Atharva Lele
2019-07-14 16:39 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714163915.GA29941@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.