From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Denis Efremov <efremov@linux.com>
Cc: Andrew Duggan <aduggan@synaptics.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: synaptics-rmi4 - remove the exporting of rmi_2d_sensor_set_input_params
Date: Sun, 14 Jul 2019 11:26:56 -0700 [thread overview]
Message-ID: <20190714182656.GA190835@dtor-ws> (raw)
In-Reply-To: <20190708172138.31009-1-efremov@linux.com>
On Mon, Jul 08, 2019 at 08:21:38PM +0300, Denis Efremov wrote:
> The function rmi_2d_sensor_set_input_params is declared static and marked
> EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the
> function is not used outside of the drivers/input/rmi4/rmi_2d_sensor.c
> file it is defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>
Applied, thank you.
> ---
> drivers/input/rmi4/rmi_2d_sensor.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/rmi4/rmi_2d_sensor.c b/drivers/input/rmi4/rmi_2d_sensor.c
> index ea549efe4bc4..b7fe6eb35a4e 100644
> --- a/drivers/input/rmi4/rmi_2d_sensor.c
> +++ b/drivers/input/rmi4/rmi_2d_sensor.c
> @@ -204,7 +204,6 @@ static void rmi_2d_sensor_set_input_params(struct rmi_2d_sensor *sensor)
> if (sensor->topbuttonpad)
> set_bit(INPUT_PROP_TOPBUTTONPAD, input->propbit);
> }
> -EXPORT_SYMBOL_GPL(rmi_2d_sensor_set_input_params);
>
> int rmi_2d_sensor_configure_input(struct rmi_function *fn,
> struct rmi_2d_sensor *sensor)
> --
> 2.21.0
>
--
Dmitry
prev parent reply other threads:[~2019-07-14 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 17:21 [PATCH] Input: synaptics-rmi4 - remove the exporting of rmi_2d_sensor_set_input_params Denis Efremov
2019-07-14 18:26 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714182656.GA190835@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=aduggan@synaptics.com \
--cc=efremov@linux.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.