All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Maya Nakamura <m.maya.nakamura@gmail.com>
Cc: mikelley@microsoft.com, kys@microsoft.com,
	haiyangz@microsoft.com, sthemmin@microsoft.com,
	sashal@kernel.org, x86@kernel.org, linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/5] Input: hv: Remove dependencies on PAGE_SIZE for ring buffer
Date: Sun, 14 Jul 2019 16:28:54 -0700	[thread overview]
Message-ID: <20190714232854.GA41479@dtor-ws> (raw)
In-Reply-To: <5af419d636506d9d87ab7d2650fa800ead91a29a.1562916939.git.m.maya.nakamura@gmail.com>

On Fri, Jul 12, 2019 at 08:30:27AM +0000, Maya Nakamura wrote:
> Define the ring buffer size as a constant expression because it should
> not depend on the guest page size.
> 
> Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>

Applied, thank you.

> ---
>  drivers/input/serio/hyperv-keyboard.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/serio/hyperv-keyboard.c b/drivers/input/serio/hyperv-keyboard.c
> index 8e457e50f837..88ae7c2ac3c8 100644
> --- a/drivers/input/serio/hyperv-keyboard.c
> +++ b/drivers/input/serio/hyperv-keyboard.c
> @@ -75,8 +75,8 @@ struct synth_kbd_keystroke {
>  
>  #define HK_MAXIMUM_MESSAGE_SIZE 256
>  
> -#define KBD_VSC_SEND_RING_BUFFER_SIZE		(10 * PAGE_SIZE)
> -#define KBD_VSC_RECV_RING_BUFFER_SIZE		(10 * PAGE_SIZE)
> +#define KBD_VSC_SEND_RING_BUFFER_SIZE		(40 * 1024)
> +#define KBD_VSC_RECV_RING_BUFFER_SIZE		(40 * 1024)
>  
>  #define XTKBD_EMUL0     0xe0
>  #define XTKBD_EMUL1     0xe1
> -- 
> 2.17.1
> 

-- 
Dmitry

      reply	other threads:[~2019-07-14 23:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12  8:11 [PATCH v4 0/5] hv: Remove dependencies on guest page size Maya Nakamura
2019-07-12  8:14 ` [PATCH v4 1/5] x86: hv: hyperv-tlfs.h: Create and use Hyper-V page definitions Maya Nakamura
2019-07-22  9:10   ` [tip:x86/hyperv] x86/hyperv: " tip-bot for Maya Nakamura
2019-07-12  8:21 ` [PATCH v4 2/5] x86: hv: Add functions to allocate/deallocate page for Hyper-V Maya Nakamura
2019-07-22  9:10   ` [tip:x86/hyperv] x86/hyperv: " tip-bot for Maya Nakamura
2019-07-12  8:25 ` [PATCH v4 3/5] hv: vmbus: Replace page definition with Hyper-V specific one Maya Nakamura
2019-07-18  2:22   ` Sasha Levin
2019-07-22  9:08     ` Thomas Gleixner
2019-07-22  9:11   ` [tip:x86/hyperv] drivers: " tip-bot for Maya Nakamura
2019-07-12  8:27 ` [PATCH v4 4/5] HID: hv: Remove dependencies on PAGE_SIZE for ring buffer Maya Nakamura
     [not found]   ` <DM5PR21MB013708BF1876B7282C049B76D7BC0@DM5PR21MB0137.namprd21.prod.outlook.com>
2019-09-02 11:30     ` Jiri Kosina
2019-09-03  0:26       ` Sasha Levin
2019-07-12  8:30 ` [PATCH v4 5/5] Input: " Maya Nakamura
2019-07-14 23:28   ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190714232854.GA41479@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.maya.nakamura@gmail.com \
    --cc=mikelley@microsoft.com \
    --cc=sashal@kernel.org \
    --cc=sthemmin@microsoft.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.