Re: [PATCH RFC] fs: New zonefs file system

[Johannes Thumshirn <jthumshirn@suse.de>]

On Mon, Jul 15, 2019 at 11:19:35AM +1000, Dave Chinner wrote:
[...]
> > +/*
> > + * Open a file.
> > + */
> > +static int zonefs_file_open(struct inode *inode, struct file *file)
> > +{
> > +	/*
> > +	 * Note: here we can do an explicit open of the file zone,
> > +	 * on the first open of the inode. The explicit close can be
> > +	 * done on the last release (close) call for the inode.
> > +	 */
> > +
> > +	return generic_file_open(inode, file);
> > +}
> 
> Why is a wrapper needed for this?

AFAIR this is a left over from an older patch of me where an open of a
sequential only zone automagically appended O_APPEND, but this broke all kinds
of assumptions user-space did so Damien ripped it out again. So yes the
wrapper can go as well.

Byte,
	Johannes
-- 
Johannes Thumshirn                            SUSE Labs Filesystems
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850