Re: [Qemu-devel] [PATCH v3 3/6] tests/docker: add podman support

["Daniel P. Berrangé" <berrange@redhat.com>]

On Sat, Jul 13, 2019 at 06:33:08PM +0400, Marc-André Lureau wrote:
> Allow to specify the container engine to run with ENGINE variable.
> 
> By default, ENGINE=auto and will select either podman or docker.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  Makefile                      | 2 +-
>  tests/docker/Makefile.include | 8 ++++++--
>  2 files changed, 7 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

> 
> diff --git a/Makefile b/Makefile
> index 1fcbaed62c..7863bb0cf5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1153,7 +1153,7 @@ endif
>  	@echo  ''
>  	@echo  'Test targets:'
>  	@echo  '  check           - Run all tests (check-help for details)'
> -	@echo  '  docker          - Help about targets running tests inside Docker containers'
> +	@echo  '  docker          - Help about targets running tests inside containers'
>  	@echo  '  vm-help         - Help about targets running tests inside VM'
>  	@echo  ''
>  	@echo  'Documentation targets:'

I guess the target could be renamed to "cont" to parallel with "vm"
name too - fact either either "cont-help" and "vm-help" for both
or justr "cont" and "vm" for both,

Doesn't need to be done in this commit though.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|