Re: [Qemu-devel] [PATCH v2] Fix build error when VNC is configured out

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> On 6/26/19 6:49 PM, Stefano Garzarella wrote:
> > On Tue, Jun 25, 2019 at 02:39:05PM +0200, Christophe de Dinechin wrote:
> >> In hmp_change(), the variable hmp_mon is only used
> >> by code under #ifdef CONFIG_VNC. This results in a build
> >> error when VNC is configured out with the default of
> >> treating warnings as errors:
> >>
> >> monitor/hmp-cmds.c: In function ‘hmp_change’:
> >> monitor/hmp-cmds.c:1946:17: error: unused variable ‘hmp_mon’ [-Werror=unused-variable]
> >> 1946 |     MonitorHMP *hmp_mon = container_of(mon, MonitorHMP, common);
> >>      |                 ^~~~~~~
> >>
> >> v2: Move variable down as suggested by Philippe Mathieu-Daudé
> > 
> > Should we move out this line from the commit message?
> > (Maybe Dave can remove it when apply)
> 
> Yes please :) It was meant to go after the '---' separator.

Done.

Queued.

> >>
> >> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
> >> ---
> >>  monitor/hmp-cmds.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
> > 
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK