From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: jolsa@redhat.com, kamalesh@linux.vnet.ibm.com,
mamatha4@linux.vnet.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf version: Fix segfault
Date: Mon, 15 Jul 2019 08:00:06 -0300 [thread overview]
Message-ID: <20190715110006.GA6779@kernel.org> (raw)
In-Reply-To: <20190611030109.20228-1-ravi.bangoria@linux.ibm.com>
Em Tue, Jun 11, 2019 at 08:31:09AM +0530, Ravi Bangoria escreveu:
> 'perf version' on powerpc segfaults when used with non-supported
> option:
> # perf version -a
> Segmentation fault (core dumped)
>
> Fix this.
>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> Reviewed-by: Kamalesh babulal <kamalesh@linux.vnet.ibm.com>
> Tested-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
> ---
> tools/perf/builtin-version.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/builtin-version.c b/tools/perf/builtin-version.c
> index f470144d1a70..bf114ca9ca87 100644
> --- a/tools/perf/builtin-version.c
> +++ b/tools/perf/builtin-version.c
> @@ -19,6 +19,7 @@ static struct version version;
> static struct option version_options[] = {
> OPT_BOOLEAN(0, "build-options", &version.build_options,
> "display the build options"),
> + OPT_END(),
> };
Thanks, applied.
- Arnaldo
next prev parent reply other threads:[~2019-07-15 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 3:01 [PATCH] perf version: Fix segfault Ravi Bangoria
2019-07-15 11:00 ` Arnaldo Carvalho de Melo [this message]
2019-07-17 23:08 ` [tip:perf/urgent] perf version: Fix segfault due to missing OPT_END() tip-bot for Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715110006.GA6779@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=jolsa@redhat.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mamatha4@linux.vnet.ibm.com \
--cc=ravi.bangoria@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.