From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82633C76195 for ; Mon, 15 Jul 2019 14:53:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51DD620868 for ; Mon, 15 Jul 2019 14:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563202418; bh=j9Smzo+13AKt6noigqKwBIDWb9ULFOYIJjlw9cKEzsw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NaB9gTfWamcPX199jyKj/4ldaC2Gl234gp+2i+QhWuLJzHs0IodR22nJB6OGBKVOx lSQi3W3tspIS0RQx3fmi0V6np6kNZ0JSpaANSwiTdCJ3K8JKhtWJkhXHw+wTDwhyOp L2m6sVcw6MLjm8OdmRembdHEZV22h0zbNLKstLsM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404118AbfGOOxh (ORCPT ); Mon, 15 Jul 2019 10:53:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:40888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391570AbfGOO33 (ORCPT ); Mon, 15 Jul 2019 10:29:29 -0400 Received: from sasha-vm.mshome.net (unknown [73.61.17.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C5D2205ED; Mon, 15 Jul 2019 14:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563200968; bh=j9Smzo+13AKt6noigqKwBIDWb9ULFOYIJjlw9cKEzsw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y37i0Pt2QcpeZL96NArqtT+Aoo6rcuGXHjFFxYDzVQ+JlABI43T8xitQqdrObgx+u 7BBQbZVEMqn3CbNvc3THd7pKaMV1kM4EmuNSvToDhZ3hxIUzDe+dLxJWJVQ01AS8Ni F+iOesQkxnSSLYd9GINJKEM6sjDSJjMPB7Vh2QvM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jungo Lin , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 013/105] media: media_device_enum_links32: clean a reserved field Date: Mon, 15 Jul 2019 10:27:07 -0400 Message-Id: <20190715142839.9896-13-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190715142839.9896-1-sashal@kernel.org> References: <20190715142839.9896-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Jungo Lin [ Upstream commit f49308878d7202e07d8761238e01bd0e5fce2750 ] In v4l2-compliance utility, test MEDIA_IOC_ENUM_ENTITIES will check whether reserved field of media_links_enum filled with zero. However, for 32 bit program, the reserved field is missing copy from kernel space to user space in media_device_enum_links32 function. This patch adds the cleaning a reserved field logic in media_device_enum_links32 function. Signed-off-by: Jungo Lin Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/media-device.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index 62b2c5d9bdfb..a6d56154fac7 100644 --- a/drivers/media/media-device.c +++ b/drivers/media/media-device.c @@ -470,6 +470,7 @@ static long media_device_enum_links32(struct media_device *mdev, { struct media_links_enum links; compat_uptr_t pads_ptr, links_ptr; + int ret; memset(&links, 0, sizeof(links)); @@ -481,7 +482,13 @@ static long media_device_enum_links32(struct media_device *mdev, links.pads = compat_ptr(pads_ptr); links.links = compat_ptr(links_ptr); - return media_device_enum_links(mdev, &links); + ret = media_device_enum_links(mdev, &links); + if (ret) + return ret; + + memset(ulinks->reserved, 0, sizeof(ulinks->reserved)); + + return 0; } #define MEDIA_IOC_ENUM_LINKS32 _IOWR('|', 0x02, struct media_links_enum32) -- 2.20.1