From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C712C76191 for ; Mon, 15 Jul 2019 14:52:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14E7A2067C for ; Mon, 15 Jul 2019 14:52:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563202344; bh=sDmUSSz8ZTV+tBUjyQFQxP5poyM+OJUvThrnZApX6Eo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=QYTZnhxeFmZm/YuHwaG9ACTeYOLZ0Ebu6+bmu5pngwYF31RRbZTz+xc6dnC0pHzVf 62Kx9oQmT70XoHs4B4uE6UcaXzbuJquowMSiwxGr6h+QPy3AVL+8+OauTlBSN3xlgs Wf1mEGqosMJXgfOUSEXyTD+xLgYYDjhcoriPMFyA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391751AbfGOOaw (ORCPT ); Mon, 15 Jul 2019 10:30:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:43990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390949AbfGOOaw (ORCPT ); Mon, 15 Jul 2019 10:30:52 -0400 Received: from sasha-vm.mshome.net (unknown [73.61.17.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1BDEE205ED; Mon, 15 Jul 2019 14:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563201050; bh=sDmUSSz8ZTV+tBUjyQFQxP5poyM+OJUvThrnZApX6Eo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qFx7mK2LkUZr5DxcbfBberMD88nAAA9MQExIvr2ESWcRMuA1Zce/e3BsCSc8t/hlN D6bOaz4H997aWs2IotGDjrtGT1wx0/q5de13D+FkrswE009cEFb2umpBUT4+1G8f+P 9DYQ5r9dljEbJSCMSdNxqX5GizPp2hXFSRhp7xQg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Borislav Petkov , Tony Luck , linux-edac , Sasha Levin Subject: [PATCH AUTOSEL 4.14 037/105] RAS/CEC: Fix pfn insertion Date: Mon, 15 Jul 2019 10:27:31 -0400 Message-Id: <20190715142839.9896-37-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190715142839.9896-1-sashal@kernel.org> References: <20190715142839.9896-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org From: Borislav Petkov [ Upstream commit 6d8e294bf5f0e85c34e8b14b064e2965f53f38b0 ] When inserting random PFNs for debugging the CEC through (debugfs)/ras/cec/pfn, depending on the return value of pfn_set(), multiple values get inserted per a single write. That is because simple_attr_write() interprets a retval of 0 as success and claims the whole input. However, pfn_set() returns the cec_add_elem() value, which, if > 0 and smaller than the whole input length, makes glibc continue issuing the write syscall until there's input left: pfn_set simple_attr_write debugfs_attr_write full_proxy_write vfs_write ksys_write do_syscall_64 entry_SYSCALL_64_after_hwframe leading to those repeated calls. Return 0 to fix that. Signed-off-by: Borislav Petkov Cc: Tony Luck Cc: linux-edac Signed-off-by: Sasha Levin --- drivers/ras/cec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c index c7205cdcc11a..97cf40a522be 100644 --- a/drivers/ras/cec.c +++ b/drivers/ras/cec.c @@ -373,7 +373,9 @@ static int pfn_set(void *data, u64 val) { *(u64 *)data = val; - return cec_add_elem(val); + cec_add_elem(val); + + return 0; } DEFINE_DEBUGFS_ATTRIBUTE(pfn_ops, u64_get, pfn_set, "0x%llx\n"); -- 2.20.1