From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.86_2) id 1hn3oa-00012W-Jq for mharc-grub-devel@gnu.org; Mon, 15 Jul 2019 12:27:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60334) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hn3oY-00010d-L2 for grub-devel@gnu.org; Mon, 15 Jul 2019 12:26:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hn3oX-00008k-Ly for grub-devel@gnu.org; Mon, 15 Jul 2019 12:26:58 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:39675) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hn3oX-00008Y-GP for grub-devel@gnu.org; Mon, 15 Jul 2019 12:26:57 -0400 Received: from 139.35.155.90.in-addr.arpa ([90.155.35.139] helo=riva.pelham.vpn.ucam.org) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hn3oV-0001Ar-P5 for grub-devel@gnu.org; Mon, 15 Jul 2019 16:26:55 +0000 Received: from ns1.pelham.vpn.ucam.org ([172.20.153.2] helo=riva.ucam.org) by riva.pelham.vpn.ucam.org with esmtp (Exim 4.92) (envelope-from ) id 1hn3oV-0001ci-15 for grub-devel@gnu.org; Mon, 15 Jul 2019 17:26:55 +0100 Date: Mon, 15 Jul 2019 17:26:55 +0100 From: Colin Watson To: grub-devel@gnu.org Subject: Re: [PATCH] 30_os-prober: Provide GRUB_OS_PROBER_DISABLE_DEBUG Message-ID: <20190715162654.GA3712@riva.ucam.org> References: <20190715092821.10128-1-mchang@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190715092821.10128-1-mchang@suse.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 91.189.89.112 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jul 2019 16:26:59 -0000 On Mon, Jul 15, 2019 at 09:28:31AM +0000, Michael Chang wrote: > This patch adds support to disable os-prober debug output while running > grub-mkconfig through GRUB_OS_PROBER_DISABLE_DEBUG=true in simple > configuration interface. The os-prober needs to support the > OS_PROBER_DISABLE_DEBUG environment variable, which was introduced by > 1.72 release. Rather than extending the /etc/default/grub configuration interface for this, I wonder if it would be better to just do something like this in 30_os-prober: export OS_PROBER_DISABLE_DEBUG="${OS_PROBER_DISABLE_DEBUG-y}" That way, people who want details can set OS_PROBER_DISABLE_DEBUG= (i.e. empty) when running grub-mkconfig, or we could add a --debug option or something; but otherwise debug output will be suppressed, which seems like a better default for grub-mkconfig. -- Colin Watson [cjwatson@ubuntu.com]