From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Sean Nyekjaer <sean@geanix.com>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org,
lorenzo.bianconi83@gmail.com, martin@geanix.com
Subject: Re: [PATCH v2 1/6] iio: imu: st_lsm6dsx: move interrupt thread to core
Date: Tue, 16 Jul 2019 07:57:00 +0200 [thread overview]
Message-ID: <20190716055700.GC23126@localhost.localdomain> (raw)
In-Reply-To: <20190715081514.81129-1-sean@geanix.com>
[-- Attachment #1: Type: text/plain, Size: 1128 bytes --]
> This prepares the interrupt to be used for other stuff than
> fifo reading + event readings.
>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
>
> Changes since v1:
> * none
>
> .../iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c | 78 +----------------
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 87 +++++++++++++++++++
> 2 files changed, 88 insertions(+), 77 deletions(-)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c
> index 38194f4d2b7e..2b938d87ae34 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c
[...]
> int st_lsm6dsx_probe(struct device *dev, int irq, int hw_id,
> struct regmap *regmap)
> {
> @@ -1117,6 +1201,9 @@ int st_lsm6dsx_probe(struct device *dev, int irq, int hw_id,
> }
>
> if (hw->irq > 0) {
> + err = st_lsm6dsx_irq_setup(hw);
> + if (err < 0)
> + return err;
Could you please put a 'newline' here?
> err = st_lsm6dsx_fifo_setup(hw);
> if (err < 0)
> return err;
> --
> 2.22.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2019-07-16 5:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 8:15 [PATCH v2 1/6] iio: imu: st_lsm6dsx: move interrupt thread to core Sean Nyekjaer
2019-07-15 8:15 ` [PATCH v2 2/6] iio: imu: st_lsm6dsx: save drdy_pin in device struct Sean Nyekjaer
2019-07-15 8:15 ` [PATCH v2 3/6] iio: imu: st_lsm6dsx: add motion events Sean Nyekjaer
2019-07-16 8:29 ` Lorenzo Bianconi
2019-07-27 21:11 ` Jonathan Cameron
2019-08-09 11:05 ` Sean Nyekjaer
2019-08-21 11:11 ` Sean Nyekjaer
2019-07-15 8:15 ` [PATCH v2 4/6] iio: imu: st_lsm6dsx: add wakeup-source option Sean Nyekjaer
2019-07-16 8:04 ` Lorenzo Bianconi
2019-07-15 8:15 ` [PATCH v2 5/6] iio: imu: st_lsm6dsx: always enter interrupt thread Sean Nyekjaer
2019-07-16 6:14 ` Lorenzo Bianconi
2019-07-15 8:15 ` [PATCH v2 6/6] iio: imu: st_lsm6dsx: add motion report function and call from interrupt Sean Nyekjaer
2019-07-16 6:11 ` Lorenzo Bianconi
2019-07-16 5:57 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716055700.GC23126@localhost.localdomain \
--to=lorenzo@kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=martin@geanix.com \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.