From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.86_2) id 1hnHvA-0000f2-IL for mharc-grub-devel@gnu.org; Tue, 16 Jul 2019 03:30:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46869) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnHv8-0000es-S5 for grub-devel@gnu.org; Tue, 16 Jul 2019 03:30:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnHv7-0004VY-OC for grub-devel@gnu.org; Tue, 16 Jul 2019 03:30:42 -0400 Received: from m9a0003g.houston.softwaregrp.com ([15.124.64.68]:53601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hnHv7-0004UT-Hc for grub-devel@gnu.org; Tue, 16 Jul 2019 03:30:41 -0400 Received: FROM m9a0003g.houston.softwaregrp.com (15.121.0.191) BY m9a0003g.houston.softwaregrp.com WITH ESMTP FOR grub-devel@gnu.org; Tue, 16 Jul 2019 07:30:41 +0000 Received: from M9W0068.microfocus.com (2002:f79:bf::f79:bf) by M9W0068.microfocus.com (2002:f79:bf::f79:bf) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Tue, 16 Jul 2019 07:28:33 +0000 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (15.124.72.11) by M9W0068.microfocus.com (15.121.0.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Tue, 16 Jul 2019 07:28:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OhERgrIqC8wFJRIbGfMlXDuWNHc7UED9ioCf6dWd2GeBTwIBkeoREWX2xzEW7PuXJEyBhpgH62RbkZu8kXj+m5dk42kbWwQERNXcEXAz5xwXb/HQe1Mdjf+njNb7pOOBcCQXGSAGPNitStz9iwMXu0hAqdn7EMiuUn3rsRBu8YDSyA4W1JrDoFWqWn8rIYYsauGRaPVDUCeo+a2q7Gjfsqo6nSpHObJLfyR6QKChKRLPYoE2RB3+/Uha5KxAmTe9tf+DEhtXtBSYLOAi0AaDtED4CkySa7RKX125x7qFZNFK/n68yY4WsWBWEa7qxnSFOb10Kvxm75Vv+3uhSTQj5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JOAvbxa5WSpF5C+sCt5OdGMuEfpwN388f9qSe2KuZ8U=; b=WkvRhRfLhG6bNoayka7SPmHuJFnsXrYyfaAPN/w93jtkwjYZvOzPIws15SGHO0UYi7WFDufy5TjfcUc4TpzYZ1lcyRrBHXDJy+ObUacSSbihj+0I4b+Lv4LMHwx3KPiMBSh8q76Ou7f2U3tDGJm4lYIUiCbFVTQew96HaRgellj3J4LugNUIJy0lYabczkp1DIdvrIOCiFIRzyONaZcqaAutcHSjo3K6r3nNQnXBWXJseYPlVc54G3MLuPA0iwBlTOIszS4BrEautt8typIlcbi9eYUCOIgqDirdZMEjstO9TxdfEbWZE0Axy42ZC7S7piui2BW5sowC1IWEO1fgag== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none Received: from BY5PR18MB3122.namprd18.prod.outlook.com (10.255.139.11) by BY5PR18MB3140.namprd18.prod.outlook.com (10.255.136.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Tue, 16 Jul 2019 07:28:32 +0000 Received: from BY5PR18MB3122.namprd18.prod.outlook.com ([fe80::b023:74c9:ef22:8e7e]) by BY5PR18MB3122.namprd18.prod.outlook.com ([fe80::b023:74c9:ef22:8e7e%3]) with mapi id 15.20.2073.012; Tue, 16 Jul 2019 07:28:32 +0000 From: Michael Chang To: The development of GNU GRUB Subject: Re: [PATCH] 30_os-prober: Provide GRUB_OS_PROBER_DISABLE_DEBUG Thread-Topic: [PATCH] 30_os-prober: Provide GRUB_OS_PROBER_DISABLE_DEBUG Thread-Index: AQHVOu+qfIl662MfYUiGdKlMfVF6OKbL3oItgAD7tAA= Date: Tue, 16 Jul 2019 07:28:32 +0000 Message-ID: <20190716072819.GA32066@mazu> References: <20190715092821.10128-1-mchang@suse.com> <20190715162654.GA3712@riva.ucam.org> In-Reply-To: <20190715162654.GA3712@riva.ucam.org> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: DB6PR05CA0018.eurprd05.prod.outlook.com (2603:10a6:6:14::31) To BY5PR18MB3122.namprd18.prod.outlook.com (2603:10b6:a03:1af::11) authentication-results: spf=none (sender IP is ) smtp.mailfrom=MChang@suse.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [202.47.205.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cb950bad-165d-42e9-9932-08d709bf34a4 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:BY5PR18MB3140; x-ms-traffictypediagnostic: BY5PR18MB3140: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0100732B76 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(7916004)(4636009)(136003)(39860400002)(396003)(366004)(346002)(376002)(199004)(54094003)(189003)(316002)(66946007)(1076003)(476003)(66476007)(66446008)(66556008)(64756008)(446003)(11346002)(26005)(71200400001)(102836004)(71190400001)(229853002)(81166006)(81156014)(8936002)(86362001)(6506007)(386003)(186003)(256004)(52116002)(14454004)(6916009)(99286004)(5660300002)(76176011)(25786009)(80792005)(68736007)(8676002)(7736002)(305945005)(33716001)(478600001)(966005)(53936002)(3846002)(6512007)(9686003)(6486002)(6246003)(6116002)(6306002)(33656002)(486006)(66066001)(2906002)(6436002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY5PR18MB3140; H:BY5PR18MB3122.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: suse.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: xcpK6mmWTbw+heqG8t7sgDsac6di1+T8juzBm8X97kBh3GCEFKwOYnNs+3/84G8D9C55ceVu7bk9ijG8UA29b0iL2zyFZtSU/SqCb7N/XgDJdCFogenVi/8jZJ9Cjcsaw5omcnrs9368z8n8idycLn9HtEAttjEQ7V8XcHELPNmFzvG3m8Z7pcmn2CbZJGrDpDlEdbRY+a7MpvXmurj6Fe8yjL2y9gWZA+6Tz+qoWJJdyiOiBbP8woY+oS71NORr2YyRYNkBLueZwrcIV8x98BCHnaqagvjsnf50C13Emh3/BgFRXBMDlzc4SDkIZOXGmwAj7BpTcPj562FezlNFvCNO0/Z2lFEHLRIKuvsUSCegLrBU9ri/jnErnfoaTFw0XCEuifn2844zOd5Invmu2NB9NfhQGC2YCbHC8i//Bxg= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: cb950bad-165d-42e9-9932-08d709bf34a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2019 07:28:32.4739 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MChang@suse.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR18MB3140 X-OriginatorOrg: suse.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 15.124.64.68 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 07:30:44 -0000 On Mon, Jul 15, 2019 at 05:26:55PM +0100, Colin Watson wrote: > On Mon, Jul 15, 2019 at 09:28:31AM +0000, Michael Chang wrote: > > This patch adds support to disable os-prober debug output while running > > grub-mkconfig through GRUB_OS_PROBER_DISABLE_DEBUG=3Dtrue in simple > > configuration interface. The os-prober needs to support the > > OS_PROBER_DISABLE_DEBUG environment variable, which was introduced by > > 1.72 release. >=20 > Rather than extending the /etc/default/grub configuration interface for > this, I wonder if it would be better to just do something like this in > 30_os-prober: >=20 > export OS_PROBER_DISABLE_DEBUG=3D"${OS_PROBER_DISABLE_DEBUG-y}" >=20 > That way, people who want details can set OS_PROBER_DISABLE_DEBUG=3D (i.e= . > empty) when running grub-mkconfig, or we could add a --debug option or > something; but otherwise debug output will be suppressed, which seems > like a better default for grub-mkconfig. What about changing the os-prober default to disable the debug output ? In that way we don't need to patch grub, just do this to enable it. export OS_PROBER_ENABLE_DEBUG=3Dy; grub-mkconfig Btw, the intention of using /etc/default/grub is to make the change persistent to os-prober as it has no settings for that, and is in a documented way. I'm fine doing it either way, because the thing here is to suppress os-prober debug output as default, and re-enable it by settings or command line interface are all viable imho. Thanks, Michael >=20 > --=20 > Colin Watson [cjwatson@ubuntu.com] >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel