From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4] Add a regression test for CVE-2017-1000380
Date: Tue, 16 Jul 2019 12:31:51 +0200 [thread overview]
Message-ID: <20190716103151.GA14629@rei> (raw)
In-Reply-To: <CAEemH2cjr23TZUDNLAt2Vvk03W8sHNy+eaJT6YYXSFU+KxmTvQ@mail.gmail.com>
Hi!
> > +static void setup(void)
> > +{
> > + tst_fzsync_pair_init(&fzsync_pair);
> > + tst_taint_init(TST_TAINT_W | TST_TAINT_D);
> > + snd_fd = SAFE_OPEN("/dev/snd/timer",
> > + O_RDONLY|O_CREAT|O_NOCTTY|O_SYNC|O_LARGEFILE, 0);
> >
>
> Should we check if the file exists before opening it?
Yes we should. We should add access("/dev/snd/timer", F_OK) to the test
setup.
> Otherwise, snd_timer01 failed as:
>
> # ./snd_timer01
> tst_test.c:1100: INFO: Timeout per run is 0h 05m 00s
> safe_macros.c:225: BROK: snd_timer01.c:73: open(/dev/snd/timer,1052992,00)
> failed: ENOENT
>
> # lsmod |grep -i snd
>
> # grep -i snd /boot/config-4.18.0-107.el8.s390x
>
> # ls /dev/snd/timer
> ls: cannot access '/dev/snd/timer': No such file or directory
I guess that there is no soundcard on mainframe :-).
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2019-07-16 10:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 14:10 [LTP] [PATCH v4] Add a regression test for CVE-2017-1000380 Michael Moese
2019-07-12 13:31 ` Cyril Hrubis
2019-07-16 10:19 ` Li Wang
2019-07-16 10:31 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716103151.GA14629@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.