From: ming.lei@redhat.com (Ming Lei)
Subject: nvme-5.3 ssd performance regression
Date: Tue, 16 Jul 2019 20:47:42 +0800 [thread overview]
Message-ID: <20190716124741.GA2853@ming.t460p> (raw)
In-Reply-To: <20190716093617.GB32562@lst.de>
On Tue, Jul 16, 2019@11:36:17AM +0200, Christoph Hellwig wrote:
> On Tue, Jul 16, 2019@03:12:06PM +0800, Ming Lei wrote:
> > It should be caused by the following commit, and that patch uses
> > single mapping size to limit max hw sectors, and looks that way
> > is wrong. For example, on qemu, max_hw_sectors is decreased to
> > 512. You can try to revert the patch and see if it makes a difference.
> >
> > I feel we might need the max segment size limit too.
>
> No, with swiotlb it really is the whole request size that ?s limited
> by the swiotlb buffer size. Similar for potential iommus where
> again it is the whole thing.
Documentation/DMA-API.txt:
size_t
dma_max_mapping_size(struct device *dev);
Returns the maximum size of a mapping for the device. The size parameter
of the mapping functions like dma_map_single(), dma_map_page() and
others should not be larger than the returned value.
And dma_map_single() & dma_map_page() is usually for mapping single
element of SGL, instead of whole SGL.
Thanks,
Ming
next prev parent reply other threads:[~2019-07-16 12:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 1:04 nvme-5.3 ssd performance regression Benjamin Herrenschmidt
2019-07-16 7:12 ` Ming Lei
2019-07-16 9:36 ` Christoph Hellwig
2019-07-16 10:55 ` Benjamin Herrenschmidt
2019-07-16 12:47 ` Ming Lei [this message]
2019-07-16 19:12 ` Christoph Hellwig
2019-07-17 0:15 ` Benjamin Herrenschmidt
2019-07-17 4:26 ` Christoph Hellwig
2019-07-17 4:33 ` Benjamin Herrenschmidt
2019-07-17 4:40 ` Christoph Hellwig
2019-07-17 5:50 ` Benjamin Herrenschmidt
2019-07-17 6:19 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716124741.GA2853@ming.t460p \
--to=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.