From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96AEDC7618F for ; Tue, 16 Jul 2019 21:56:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CC452173B for ; Tue, 16 Jul 2019 21:56:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563314181; bh=mkSgw9KHv90WtEKSEA4T2TJ5wIkVgoCsZkoCTca1gR4=; h=From:To:Cc:Subject:Date:List-ID:From; b=LimaZf/9mZcr4CrG9cgcLSDDHwbEj0kizx9JHkCCyWnaxXl274qNpBqUwhzlpKkfK nB3HIzXFSpR2HKcUbS6/FHmlcQuycnWK86t70Vx3Yy0xCvFLLJ/OPQZ5oQlQse9ZT9 E4iE/hgtSLQuLbov141BtF7Tg10ZPvrZ+/DBst6Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728235AbfGPV4V (ORCPT ); Tue, 16 Jul 2019 17:56:21 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:38368 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726555AbfGPV4U (ORCPT ); Tue, 16 Jul 2019 17:56:20 -0400 Received: by mail-io1-f67.google.com with SMTP id j6so10217154ioa.5; Tue, 16 Jul 2019 14:56:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kADd+NQKUgWUED+820fdDO7gVP7dDmGj1gYm9p5p3sw=; b=ByNn6JN1wwQPUNvt8Gy1n+za6LarrICzIm/WJiOfVT2E1YCot47DwaMpiGAYAUlfXB iEmRiOx31C/TBviezpQzIYIEwd+qEtxTP/2BxrNTV1VXMkBZy/4v/YPA84xEfaTUMBpg EAAlNy0CvO7x8rTMn1ixPtGNO7MdDBP+qg45JxkKpJB+eGUA5qVtBqctkheDTutsbpjK tK/DuBqAiordSAN0P3E/osixbaEpYroA4sR+aYBZUQ6wwvW7cvjK2iI8bfB49duIhOYP xTEya26w2gDombfWo8NPvR15xDgkn7j0kfxPaT5o1THesvFD0/OANd4yKNLk+h9AQRQs iLfg== X-Gm-Message-State: APjAAAUcO4uYnqNL8zbFPIYkeStOw8Xb5Q+6BfqRamZFvf0gAlK+NTp8 wrywa37MiP7Y9MDQWjL/5A== X-Google-Smtp-Source: APXvYqwDMRb0ggHvOfuex4HW4eSe1qMvzAf6AwQILMzFafLTkg23I/dov4glX6kdigbpojvrSAFSjQ== X-Received: by 2002:a5e:d51a:: with SMTP id e26mr26126978iom.71.1563314179727; Tue, 16 Jul 2019 14:56:19 -0700 (PDT) Received: from xps15.herring.priv ([64.188.179.249]) by smtp.googlemail.com with ESMTPSA id f17sm20074646ioc.2.2019.07.16.14.56.18 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 16 Jul 2019 14:56:19 -0700 (PDT) From: Rob Herring To: Linus Walleij Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Maxime Coquelin , Alexandre Torgue , linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH] dt-bindings: pinctrl: stm32: Fix missing 'clocks' property in examples Date: Tue, 16 Jul 2019 15:56:18 -0600 Message-Id: <20190716215618.29757-1-robh@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Now that examples are validated against the DT schema, an error with required 'clocks' property missing is exposed: Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \ pinctrl@40020000: gpio@0: 'clocks' is a required property Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \ pinctrl@50020000: gpio@1000: 'clocks' is a required property Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \ pinctrl@50020000: gpio@2000: 'clocks' is a required property Add the missing 'clocks' properties to the examples to fix the errors. Fixes: 2c9239c125f0 ("dt-bindings: pinctrl: Convert stm32 pinctrl bindings to json-schema") Cc: Linus Walleij Cc: Maxime Coquelin Cc: Alexandre Torgue Cc: linux-gpio@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Signed-off-by: Rob Herring --- .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml index 3ac5d2088e49..91d3e78b3395 100644 --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml @@ -197,6 +197,7 @@ required: examples: - | #include + #include //Example 1 pinctrl@40020000 { #address-cells = <1>; @@ -210,6 +211,7 @@ examples: #gpio-cells = <2>; reg = <0x0 0x400>; resets = <&reset_ahb1 0>; + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOA)>; st,bank-name = "GPIOA"; }; }; @@ -227,6 +229,7 @@ examples: #gpio-cells = <2>; reg = <0x1000 0x400>; resets = <&reset_ahb1 0>; + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOB)>; st,bank-name = "GPIOB"; gpio-ranges = <&pinctrl 0 0 16>; }; @@ -236,6 +239,7 @@ examples: #gpio-cells = <2>; reg = <0x2000 0x400>; resets = <&reset_ahb1 0>; + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOC)>; st,bank-name = "GPIOC"; ngpios = <5>; gpio-ranges = <&pinctrl 0 16 3>, -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C925C7618F for ; Tue, 16 Jul 2019 21:56:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 255DA2173B for ; Tue, 16 Jul 2019 21:56:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KATUaLzo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 255DA2173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=QKsd2nrySm9MQYQTHZJeh8KgoZBlhDlxPyU6bhDZKtE=; b=KATUaLzokPKtl0 1+J2RpWhubyNbAnmRkphYNliL0uoi3SqeVxs6d/MQZcubwwo6NfDYDEipZZwTnQrS4n5gUFMnM3ym bKragXaeV49UyRFTiGrm5E0DAgCJzc1acuZsCMqC8/JWhSFcJkt5CQijCxcBYgME/KgKgBfgiEO5W EYZy/hThlwQVEWpQJOt5WTSXWtwAvZLgnousFSyVdemBneywwa8G4jD9pFyBpDTsjMU/6FVAajEk9 ExY+EshWY/3VRTtCbmxv2ep1zsDrbRYgqvS9D3REvsrwz6bdDiwxQCODuqtSVrqLWMcxQ1rbunhQX Vup0Q7YilOqd8dbopQ0g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hnVQt-0005ei-PX; Tue, 16 Jul 2019 21:56:23 +0000 Received: from mail-io1-f66.google.com ([209.85.166.66]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hnVQr-0005eD-Ak for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2019 21:56:22 +0000 Received: by mail-io1-f66.google.com with SMTP id q22so42503766iog.4 for ; Tue, 16 Jul 2019 14:56:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kADd+NQKUgWUED+820fdDO7gVP7dDmGj1gYm9p5p3sw=; b=MK7HVPMlnNXYpbOr35vmxDuGRn+upC+FUtrkRzQnVd6wU4JgC63Q9QEQv3tctTOd79 zm0LKw4TbfUYvANPv5vg3xRLWq3Vpb4o+G1o3bo/VFq2CHXnkoMjyrrkBgKmVVT+OdHO tO1c5DVbhSvJwRl7WSTENEX+mLgiDrtVxcHuyfru4VaHKI39FB7fbjU/X0oIMV4+PG1e tVM3rqMpYeXxlHjpQ3jEkYvBigEdf2XdVaHa7DZTQ1r6toqi8XtHgP3+ypKaSuq/byyC pbiac2rvXuP7kDviW0XfhIkqegM6RSg/nomw6pKqRlZVhClbW+ZpPKMZp3YAGSJL3biG orZQ== X-Gm-Message-State: APjAAAWhq/kKw9T8cdUP6qAs8hJM69wVrZoEH1JLd96bZwxHivzW/Hf9 iXamts2Jp0mbduDucDj0qw== X-Google-Smtp-Source: APXvYqwDMRb0ggHvOfuex4HW4eSe1qMvzAf6AwQILMzFafLTkg23I/dov4glX6kdigbpojvrSAFSjQ== X-Received: by 2002:a5e:d51a:: with SMTP id e26mr26126978iom.71.1563314179727; Tue, 16 Jul 2019 14:56:19 -0700 (PDT) Received: from xps15.herring.priv ([64.188.179.249]) by smtp.googlemail.com with ESMTPSA id f17sm20074646ioc.2.2019.07.16.14.56.18 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 16 Jul 2019 14:56:19 -0700 (PDT) From: Rob Herring To: Linus Walleij Subject: [PATCH] dt-bindings: pinctrl: stm32: Fix missing 'clocks' property in examples Date: Tue, 16 Jul 2019 15:56:18 -0600 Message-Id: <20190716215618.29757-1-robh@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190716_145621_368295_4C52DFF6 X-CRM114-Status: UNSURE ( 8.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandre Torgue , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Now that examples are validated against the DT schema, an error with required 'clocks' property missing is exposed: Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \ pinctrl@40020000: gpio@0: 'clocks' is a required property Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \ pinctrl@50020000: gpio@1000: 'clocks' is a required property Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \ pinctrl@50020000: gpio@2000: 'clocks' is a required property Add the missing 'clocks' properties to the examples to fix the errors. Fixes: 2c9239c125f0 ("dt-bindings: pinctrl: Convert stm32 pinctrl bindings to json-schema") Cc: Linus Walleij Cc: Maxime Coquelin Cc: Alexandre Torgue Cc: linux-gpio@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Signed-off-by: Rob Herring --- .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml index 3ac5d2088e49..91d3e78b3395 100644 --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml @@ -197,6 +197,7 @@ required: examples: - | #include + #include //Example 1 pinctrl@40020000 { #address-cells = <1>; @@ -210,6 +211,7 @@ examples: #gpio-cells = <2>; reg = <0x0 0x400>; resets = <&reset_ahb1 0>; + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOA)>; st,bank-name = "GPIOA"; }; }; @@ -227,6 +229,7 @@ examples: #gpio-cells = <2>; reg = <0x1000 0x400>; resets = <&reset_ahb1 0>; + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOB)>; st,bank-name = "GPIOB"; gpio-ranges = <&pinctrl 0 0 16>; }; @@ -236,6 +239,7 @@ examples: #gpio-cells = <2>; reg = <0x2000 0x400>; resets = <&reset_ahb1 0>; + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOC)>; st,bank-name = "GPIOC"; ngpios = <5>; gpio-ranges = <&pinctrl 0 16 3>, -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel