From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Ulrich Hecht <uli+renesas@fpond.eu>,
linux-renesas-soc@vger.kernel.org, linux-mmc@vger.kernel.org,
yamada.masahiro@socionext.com, geert@linux-m68k.org,
ulf.hansson@linaro.org, magnus.damm@gmail.com
Subject: Re: [PATCH 1/2] mmc: tmio: leave clock handling to PM if enabled
Date: Wed, 17 Jul 2019 10:13:01 +0900 [thread overview]
Message-ID: <20190717011301.GG4384@wyvern> (raw)
In-Reply-To: <20190716190524.no5d25iyllgjdluh@katana>
On 2019-07-16 21:05:24 +0200, Wolfram Sang wrote:
> On Tue, Jul 16, 2019 at 05:01:03PM +0200, Ulrich Hecht wrote:
> > This fixes a clock imbalance that occurs because the SD clock is handled
> > by both PM and the hardware driver.
> > See https://www.spinics.net/lists/linux-mmc/msg44431.html for details.
> >
> > This patch removes the clock handling from the driver's PM callbacks and
> > turns the clock off after probing.
> >
> > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>
>
> Thanks, Uli!
>
> Niklas, I'd really like your feedback on this one because you did the PM
> refactorization lately.
I would like to test this too. Unfortunately I'm on the road and will be
back in the office the 23rd so I will have to postpone doing so until
then. My initial comment is that this looks good, thanks Ulrich.
>
> I will have a look later, too.
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2019-07-17 1:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 15:01 [PATCH 0/2] mmc: tmio: remove Gen2+ workaround and fix up Ulrich Hecht
2019-07-16 15:01 ` [PATCH 1/2] mmc: tmio: leave clock handling to PM if enabled Ulrich Hecht
2019-07-16 19:05 ` Wolfram Sang
2019-07-17 1:13 ` Niklas Söderlund [this message]
2019-07-25 13:43 ` Ulf Hansson
2019-07-29 8:44 ` Geert Uytterhoeven
2019-07-16 15:01 ` [PATCH 2/2] mmc: tmio: remove obsolete PM workaround Ulrich Hecht
2019-07-29 8:37 ` Geert Uytterhoeven
2019-07-25 21:15 ` [PATCH 0/2] mmc: tmio: remove Gen2+ workaround and fix up Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717011301.GG4384@wyvern \
--to=niklas.soderlund@ragnatech.se \
--cc=geert@linux-m68k.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=uli+renesas@fpond.eu \
--cc=wsa@the-dreams.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.