From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org,
Sascha Hauer <s.hauer@pengutronix.de>,
Enrico Weigelt <info@metux.net>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v3 3/3] input: touchscreen mc13xxx: Add mc34708 support
Date: Wed, 17 Jul 2019 06:36:55 +0300 [thread overview]
Message-ID: <20190717033655.GC621@penguin> (raw)
In-Reply-To: <20190716221929.3782-4-lukma@denx.de>
On Wed, Jul 17, 2019 at 12:19:29AM +0200, Lukasz Majewski wrote:
> From: Sascha Hauer <s.hauer@pengutronix.de>
>
> The mc34708 has a different bit to enable pen detection. This
> adds the driver data and devtype necessary to probe the device
> and to distinguish between the mc13783 and the mc34708.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
>
> ---
> Changes for v3:
> - Replace forward declaration of mc13xxx_driver_data with
> structure definition
> - Rename mc13xxx_driver_data with mc13xxx_chip
> - Move static struct mc13xxx_chip mc13783_chip and mc34708_chip
> closer to ID table
> - Do not check mc13xxx device type
You do not even need to define or store the type. Once it is dropped
please feel free to add
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
and merge with the other 2 patches.
--
Dmitry
next prev parent reply other threads:[~2019-07-17 3:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 22:19 [PATCH v3 0/3] mfd: mc13xxx: Fixes and enhancements for NXP's mc34708 Lukasz Majewski
2019-07-16 22:19 ` [PATCH v3 1/3] mfd: mc13xxx: Add mc34708 adc support Lukasz Majewski
2019-07-16 22:19 ` [PATCH v3 2/3] input: touchscreen mc13xxx: Make platform data optional Lukasz Majewski
2019-07-17 3:35 ` Dmitry Torokhov
2019-07-17 8:14 ` Lukasz Majewski
2019-07-16 22:19 ` [PATCH v3 3/3] input: touchscreen mc13xxx: Add mc34708 support Lukasz Majewski
2019-07-17 3:36 ` Dmitry Torokhov [this message]
2019-07-17 8:17 ` Lukasz Majewski
2019-07-17 8:53 ` Dmitry Torokhov
2019-07-17 9:07 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717033655.GC621@penguin \
--to=dmitry.torokhov@gmail.com \
--cc=info@metux.net \
--cc=kstewart@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=s.hauer@pengutronix.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.