From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme-multipath: sanitize nvme_update_ana_state()
Date: Wed, 17 Jul 2019 16:38:59 +0200 [thread overview]
Message-ID: <20190717143859.GA13872@lst.de> (raw)
In-Reply-To: <aa83c6b8-5d72-2e11-2681-5bb2e67ba890@suse.de>
On Tue, Jul 16, 2019@12:02:15PM +0200, Hannes Reinecke wrote:
> The underlying problem is the 'WARN_ON()', which actually can (and is)
> triggered when ANA change AENs are received during controller (re-) connect.
> At the same time it's quite pointless to update the ANA state for
> namespaces which are on their way out; we _still_ seeing odd behaviour
> during simultaneous rescan/reset, and this is just another safeguard.
>
> But for now I'd be happy to drop the check for NS_REMOVING and just
> delete the WARN_ON().
Well, we should certainly skip the nvme_mpath_set_live as well for
a removing namespace. But yes, I'd prefer to move the check there
and then remove the WARN_ON over the big hammer.
next prev parent reply other threads:[~2019-07-17 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 7:18 [PATCH] nvme-multipath: sanitize nvme_update_ana_state() Hannes Reinecke
2019-07-16 9:38 ` Christoph Hellwig
2019-07-16 10:02 ` Hannes Reinecke
2019-07-17 14:38 ` Christoph Hellwig [this message]
2019-07-18 18:08 ` John Donnelly
2019-07-19 7:06 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717143859.GA13872@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.