From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH] drm/panel: simple: Doxygenize 'struct panel_desc'; rename a few functions Date: Wed, 17 Jul 2019 19:33:17 +0200 Message-ID: <20190717173317.GA4862@ravnborg.org> References: <20190712163333.231884-1-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190712163333.231884-1-dianders@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Douglas Anderson Cc: Thierry Reding , Sean Paul , Boris Brezillon , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org Hi Doug. On Fri, Jul 12, 2019 at 09:33:33AM -0700, Douglas Anderson wrote: > This attempts to address outstanding review feedback from commit > b8a2948fa2b3 ("drm/panel: simple: Add ability to override typical > timing"). Specifically: > > * It was requested that I document (in the structure definition) that > the device tree override had no effect if 'struct drm_display_mode' > was used in the panel description. I have provided full Doxygen > comments for 'struct panel_desc' to accomplish that. > * panel_simple_get_fixed_modes() was thought to be a confusing name, > so it has been renamed to panel_simple_get_display_modes(). > * panel_simple_parse_override_mode() was thought to be better named as > panel_simple_parse_panel_timing_node(). > > Suggested-by: Sam Ravnborg > Signed-off-by: Douglas Anderson Thanks. I updated the $subject to: drm/panel: simple: document panel_desc; rename a few functions And pushed out to drm-misc-next. > - Sam said that there was still something that he didn't understand > with regards to the flags. Sam: if this is something that needs to > be addressed, please yell. Need to re-visit this later when I have familiarized myself with the new yaml syntax and what impact any potential changes may have on the panel drivers. So for now we leave it as is. Sam