From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-5865-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 8EF1B985EE4 for ; Thu, 18 Jul 2019 07:47:35 +0000 (UTC) Date: Thu, 18 Jul 2019 03:47:22 -0400 From: "Michael S. Tsirkin" Message-ID: <20190718034715-mutt-send-email-mst@kernel.org> References: <20190718070047.7402-1-tiwei.bie@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190718070047.7402-1-tiwei.bie@intel.com> Subject: [virtio-dev] Re: [RFC] content: explicitly document the VLAN filtering as best-effort To: Tiwei Bie Cc: virtio-dev@lists.oasis-open.org, cohuck@redhat.com, stefanha@redhat.com, jasowang@redhat.com List-ID: On Thu, Jul 18, 2019 at 03:00:47PM +0800, Tiwei Bie wrote: > Similar to the MAC address based filtering, the VLAN filtering > is also best-effort in implementations, but it's not quite clear > in the spec. So document this behaviour explicitly to reflect > the way implementations behave. > > Signed-off-by: Tiwei Bie fine by me. Acked-by: Michael S. Tsirkin > --- > This is a RFC for now (Comments would be appreciated!). > More details can be found here: > https://patchwork.ozlabs.org/patch/1113538/ > > content.tex | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/content.tex b/content.tex > index 8f0498e..783322b 100644 > --- a/content.tex > +++ b/content.tex > @@ -3530,6 +3530,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi > If the driver negotiates the VIRTION_NET_F_CTRL_VLAN feature, it > can control a VLAN filter table in the device. > > +\begin{note} > +Similar to the MAC address based filtering, the VLAN filtering > +is also best-effort: unwanted packets could still arrive. > +\end{note} > + > \begin{lstlisting} > #define VIRTIO_NET_CTRL_VLAN 2 > #define VIRTIO_NET_CTRL_VLAN_ADD 0 > -- > 2.17.1 --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org