From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA0CFC76196 for ; Thu, 18 Jul 2019 08:45:15 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDA2A217F4 for ; Thu, 18 Jul 2019 08:45:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDA2A217F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id B13041070; Thu, 18 Jul 2019 08:45:15 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 9D69E1061 for ; Thu, 18 Jul 2019 08:44:59 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 423CD25A for ; Thu, 18 Jul 2019 08:44:59 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id BEB5068B05; Thu, 18 Jul 2019 10:44:57 +0200 (CEST) Date: Thu, 18 Jul 2019 10:44:56 +0200 From: Christoph Hellwig To: Thiago Jung Bauermann Subject: Re: [PATCH v3 6/6] s390/mm: Remove sev_active() function Message-ID: <20190718084456.GE24562@lst.de> References: <20190718032858.28744-1-bauerman@linux.ibm.com> <20190718032858.28744-7-bauerman@linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190718032858.28744-7-bauerman@linux.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: linux-s390@vger.kernel.org, Mike Anderson , Konrad Rzeszutek Wilk , Robin Murphy , x86@kernel.org, Ram Pai , linux-kernel@vger.kernel.org, Alexey Dobriyan , Halil Pasic , iommu@lists.linux-foundation.org, Ingo Molnar , Borislav Petkov , Thomas Lendacky , "H. Peter Anvin" , linux-fsdevel@vger.kernel.org, Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org > -/* are we a protected virtualization guest? */ > -bool sev_active(void) > -{ > - return is_prot_virt_guest(); > -} > - > bool force_dma_unencrypted(struct device *dev) > { > - return sev_active(); > + return is_prot_virt_guest(); > } Do we want to keep the comment for force_dma_unencrypted? Otherwise looks good: Reviewed-by: Christoph Hellwig _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:57902 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726482AbfGRIo7 (ORCPT ); Thu, 18 Jul 2019 04:44:59 -0400 Date: Thu, 18 Jul 2019 10:44:56 +0200 From: Christoph Hellwig Subject: Re: [PATCH v3 6/6] s390/mm: Remove sev_active() function Message-ID: <20190718084456.GE24562@lst.de> References: <20190718032858.28744-1-bauerman@linux.ibm.com> <20190718032858.28744-7-bauerman@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190718032858.28744-7-bauerman@linux.ibm.com> Sender: linux-s390-owner@vger.kernel.org List-ID: To: Thiago Jung Bauermann Cc: x86@kernel.org, iommu@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Konrad Rzeszutek Wilk , Alexey Dobriyan , Thomas Lendacky , Halil Pasic , Mike Anderson , Ram Pai > -/* are we a protected virtualization guest? */ > -bool sev_active(void) > -{ > - return is_prot_virt_guest(); > -} > - > bool force_dma_unencrypted(struct device *dev) > { > - return sev_active(); > + return is_prot_virt_guest(); > } Do we want to keep the comment for force_dma_unencrypted? Otherwise looks good: Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80722C76191 for ; Thu, 18 Jul 2019 08:52:36 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3755C2173E for ; Thu, 18 Jul 2019 08:52:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3755C2173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45q7Dy0FSYzDqGg for ; Thu, 18 Jul 2019 18:52:34 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lst.de Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45q74D6K8xzDqMh for ; Thu, 18 Jul 2019 18:45:00 +1000 (AEST) Received: by verein.lst.de (Postfix, from userid 2407) id BEB5068B05; Thu, 18 Jul 2019 10:44:57 +0200 (CEST) Date: Thu, 18 Jul 2019 10:44:56 +0200 From: Christoph Hellwig To: Thiago Jung Bauermann Subject: Re: [PATCH v3 6/6] s390/mm: Remove sev_active() function Message-ID: <20190718084456.GE24562@lst.de> References: <20190718032858.28744-1-bauerman@linux.ibm.com> <20190718032858.28744-7-bauerman@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190718032858.28744-7-bauerman@linux.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, Mike Anderson , Konrad Rzeszutek Wilk , Robin Murphy , x86@kernel.org, Ram Pai , linux-kernel@vger.kernel.org, Alexey Dobriyan , Halil Pasic , iommu@lists.linux-foundation.org, Ingo Molnar , Borislav Petkov , Thomas Lendacky , "H. Peter Anvin" , linux-fsdevel@vger.kernel.org, Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, Christoph Hellwig , Marek Szyprowski Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" > -/* are we a protected virtualization guest? */ > -bool sev_active(void) > -{ > - return is_prot_virt_guest(); > -} > - > bool force_dma_unencrypted(struct device *dev) > { > - return sev_active(); > + return is_prot_virt_guest(); > } Do we want to keep the comment for force_dma_unencrypted? Otherwise looks good: Reviewed-by: Christoph Hellwig