From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/ehl: Use an id of 4 while accessing DPLL4's CR0 and CR1 Date: Thu, 18 Jul 2019 20:29:46 +0300 Message-ID: <20190718172946.GC5942@intel.com> References: <20190710184752.GL5942@intel.com> <20190717021316.18610-1-vivek.kasireddy@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D3606E445 for ; Thu, 18 Jul 2019 17:29:50 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190717021316.18610-1-vivek.kasireddy@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Vivek Kasireddy Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKdWwgMTYsIDIwMTkgYXQgMDc6MTM6MTZQTSAtMDcwMCwgVml2ZWsgS2FzaXJlZGR5 IHdyb3RlOgo+IEFsdGhvdWdoLCBEUExMNCBlbmFibGUgYW5kIGRpc2FibGUgaXMgYXNzb2NpYXRl ZCB3aXRoIE1HUExMMV9FTkFCTEUKPiByZWdpc3Rlciwgd2UgY2FuIHVzZSBJQ0xfRFBMTF9DRkdD UjAvQ1IxIG1hY3JvcyB0byBhY2Nlc3MgdGhpcyBkcGxsJ3MKPiBDUjAgYW5kIENSMSByZWdpc3Rl cnMgYnkgcGFzc2luZyBhbiBpZCBvZiA0IHRvIHRoZXNlIG1hY3Jvcy4KPiAKPiBSZXBvcnRlZC1i eTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzog VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogSm9z w6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+Cj4gQ2M6IE1hdHQgUm9w ZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gQ2M6IEltcmUgRGVhayA8aW1yZS5kZWFr QGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBWaXZlayBLYXNpcmVkZHkgPHZpdmVrLmthc2ly ZWRkeUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50 ZWxfZHBsbF9tZ3IuYyB8IDE4ICsrKysrKysrKysrKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwg MTQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcGxsX21nci5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvZGlzcGxheS9pbnRlbF9kcGxsX21nci5jCj4gaW5kZXggMzE5YTI2YTFlYzEwLi5mOWJk Zjg1MTRhNTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRl bF9kcGxsX21nci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9k cGxsX21nci5jCj4gQEAgLTMxMjcsOCArMzEyNywxMyBAQCBzdGF0aWMgYm9vbCBpY2xfcGxsX2dl dF9od19zdGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJaHdfc3Rh dGUtPmNmZ2NyMCA9IEk5MTVfUkVBRChUR0xfRFBMTF9DRkdDUjAoaWQpKTsKPiAgCQlod19zdGF0 ZS0+Y2ZnY3IxID0gSTkxNV9SRUFEKFRHTF9EUExMX0NGR0NSMShpZCkpOwo+ICAJfSBlbHNlIHsK PiAtCQlod19zdGF0ZS0+Y2ZnY3IwID0gSTkxNV9SRUFEKElDTF9EUExMX0NGR0NSMChpZCkpOwo+ IC0JCWh3X3N0YXRlLT5jZmdjcjEgPSBJOTE1X1JFQUQoSUNMX0RQTExfQ0ZHQ1IxKGlkKSk7Cj4g KwkJaWYgKElTX0VMS0hBUlRMQUtFKGRldl9wcml2KSAmJiBpZCA9PSBEUExMX0lEX0VITF9EUExM NCkgewo+ICsJCQlod19zdGF0ZS0+Y2ZnY3IwID0gSTkxNV9SRUFEKElDTF9EUExMX0NGR0NSMCg0 KSk7Cj4gKwkJCWh3X3N0YXRlLT5jZmdjcjEgPSBJOTE1X1JFQUQoSUNMX0RQTExfQ0ZHQ1IxKDQp KTsKPiArCQl9IGVsc2Ugewo+ICsJCQlod19zdGF0ZS0+Y2ZnY3IwID0gSTkxNV9SRUFEKElDTF9E UExMX0NGR0NSMChpZCkpOwo+ICsJCQlod19zdGF0ZS0+Y2ZnY3IxID0gSTkxNV9SRUFEKElDTF9E UExMX0NGR0NSMShpZCkpOwo+ICsJCX0KPiAgCX0KPiAgCj4gIAlyZXQgPSB0cnVlOwo+IEBAIC0z MTY5LDggKzMxNzQsMTMgQEAgc3RhdGljIHZvaWQgaWNsX2RwbGxfd3JpdGUoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCWNmZ2NyMF9yZWcgPSBUR0xfRFBMTF9DRkdDUjAo aWQpOwo+ICAJCWNmZ2NyMV9yZWcgPSBUR0xfRFBMTF9DRkdDUjEoaWQpOwo+ICAJfSBlbHNlIHsK PiAtCQljZmdjcjBfcmVnID0gSUNMX0RQTExfQ0ZHQ1IwKGlkKTsKPiAtCQljZmdjcjFfcmVnID0g SUNMX0RQTExfQ0ZHQ1IxKGlkKTsKPiArCQlpZiAoSVNfRUxLSEFSVExBS0UoZGV2X3ByaXYpICYm IGlkID09IERQTExfSURfRUhMX0RQTEw0KSB7Cj4gKwkJCWNmZ2NyMF9yZWcgPSBJQ0xfRFBMTF9D RkdDUjAoNCk7Cj4gKwkJCWNmZ2NyMV9yZWcgPSBJQ0xfRFBMTF9DRkdDUjEoNCk7Cj4gKwkJfSBl bHNlIHsKPiArCQkJY2ZnY3IwX3JlZyA9IElDTF9EUExMX0NGR0NSMChpZCk7Cj4gKwkJCWNmZ2Ny MV9yZWcgPSBJQ0xfRFBMTF9DRkdDUjEoaWQpOwo+ICsJCX0KCkkgd2FzIGEgYml0IHdvcnJpZWQg dGhpcyB3b3VsZCBhbHNvIGFmZmVjdCBvdGhlciBwYXJ0cyBvZiB0aGUgY29kZSwgYnV0IAphdCBs ZWFzdCBJQ0xfRFBDTEtBX0NGR0NSMF9ERElfQ0xLX1NFTCgpIHNlZW1zIHRvIGRvIHRoZSByaWdo dCB0aGluZwp3aXRoIHRoZSBpZD09MiwgYW5kIEkgY291bGRuJ3QgaW1tZWRpYXRlbHkgc3BvdCBv dGhlciBpc3N1ZXMuCgpBbHNvIHN1cnByaXNpbmcgdGhhdCBjaSBkaWRuJ3QgZ2V0IGNvbmZ1c2Vk IGJ5IHRoZSBmYWN0IHRoYXQgdGhpcyB3YXMgcG9zdGVkCmFzIGEgcmVwbHkgdG8gYW5vdGhlciBz ZXJpZXMuIEdlbmVyYWxseSB5b3Ugc2hvdWxkIGF2b2lkIHJlcGx5aW5nIHdpdGgKYW55dGhpbmcg ZXhjZXB0IGRpcmVjdCByZXBsYWNlbWVudHMgZm9yIHRoZSBvcmlnaW5hbCBwYXRjaGVzIGluIHRo ZQpzZXJpZXMuCgpQdXNoZWQgdG8gZGlucS4gVGhhbmtzIGZvciB0aGUgcGF0Y2guCgo+ICAJfQo+ ICAKPiAgCUk5MTVfV1JJVEUoY2ZnY3IwX3JlZywgaHdfc3RhdGUtPmNmZ2NyMCk7Cj4gLS0gCj4g Mi4yMS4wCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeA==