From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v1 07/11] drm: direct include of drm.h in drm_gem_shmem_helper.c Date: Thu, 18 Jul 2019 13:51:26 -0400 Message-ID: <20190718175126.GJ31819@art_vandelay> References: <20190718161507.2047-1-sam@ravnborg.org> <20190718161507.2047-8-sam@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190718161507.2047-8-sam@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sam Ravnborg Cc: David Airlie , Liviu Dudau , dri-devel@lists.freedesktop.org, Maxime Ripard , Thierry Reding , Jani Nikula , Intel Graphics Development , linux-mediatek@lists.infradead.org, Matthias Brugger , Sean Paul , linux-arm-kernel@lists.infradead.org, Boris Brezillon , Thomas Zimmermann , Christian =?iso-8859-1?Q?K=F6nig?= List-Id: linux-mediatek@lists.infradead.org T24gVGh1LCBKdWwgMTgsIDIwMTkgYXQgMDY6MTU6MDNQTSArMDIwMCwgU2FtIFJhdm5ib3JnIHdy b3RlOgo+IERvIG5vdCByZWx5IG9uIGluY2x1ZGluZyBkcm0uaCBmcm9tIGRybV9maWxlLmgsCj4g YXMgdGhlIGluY2x1ZGUgaW4gZHJtX2ZpbGUuaCB3aWxsIGJlIGRyb3BwZWQuCj4gCj4gU2lnbmVk LW9mZi1ieTogU2FtIFJhdm5ib3JnIDxzYW1AcmF2bmJvcmcub3JnPgoKUmV2aWV3ZWQtYnk6IFNl YW4gUGF1bCA8c2VhbkBwb29ybHkucnVuPgoKPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0 ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiBDYzogTWF4aW1lIFJpcGFyZCA8bWF4aW1l LnJpcGFyZEBib290bGluLmNvbT4KPiBDYzogU2VhbiBQYXVsIDxzZWFuQHBvb3JseS5ydW4+Cj4g Q2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPiBDYzogRGFuaWVsIFZldHRlciA8 ZGFuaWVsQGZmd2xsLmNoPgo+IENjOiBFcmljIEFuaG9sdCA8ZXJpY0BhbmhvbHQubmV0Pgo+IENj OiBUaG9tYXMgWmltbWVybWFubiA8dHppbW1lcm1hbm5Ac3VzZS5kZT4KPiBDYzogUm9iIEhlcnJp bmcgPHJvYmhAa2VybmVsLm9yZz4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fc2ht ZW1faGVscGVyLmMgfCAxICsKPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4gCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtX3NobWVtX2hlbHBlci5jIGIvZHJp dmVycy9ncHUvZHJtL2RybV9nZW1fc2htZW1faGVscGVyLmMKPiBpbmRleCA0NzJlYTVkODFmODIu LjJmNjQ2NjdhYzgwNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV9zaG1l bV9oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtX3NobWVtX2hlbHBlci5j Cj4gQEAgLTEwLDYgKzEwLDcgQEAKPiAgI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPiAgI2luY2x1 ZGUgPGxpbnV4L3ZtYWxsb2MuaD4KPiAgCj4gKyNpbmNsdWRlIDxkcm0vZHJtLmg+Cj4gICNpbmNs dWRlIDxkcm0vZHJtX2RldmljZS5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9kcnYuaD4KPiAgI2lu Y2x1ZGUgPGRybS9kcm1fZ2VtX3NobWVtX2hlbHBlci5oPgo+IC0tIAo+IDIuMjAuMQo+IAoKLS0g ClNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A381EC7618F for ; Thu, 18 Jul 2019 17:52:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75A8821019 for ; Thu, 18 Jul 2019 17:52:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="psF180gg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=poorly.run header.i=@poorly.run header.b="HH0FL1tb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75A8821019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=poorly.run Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eB38yZZywTfrMeD45BabTi0wVJplN/l9JL4eEHfqZuY=; b=psF180ggnsCBNd ZT+8fNadWsx5XGnSV629Eh23F0991k0N1HZzbXXG5k2GRgqwRBE7IwfWdmX8RrbgkFkw12IAkawxu twzxXlD0vgIG4n5GcjcWXosVmhs4ZWWfY1w/InhDkh7Y7EqvZDwSIKIU0sujpOSuIdWECLAnDAayL uSX1+Xl0HAh2Nm/fyRgTlgjwvPdJ+ACTLPmNHWrVPv+qnDTA5fpT6qo56423vkQBSyGJQeksYlbL1 4MwsVRVCSwUmUgsDa7ui16Y5yqSwadtrGiq9+CaBnYKl0mbHee2t/M9oBgZ8ESNhaxJmBxrq58Anu VTPrGQ2hV1BaBcSFFGuA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hoAZc-0007cu-Az; Thu, 18 Jul 2019 17:52:08 +0000 Received: from mail-yw1-xc44.google.com ([2607:f8b0:4864:20::c44]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hoAYx-00076x-Hj for linux-arm-kernel@lists.infradead.org; Thu, 18 Jul 2019 17:51:32 +0000 Received: by mail-yw1-xc44.google.com with SMTP id q128so12558669ywc.1 for ; Thu, 18 Jul 2019 10:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HclqU1Hi0W57E2gKsEu2RVOLJkHR4HLSFJNAFC1/Q8g=; b=HH0FL1tbuy7uPalwAKfC6ZHeRdaAnjcbTG9jFdzr2xbYH2DBAdmQ6Gb3M0+NvdIgNr 41U4nFb7yULWA1ReJDB7gNtwAk6OiSbmGBqMrNsOkCY79FynHXMTRu51lPTxWDmap6Kg ZzFDoT/Hp+sskhyBFUd7cc+gHOehddjeuD35fJQadoMfpcxw0ngzUkp+bukgbsyFqDTc D1HRS48zMjajSM2IN2HSDvw+F+p9uM83hMJx/KeC6jDvY/OdYcP6pBA8CGK2UjS7WDgr FxOKGlekYtktN9Zu2ZDRAySgP3nnL37wl+4D/vf6V64m5LkSg/66nWDiwv/oREhIIM24 LLGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HclqU1Hi0W57E2gKsEu2RVOLJkHR4HLSFJNAFC1/Q8g=; b=pLufWe/c5fF30QLYiqa/BKPmO62iSkeGC7ueN+dR8YeuDkbyfKFWi0Q+fE0imPztvU VP0PA4vTvGxm6O99BC7zhKb9DTf6DX3/bNqQ8B8kiTFyR527VH7wDS0TnAvsahcJu1Lo 5PY1Xe4haUf7XCpljdhbgVdMuFV1EpPKTGgXbEmDoYghBqrlrQ7BrgfeRPwh9RJtO/47 joYQiCl2ixMzisVnHL2Pj/+sePWUDjB3S5PZCbaCNRrLCMTgFGSC8xyQrkmSQV81E0UZ NuzhTYsJKPnAcalctKuCqSwsAgK5QmOEd+PpZIGCHtXTAjp2A+fexcMkP9GWykig5YuL X7IA== X-Gm-Message-State: APjAAAWZd5HB7z7cUPUkvPbfwWwz0ni3OjYN0CL4rXBLrS1vq9UwWJu5 vCHYKUy8R3E4V/VGzvSQbu+kvQ== X-Google-Smtp-Source: APXvYqz/hgPZl3J9zJ4rzgI3lHx4jd7KFLGFW7byJ9gOKdbCM4y5GD4mmEkDv1a0XOVFBA/waQ2A2g== X-Received: by 2002:a81:23ca:: with SMTP id j193mr28745543ywj.332.1563472286787; Thu, 18 Jul 2019 10:51:26 -0700 (PDT) Received: from localhost ([2620:0:1013:11:89c6:2139:5435:371d]) by smtp.gmail.com with ESMTPSA id b63sm6624338ywb.12.2019.07.18.10.51.26 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 18 Jul 2019 10:51:26 -0700 (PDT) Date: Thu, 18 Jul 2019 13:51:26 -0400 From: Sean Paul To: Sam Ravnborg Subject: Re: [PATCH v1 07/11] drm: direct include of drm.h in drm_gem_shmem_helper.c Message-ID: <20190718175126.GJ31819@art_vandelay> References: <20190718161507.2047-1-sam@ravnborg.org> <20190718161507.2047-8-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190718161507.2047-8-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190718_105127_988268_7F187278 X-CRM114-Status: GOOD ( 15.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Liviu Dudau , dri-devel@lists.freedesktop.org, Chris Wilson , Eric Anholt , Rob Herring , Stefan Agner , Maxime Ripard , CK Hu , Thierry Reding , Daniel Vetter , Chunming Zhou , Jani Nikula , Intel Graphics Development , Maarten Lankhorst , linux-mediatek@lists.infradead.org, Lionel Landwerlin , Matthias Brugger , Sean Paul , linux-arm-kernel@lists.infradead.org, Boris Brezillon , Thomas Zimmermann , Rob Clark , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Philipp Zabel , Christian =?iso-8859-1?Q?K=F6nig?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 18, 2019 at 06:15:03PM +0200, Sam Ravnborg wrote: > Do not rely on including drm.h from drm_file.h, > as the include in drm_file.h will be dropped. > > Signed-off-by: Sam Ravnborg Reviewed-by: Sean Paul > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Eric Anholt > Cc: Thomas Zimmermann > Cc: Rob Herring > --- > drivers/gpu/drm/drm_gem_shmem_helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c > index 472ea5d81f82..2f64667ac805 100644 > --- a/drivers/gpu/drm/drm_gem_shmem_helper.c > +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c > @@ -10,6 +10,7 @@ > #include > #include > > +#include > #include > #include > #include > -- > 2.20.1 > -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel