From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH] drm/i915: Flush extra hard after writing relocations through the GTT Date: Fri, 19 Jul 2019 00:45:29 +0000 Message-ID: <20190719004530.5FB382173B@mail.kernel.org> References: <20190718195650.20635-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id B00D26E484 for ; Fri, 19 Jul 2019 00:45:30 +0000 (UTC) In-Reply-To: <20190718195650.20635-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Sasha Levin , Chris Wilson , intel-gfx@lists.freedesktop.org Cc: stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org SGksCgpbVGhpcyBpcyBhbiBhdXRvbWF0ZWQgZW1haWxdCgpUaGlzIGNvbW1pdCBoYXMgYmVlbiBw cm9jZXNzZWQgYmVjYXVzZSBpdCBjb250YWlucyBhIC1zdGFibGUgdGFnLgpUaGUgc3RhYmxlIHRh ZyBpbmRpY2F0ZXMgdGhhdCBpdCdzIHJlbGV2YW50IGZvciB0aGUgZm9sbG93aW5nIHRyZWVzOiBh bGwKClRoZSBib3QgaGFzIHRlc3RlZCB0aGUgZm9sbG93aW5nIHRyZWVzOiB2NS4yLjEsIHY1LjEu MTgsIHY0LjE5LjU5LCB2NC4xNC4xMzMsIHY0LjkuMTg1LCB2NC40LjE4NS4KCnY1LjIuMTogRmFp bGVkIHRvIGFwcGx5ISBQb3NzaWJsZSBkZXBlbmRlbmNpZXM6CiAgICBVbmFibGUgdG8gY2FsY3Vs YXRlCgp2NS4xLjE4OiBGYWlsZWQgdG8gYXBwbHkhIFBvc3NpYmxlIGRlcGVuZGVuY2llczoKICAg IFVuYWJsZSB0byBjYWxjdWxhdGUKCnY0LjE5LjU5OiBGYWlsZWQgdG8gYXBwbHkhIFBvc3NpYmxl IGRlcGVuZGVuY2llczoKICAgIFVuYWJsZSB0byBjYWxjdWxhdGUKCnY0LjE0LjEzMzogRmFpbGVk IHRvIGFwcGx5ISBQb3NzaWJsZSBkZXBlbmRlbmNpZXM6CiAgICAzYmQ0MDczNTI0ZmEgKCJkcm0v aTkxNTogQ29uc29saWRhdGUgZ2V0X2ZlbmNlIHdpdGggcGluX2ZlbmNlIikKICAgIDQ2NWM0MDNj YjUwOCAoImRybS9pOTE1OiBpbnRyb2R1Y2Ugc2ltcGxlIGdlbWZzIikKICAgIDY2ZGYxMDE0ZWZi YSAoImRybS9pOTE1OiBLZWVwIGEgc21hbGwgc3Rhc2ggb2YgcHJlYWxsb2NhdGVkIFdDIHBhZ2Vz IikKICAgIDczOTNiN2VlM2E5YyAoImRybS9pOTE1L2RlYnVnZnM6IGluY2x1ZGUgc29tZSBndHQg cGFnZSBzaXplIG1ldHJpY3MiKQogICAgNzNlYmQ1MDMwMzRjICgiZHJtL2k5MTU6IG1ha2UgbWFw cGFibGUgc3RydWN0IHJlc291cmNlIGNlbnRyaWMiKQogICAgNzc4OTQyMjY2NWY1ICgiZHJtL2k5 MTU6IG1ha2UgZHNtIHN0cnVjdCByZXNvdXJjZSBjZW50cmljIikKICAgIDgyYWQ2NDQzYTU1ZSAo ImRybS9pOTE1L2d0dDogUmVuYW1lIGk5MTVfaHdfcHBndHQgYmFzZSBtZW1iZXIiKQogICAgOTY5 YjA5NTBhMTg4ICgiZHJtL2k5MTU6IEFkZCBpbnRlcmZhY2UgdG8gcmVzZXJ2ZSBmZW5jZSByZWdp c3RlcnMgZm9yIHZHUFUiKQogICAgYTY1YWRhZjhhODM0ICgiZHJtL2k5MTU6IFRyYWNrIHVzZXIg R1RUIGZhdWx0aW5nIHBlci12bWEiKQogICAgYjFhY2U2MDEwN2U2ICgiZHJtL2k5MTU6IGdpdmUg c3RvbGVuX3VzYWJsZV9zaXplIGEgbW9yZSBzdWl0YWJsZSBob21lIikKICAgIGI3MTI4ZWYxMjVi NCAoImRybS9pOTE1OiBwcmVmZXIgcmVzb3VyY2Vfc2l6ZV90IGZvciBldmVyeXRoaW5nIHN0b2xl biIpCiAgICBkYTFkZDBkYmUwMjQgKCJkcm0vaTkxNTogTWFrZSB0aGUgcmVwb3J0IGFib3V0IGEg Ym9ndXMgc3RvbGVuIHJlc2VydmVkIGFyZWEgYW4gZXJyb3IiKQogICAgZGI3ZmI2MDU5M2U0ICgi ZHJtL2k5MTU6IENoZWNrIGlmIHRoZSBzdG9sZW4gbWVtb3J5ICJyZXNlcnZlZCIgYXJlYSBpcyBl bmFibGVkIG9yIG5vdCIpCiAgICBlOTFlZjk5Yjk1NDMgKCJkcm0vaTkxNS9zZWxmdGVzdHM6IFJl bWVtYmVyIHRvIGNyZWF0ZSB0aGUgZmFrZSBwcmVlbXB0IGNvbnRleHQiKQogICAgZjc3MzU2OGI2 ZmY4ICgiZHJtL2k5MTU6IG51a2UgdGhlIGR1cGxpY2F0ZWQgc3RvbGVuIGRpc2NvdmVyeSIpCgp2 NC45LjE4NTogRmFpbGVkIHRvIGFwcGx5ISBQb3NzaWJsZSBkZXBlbmRlbmNpZXM6CiAgICAwNGQz NDhhZTNmMGEgKCJkcm0vaTkxNS9ndnQ6IHZHUFUgZGlzcGxheSB2aXJ0dWFsaXphdGlvbiIpCiAg ICAxMmQxNGNjNDNiMzQgKCJkcm0vaTkxNS9ndnQ6IEludHJvZHVjZSBhIGZyYW1ld29yayBmb3Ig dHJhY2tpbmcgSFcgcmVnaXN0ZXJzLiIpCiAgICAyOGE2MGRlZTJjZTYgKCJkcm0vaTkxNS9ndnQ6 IHZHUFUgSFcgcmVzb3VyY2UgbWFuYWdlbWVudCIpCiAgICAzZjcyODIzNmM1MTYgKCJkcm0vaTkx NS9ndnQ6IHRyYWNlIHN0dWIiKQogICAgNGM3ZDYyYzZiOGEyICgiZHJtL2k5MTU6IE1hcmt1cCBH RU0gQVBJIHdpdGggbG9ja2RlcCBhc3NlcnRzIikKICAgIDRkNjBjNWZkM2Y4NyAoImRybS9pOTE1 L2d2dDogdkdQVSBQQ0kgY29uZmlndXJhdGlvbiBzcGFjZSB2aXJ0dWFsaXphdGlvbiIpCiAgICA1 NzljZWE1ZjMwZjIgKCJkcm0vaTkxNS9ndnQ6IGdvbGRlbiB2aXJ0dWFsIEhXIHN0YXRlIG1hbmFn ZW1lbnQiKQogICAgNjUwYmM2MzU2OGU0ICgiZHJtL2k5MTU6IEFtYWxnYW1hdGUgZXhlY2J1ZmZl ciBwYXJhbWV0ZXIgc3RydWN0dXJlcyIpCiAgICA3MTg2NTlhNjMwNTQgKCJkcm0vaTkxNTogUmVu YW1lIHNvbWUgd2FydHMgaW4gdGhlIFZNQSBBUEkiKQogICAgODJkMzc1ZDFiNTY4ICgiZHJtL2k5 MTUvZ3Z0OiBJbnRyb2R1Y2UgYmFzaWMgdkdQVSBsaWZlIGN5Y2xlIG1hbmFnZW1lbnQiKQogICAg ODQ1M2Q2NzRhZTdlICgiZHJtL2k5MTUvZ3Z0OiB2R1BVIGV4ZWNsaXN0IHZpcnR1YWxpemF0aW9u IikKICAgIGM4ZmU2YTY4MTFhNyAoImRybS9pOTE1L2d2dDogdkdQVSBpbnRlcnJ1cHQgdmlydHVh bGl6YXRpb24uIikKICAgIGUzOWM1YWRkMzIyMSAoImRybS9pOTE1L2d2dDogdkdQVSBNTUlPIHZp cnR1YWxpemF0aW9uIikKICAgIGU0NzM0MDU3ODNjMCAoImRybS9pOTE1L2d2dDogdkdQVSB3b3Jr bG9hZCBzY2hlZHVsZXIiKQogICAgZTk1NDMzYzczYTExICgiZHJtL2k5MTU6IFJlYXJyYW5nZSBp OTE1X3dhaXRfcmVxdWVzdCgpIGFjY291bnRpbmcgd2l0aCBjYWxsZXJzIikKCnY0LjQuMTg1OiBG YWlsZWQgdG8gYXBwbHkhIFBvc3NpYmxlIGRlcGVuZGVuY2llczoKICAgIDAzMzkwOGFlZDVhNSAo ImRybS9pOTE1OiBtYXJrIEdFTSBvYmplY3QgcGFnZXMgZGlydHkgd2hlbiBtYXBwZWQgJiB3cml0 dGVuIGJ5IHRoZSBDUFUiKQogICAgMDU4ZDg4YzQzMzBmICgiZHJtL2k5MTU6IFRyYWNrIHBpbm5l ZCBWTUEiKQogICAgMDljZmNiNDU2OTQxICgiZHJtL2k5MTU6IFNwbGl0IG91dCBsb2FkIHRpbWUg SFcgaW5pdGlhbGl6YXRpb24iKQogICAgMGE5ZDJiZWQ1NTU3ICgiZHJtL2k5MTUvc2tsOiBNYWtp bmcgREM2IGVudHJ5IGlzIHRoZSBsYXN0IGNhbGwgaW4gc3VzcGVuZCBmbG93LiIpCiAgICAxODhj MWFiNzc2OWQgKCJkcm0vaTkxNTogQWRkIHN0cnVjdF9tdXRleCBsb2NraW5nIGZvciBkZWJ1Z3Mv aTkxNV9nZW1fZnJhbWVidWZmZXIiKQogICAgMWY4MTRkYWNhNDNhICgiZHJtL2k5MTU6IGFkZCBz dXBwb3J0IGZvciBjaGVja2luZyBpZiB3ZSBob2xkIGFuIFJQTSByZWZlcmVuY2UiKQogICAgMzFh MzkyMDdmMDRhICgiZHJtL2k5MTU6IENhY2hlIGttYXAgYmV0d2VlbiByZWxvY2F0aW9ucyIpCiAg ICAzOTliYjViNmRiMDIgKCJkcm0vaTkxNTogTW92ZSBhbGxvY2F0aW9uIG9mIHZhcmlvdXMgd29y a3F1ZXVlcyBlYXJsaWVyIGR1cmluZyBpbml0IikKICAgIDQxNGI3OTk5YjhiZSAoImRybS9pOTE1 L2dlbjk6IFJlbW92ZSBjc3Iuc3RhdGUsIGNzcl9sb2NrIGFuZCByZWxhdGVkIGNvZGUuIikKICAg IDUwNmE4ZTg3ZDhkMiAoImRybS9pOTE1OiBBZGQgc29mdC1waW5uaW5nIEFQSSBmb3IgZXhlY2J1 ZmZlciIpCiAgICA2MjEwNmI0ZjZiOTEgKCJkcm0vaTkxNTogUmVuYW1lIGRldl9wcml2LT5ndHQg dG8gZGV2X3ByaXYtPmdndHQiKQogICAgNzJlOTZkNjQ1MGMwICgiZHJtL2k5MTU6IFJlZmVyIHRv IEdHVFQgeyxWTX0gY29uc2lzdGVudGx5IikKICAgIDczZGZjMjI3ZmY1YyAoImRybS9pOTE1L3Nr bDogaW5pdC91bmluaXQgZGlzcGxheSBjb3JlIGFzIHBhcnQgb2YgdGhlIEhXIHBvd2VyIGRvbWFp biBzdGF0ZSIpCiAgICA4ZGEzMjcyN2FjMGUgKCJkcm0vaTkxNTogUmVtb3ZlIGk5MTVfZ2VtX29i al9zaXplIikKICAgIDkzNGFjY2UzYzA2OSAoImRybS9pOTE1OiBBdm9pZCB3cml0aW5nIHJlbG9j cyB3aXRoIGFkZHJlc3NlcyBpbiBub24tY2Fub25pY2FsIGZvcm0iKQogICAgOWUyNzkzZjZlNGUy ICgiZHJtL2k5MTU6IGNvbXBpbGUtdGltZSBjb25zaXN0ZW5jeSBjaGVjayBvbiBfX0VYRUNfT0JK RUNUIGZsYWdzIikKICAgIGFkNWMzZDNmZmJiMiAoImRybS9pOTE1OiBNb3ZlIE1DSEJBUiBzZXR1 cCBlYXJsaWVyIGR1cmluZyBpbml0IikKICAgIGJjODcyMjlmMzIzZSAoImRybS9pOTE1L3NrbDog ZW5hYmxlIFBDOS8xMCBwb3dlciBzdGF0ZXMgZHVyaW5nIHN1c3BlbmQtdG8taWRsZSIpCiAgICBi ZTEyYTg2YjQ2ZTggKCJkcm0vaTkxNTogU2hvdyBwaW4gbWFwcGVkIHN0YXR1cyBpbiBkZXNjcmli ZV9vYmoiKQogICAgZDUwNDE1Y2M2YzgzICgiZHJtL2k5MTU6IFJlZmFjdG9yIGV4ZWNidWZmZXIg cmVsb2NhdGlvbiB3cml0aW5nIikKICAgIGY1MTRjMmQ4NDI4NSAoImRybS9pOTE1L2dlbjk6IGZs dXNoIERNQyBmdyBsb2FkaW5nIHdvcmsgZHVyaW5nIHN5c3RlbSBzdXNwZW5kIikKCgpOT1RFOiBU aGUgcGF0Y2ggd2lsbCBub3QgYmUgcXVldWVkIHRvIHN0YWJsZSB0cmVlcyB1bnRpbCBpdCBpcyB1 cHN0cmVhbS4KCkhvdyBzaG91bGQgd2UgcHJvY2VlZCB3aXRoIHRoaXMgcGF0Y2g/CgotLQpUaGFu a3MsClNhc2hhCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A264DC7618F for ; Fri, 19 Jul 2019 00:45:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7854121850 for ; Fri, 19 Jul 2019 00:45:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563497132; bh=f+FCiwMTxTR3LwJ72Yd6Y80QgOqMnV4ta98udR3z5QE=; h=Date:From:To:To:To:Cc:Cc:Cc:Subject:In-Reply-To:References: List-ID:From; b=co94TeMh/nt0Kh+PCTylEL8gZsanwVxZoIlqCAJsVLxRQtDMtZQfK75kKHbovGb6U 2U0qJi2kW6Pwahr19vReaelOTC2kg32u1s2Tznf//uId6FimDS6DkmG0lpqhuXc578 gcHPFAd7U4TnrdssIVaVPTn2ZqkaKH0/K/jrRrcM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726055AbfGSApc (ORCPT ); Thu, 18 Jul 2019 20:45:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:51306 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726015AbfGSApb (ORCPT ); Thu, 18 Jul 2019 20:45:31 -0400 Received: from localhost (unknown [23.100.24.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5FB382173B; Fri, 19 Jul 2019 00:45:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563497130; bh=f+FCiwMTxTR3LwJ72Yd6Y80QgOqMnV4ta98udR3z5QE=; h=Date:From:To:To:To:Cc:Cc:Cc:Subject:In-Reply-To:References:From; b=KwYbp3NRuaNghfAzrMgxfxv8bdomCbII3nJpeiUjBn0Ah+vu9CpkPsjtSoCr16FOf 0sJqOkQ5pu/rRnJFXlxnX84YHeGLAVzebk0goOYU5Ux9p97w5Kh98hBmcAzVxIfmTm T/9i5PLlJ9mkOxUnkxAsmyJTIrLW9yuYg0/LYYLU= Date: Fri, 19 Jul 2019 00:45:29 +0000 From: Sasha Levin To: Sasha Levin To: Chris Wilson To: intel-gfx@lists.freedesktop.org Cc: Chris Wilson , stable@vger.kernel.org Cc: stable@vger.kernel.org Cc: stable@vger.kernel.org Subject: Re: [PATCH] drm/i915: Flush extra hard after writing relocations through the GTT In-Reply-To: <20190718195650.20635-1-chris@chris-wilson.co.uk> References: <20190718195650.20635-1-chris@chris-wilson.co.uk> Message-Id: <20190719004530.5FB382173B@mail.kernel.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.2.1, v5.1.18, v4.19.59, v4.14.133, v4.9.185, v4.4.185. v5.2.1: Failed to apply! Possible dependencies: Unable to calculate v5.1.18: Failed to apply! Possible dependencies: Unable to calculate v4.19.59: Failed to apply! Possible dependencies: Unable to calculate v4.14.133: Failed to apply! Possible dependencies: 3bd4073524fa ("drm/i915: Consolidate get_fence with pin_fence") 465c403cb508 ("drm/i915: introduce simple gemfs") 66df1014efba ("drm/i915: Keep a small stash of preallocated WC pages") 7393b7ee3a9c ("drm/i915/debugfs: include some gtt page size metrics") 73ebd503034c ("drm/i915: make mappable struct resource centric") 7789422665f5 ("drm/i915: make dsm struct resource centric") 82ad6443a55e ("drm/i915/gtt: Rename i915_hw_ppgtt base member") 969b0950a188 ("drm/i915: Add interface to reserve fence registers for vGPU") a65adaf8a834 ("drm/i915: Track user GTT faulting per-vma") b1ace60107e6 ("drm/i915: give stolen_usable_size a more suitable home") b7128ef125b4 ("drm/i915: prefer resource_size_t for everything stolen") da1dd0dbe024 ("drm/i915: Make the report about a bogus stolen reserved area an error") db7fb60593e4 ("drm/i915: Check if the stolen memory "reserved" area is enabled or not") e91ef99b9543 ("drm/i915/selftests: Remember to create the fake preempt context") f773568b6ff8 ("drm/i915: nuke the duplicated stolen discovery") v4.9.185: Failed to apply! Possible dependencies: 04d348ae3f0a ("drm/i915/gvt: vGPU display virtualization") 12d14cc43b34 ("drm/i915/gvt: Introduce a framework for tracking HW registers.") 28a60dee2ce6 ("drm/i915/gvt: vGPU HW resource management") 3f728236c516 ("drm/i915/gvt: trace stub") 4c7d62c6b8a2 ("drm/i915: Markup GEM API with lockdep asserts") 4d60c5fd3f87 ("drm/i915/gvt: vGPU PCI configuration space virtualization") 579cea5f30f2 ("drm/i915/gvt: golden virtual HW state management") 650bc63568e4 ("drm/i915: Amalgamate execbuffer parameter structures") 718659a63054 ("drm/i915: Rename some warts in the VMA API") 82d375d1b568 ("drm/i915/gvt: Introduce basic vGPU life cycle management") 8453d674ae7e ("drm/i915/gvt: vGPU execlist virtualization") c8fe6a6811a7 ("drm/i915/gvt: vGPU interrupt virtualization.") e39c5add3221 ("drm/i915/gvt: vGPU MMIO virtualization") e473405783c0 ("drm/i915/gvt: vGPU workload scheduler") e95433c73a11 ("drm/i915: Rearrange i915_wait_request() accounting with callers") v4.4.185: Failed to apply! Possible dependencies: 033908aed5a5 ("drm/i915: mark GEM object pages dirty when mapped & written by the CPU") 058d88c4330f ("drm/i915: Track pinned VMA") 09cfcb456941 ("drm/i915: Split out load time HW initialization") 0a9d2bed5557 ("drm/i915/skl: Making DC6 entry is the last call in suspend flow.") 188c1ab7769d ("drm/i915: Add struct_mutex locking for debugs/i915_gem_framebuffer") 1f814daca43a ("drm/i915: add support for checking if we hold an RPM reference") 31a39207f04a ("drm/i915: Cache kmap between relocations") 399bb5b6db02 ("drm/i915: Move allocation of various workqueues earlier during init") 414b7999b8be ("drm/i915/gen9: Remove csr.state, csr_lock and related code.") 506a8e87d8d2 ("drm/i915: Add soft-pinning API for execbuffer") 62106b4f6b91 ("drm/i915: Rename dev_priv->gtt to dev_priv->ggtt") 72e96d6450c0 ("drm/i915: Refer to GGTT {,VM} consistently") 73dfc227ff5c ("drm/i915/skl: init/uninit display core as part of the HW power domain state") 8da32727ac0e ("drm/i915: Remove i915_gem_obj_size") 934acce3c069 ("drm/i915: Avoid writing relocs with addresses in non-canonical form") 9e2793f6e4e2 ("drm/i915: compile-time consistency check on __EXEC_OBJECT flags") ad5c3d3ffbb2 ("drm/i915: Move MCHBAR setup earlier during init") bc87229f323e ("drm/i915/skl: enable PC9/10 power states during suspend-to-idle") be12a86b46e8 ("drm/i915: Show pin mapped status in describe_obj") d50415cc6c83 ("drm/i915: Refactor execbuffer relocation writing") f514c2d84285 ("drm/i915/gen9: flush DMC fw loading work during system suspend") NOTE: The patch will not be queued to stable trees until it is upstream. How should we proceed with this patch? -- Thanks, Sasha