From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>
Subject: Re: linux-next: Tree for Jul 18 (header build error)
Date: Fri, 19 Jul 2019 10:05:57 +1000 [thread overview]
Message-ID: <20190719100557.3ead3285@canb.auug.org.au> (raw)
In-Reply-To: <127d228c-322d-6349-382b-d304974df148@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
Hi all,
On Thu, 18 Jul 2019 10:00:22 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>
> on x86_64, when CONFIG_BLOCK is not set:
>
> CC include/linux/iomap.h.s
> In file included from <command-line>:0:0:
> ./../include/linux/iomap.h: In function ‘iomap_sector’:
> ./../include/linux/iomap.h:76:48: error: ‘SECTOR_SHIFT’ undeclared (first use in this function); did you mean ‘SECTIONS_SHIFT’?
> return (iomap->addr + pos - iomap->offset) >> SECTOR_SHIFT;
> ^~~~~~~~~~~~
include/linux/iomap.h should only be used when CONFIG_BLOCK is set (if
you follow the Kconfig trail). So maybe this header should only be
compile tested if CONFIG_BLOCK is set.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-19 0:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 3:37 linux-next: Tree for Jul 18 Stephen Rothwell
2019-07-18 17:00 ` linux-next: Tree for Jul 18 (header build error) Randy Dunlap
2019-07-19 0:05 ` Stephen Rothwell [this message]
2019-07-19 0:30 ` Darrick J. Wong
2019-07-19 0:40 ` Stephen Rothwell
2019-07-19 0:36 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719100557.3ead3285@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=darrick.wong@oracle.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.