Re: [PATCH iproute2-rc v1 0/7] Statistics counter support

[Stephen Hemminger <stephen@networkplumber.org>]

On Wed, 17 Jul 2019 17:31:49 +0300
Leon Romanovsky <leon@kernel.org> wrote:

> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Changelog v0->v1:
>  * Fixed typo in manual page (Gal)
>  * Rebased on top of d035cc1b "ip tunnel: warn when changing IPv6 tunnel without tunnel name"
>  * Dropped update header file because it was already merged.
> 
> ---------------------------------------------------------------------------------------
> 
> Hi,
> 
> This is supplementary part of accepted to rdma-next kernel series,
> that kernel series provided an option to get various counters: global
> and per-objects.
> 
> Currently, all counters are printed in format similar to other
> device/link properties, while "-p" option will print them in table like
> format.
> 
> [leonro@server ~]$ rdma stat show
> link mlx5_0/1 rx_write_requests 0 rx_read_requests 0 rx_atomic_requests
> 0 out_of_buffer 0 duplicate_request 0 rnr_nak_retry_err 0 packet_seq_err
> 0 implied_nak_seq_err 0 local_ack_timeout_err 0 resp_local_length_error
> 0 resp_cqe_error 0 req_cqe_error 0 req_remote_invalid_request 0
> req_remote_access_errors 0 resp_remote_access_errors 0
> resp_cqe_flush_error 0 req_cqe_flush_error 0 rp_cnp_ignored 0
> rp_cnp_handled 0 np_ecn_marked_roce_packets 0 np_cnp_sent 0
> 
> [leonro@server ~]$ rdma stat show -p
> link mlx5_0/1
> 	rx_write_requests 0
> 	rx_read_requests 0
> 	rx_atomic_requests 0
> 	out_of_buffer 0
> 	duplicate_request 0
> 	rnr_nak_retry_err 0
> 	packet_seq_err 0
> 	implied_nak_seq_err 0
> 	local_ack_timeout_err 0
> 	resp_local_length_error 0
> 	resp_cqe_error 0
> 	req_cqe_error 0
> 	req_remote_invalid_request 0
> 	req_remote_access_errors 0
> 	resp_remote_access_errors 0
> 	resp_cqe_flush_error 0
> 	req_cqe_flush_error 0
> 	rp_cnp_ignored 0
> 	rp_cnp_handled 0
> 	np_ecn_marked_roce_packets 0
> 	np_cnp_sent 0
> 
> Thanks
> 
> Mark Zhang (7):
>   rdma: Add "stat qp show" support
>   rdma: Add get per-port counter mode support
>   rdma: Add rdma statistic counter per-port auto mode support
>   rdma: Make get_port_from_argv() returns valid port in strict port mode
>   rdma: Add stat manual mode support
>   rdma: Add default counter show support
>   rdma: Document counter statistic
> 
>  man/man8/rdma-dev.8       |   1 +
>  man/man8/rdma-link.8      |   1 +
>  man/man8/rdma-resource.8  |   1 +
>  man/man8/rdma-statistic.8 | 167 +++++++++
>  man/man8/rdma.8           |   7 +-
>  rdma/Makefile             |   2 +-
>  rdma/rdma.c               |   3 +-
>  rdma/rdma.h               |   1 +
>  rdma/stat.c               | 759 ++++++++++++++++++++++++++++++++++++++
>  rdma/utils.c              |  17 +-
>  10 files changed, 954 insertions(+), 5 deletions(-)
>  create mode 100644 man/man8/rdma-statistic.8
>  create mode 100644 rdma/stat.c
> 
> --
> 2.20.1
> 

Applied now, thanks