Re: [PATCHv2 4/4] doc: document power-event signals for quectel Hardware API

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]

On Fri 2019-07-19 12:19:14, Martin Hundebøll wrote:
> ---
> 
> Changes since v1:
>  * new patch split out from PATCHv1 7/7
> 
>  doc/quectel-hardware-api.txt | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/doc/quectel-hardware-api.txt b/doc/quectel-hardware-api.txt
> index 6aafbfd8..411afcd1 100644
> --- a/doc/quectel-hardware-api.txt
> +++ b/doc/quectel-hardware-api.txt
> @@ -10,6 +10,25 @@ Methods		array{string,variant} GetProperties
>  			Returns hardware properties for the modem object. See
>  			the properties section for available properties.
>  
> +Signals		PowerDown(string reason)
> +
> +			This signal is emitted on gracefull shutdowns initiated
> +			by the modem.
> +
> +			Possible reasons:
> +				"LowPower"	The supply voltage is too low
> +				"Normal"	The PWRKEY pin was asserted
> +				"HighPower"	The supply voltage is too high
> +
> +		PowerWarning(string reason)
> +
> +			This signal is emitted when the modem detects its supply
> +			voltage is close to its supported limits.
> +
> +			Possible reasons:
> +				"LowPower"	The supply voltage is low
> +				"HighPower"	The supply voltage is high
> +

It is "high voltage" not "high power", so maybe it should be
"HighVoltage" (etc?).

("Low power" sounds like device entered powersaving mode).
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]