From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v1 11/11] drm: drop uapi dependency from drm_file.h Date: Fri, 19 Jul 2019 13:08:00 +0200 Message-ID: <20190719110800.GA3247@ravnborg.org> References: <20190718161507.2047-1-sam@ravnborg.org> <20190718161507.2047-12-sam@ravnborg.org> <57ad927c-4b7f-d6e2-edda-720386190054@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <57ad927c-4b7f-d6e2-edda-720386190054@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Koenig, Christian" Cc: David Airlie , Daniel Vetter , Liviu Dudau , "dri-devel@lists.freedesktop.org" , Maxime Ripard , Thierry Reding , Jani Nikula , Intel Graphics Development , "linux-mediatek@lists.infradead.org" , Matthias Brugger , Sean Paul , "linux-arm-kernel@lists.infradead.org" , Boris Brezillon , Thomas Zimmermann , Sean Paul List-Id: linux-mediatek@lists.infradead.org SGkgQ2hyaXN0aWFuLgoKVGhhbmtzIGZvciB5b3VyIGNvbW1lbnRzIGFuZCB2ZXJ5IHZhbGlkIHF1 ZXN0aW9uLgoKT24gRnJpLCBKdWwgMTksIDIwMTkgYXQgMDY6NTY6NDdBTSArMDAwMCwgS29lbmln LCBDaHJpc3RpYW4gd3JvdGU6Cj4gQW0gMTguMDcuMTkgdW0gMTg6MTUgc2NocmllYiBTYW0gUmF2 bmJvcmc6Cj4gPiBkcm1fZmlsZSB1c2VkIGRybV9tYWdpY190IGZyb20gdWFwaS9kcm0vZHJtLmgu Cj4gPiBUaGlzIGlzIGEgc2ltcGxlIHVuc2lnbmVkIGludC4KPiA+IEp1c3Qgb3BlbmNvZGUgaXQg YXMgc3VjaCB0byBicmVhayB0aGUgZGVwZW5kZW5jeSBmcm9tIHRoaXMgaGVhZGVyIGZpbGUKPiA+ IHRvIHVhcGkuCj4gCj4gTWhtLCB3aHkgZG8geW91IHdhbnQgdG8gcmVtb3ZlIFVBUEkgZGVwZW5k ZW5jeSBoZXJlIGluIHRoZSBmaXJzdCBwbGFjZT8KClRoZSBpZGVhIGlzIHRvIG1ha2UgaW5jbHVk ZS9kcm0vKiBpbmRlcGVuZGVudCBvZiB1YXBpL2RybS8qIHNvIHRoZQpoZWFkZXIgZmlsZXMgYXJl IGxlc3MgdGFuZ2xlZCB1cCB0aHVzIGVhc2llciB0byByZWFkIGFuZCBjb21wcmVoZW5kLgoKLmMg ZmlsZXMgdGhhdCByZXF1aXJlcyB1YXBpIGNhbiB0aGVuIGluY2x1ZGUgdGhlIHVhcGkgaGVhZGVy cy4KCkZvciBub3cgbXkgZm9jdXMgd2FzIHNvbGVseSBvbiB1YXBpL2RybS9kcm0uaCAtIHNvIEkg ZHVubm8gaWYgdGhpcwppcyBhbiBhY2hpZXZhYmxlIGdvYWwgZm9yIGluY2x1ZGUvZHJtLyouCgpG b3IgdWFwaS9kcm0vKiBoZWFkZXJzIHRoaW5ncyBhcmUgbW9yZSBjbGVhci4gVGhleSBzaGFsbCBi ZQppbmRlcGVuZGVudCBvZiBpbmNsdWRlL2RybS8qIGFzIHRoZXkgYXJlIGV4cG9ydGVkLgoKPiBJ IG1lYW4gdGhlIHR5cGUgY2FuJ3QgY2hhbmdlIGJlY2F1c2UgaXQgaXMgVUFQSSwgYnV0IGl0IGlz IHJhdGhlciBiYWQgCj4gZm9yIGEgZG9jdW1lbnRhdGlvbiBwb2ludCBvZiB2aWV3LgoKRm9yIGEg d2lkZWx5IHVzZWQgdHlwZSBJIHdvdWxkIGFncmVlLgpGb3Igc3RydWN0IGF1dGgsIHRoYXQgaXMg b255IHVzZWQgaW4gZHJtX2F1dGguYyB0aGVuIHRoZSBkb2N1bWVudGF0aW9uCmltcGFjdCBpcyBt aW5vci4gQnV0IHlvdXIgcG9pbnQgaXMgaW5kZWVkIHZhbGlkLgooc3RydWN0IGF1dGggaGFzIG9u ZSBmaWVsZCBvZiB0eXBlIG1hZ2ljX3QpLgoKSSB3aWxsIGF3YWl0IGZ1cnRoZXIgZmVlZGJhY2sg YmVmb3JlIHdlIGRlY2lkZSB0byBhcHBseSB0aGlzIHBhdGNoIG9yCm5vdC4KVGhlIHBhdGNoZXMg dGhhdCBwdXNoZXMgaW5jbHVkZSBvZiBkcm0vZHJtLmggdG8gdGhlIHJlc3BlY3RpdmUgLmMKZmls ZXMgYXJlIGxlZ2l0IGFzIHdlIGRyb3AgdGhlIGRlcGVuZGVuY3kgb24gYW4gaW5kaXJlY3RseSBp bmNsdWRlZApoZWFkZXIgZmlsZS4gSSB3aWxsIHByb2Nlc3MgdGhlc2UgcGF0Y2hlcy4KCglTYW0K X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00CE4C76188 for ; Fri, 19 Jul 2019 11:08:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF86620693 for ; Fri, 19 Jul 2019 11:08:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iY8ZzLnp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF86620693 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=27jeeSP/A/AubxE3sUTxyV1WgrMh8eopQt5BGnRqN6o=; b=iY8ZzLnp1+sjvy y44i17lvQMpqlTPCp7nHjxGsMf+Ud43Y/hAz1ZchtECoRI5Bp5CgjzqavV+RNWBGP/NSirjDFo6Qq iFI/9f4z5uNej9keRPV05EpgVql7v8+Zuf7jjP/0zoraz0FFZo5w7MQC93rlsonJcxDEC1gKe9YyR C8lbCdJS88I2ukWb/t5xOqtD5Y1eIhLUODAB7TbrR8slOYSISqLzxJSzfdb2RDUz4GD5r5lgKB3xP PVSKmCUq2/6apkaugCW+UCcg9GSkP29g8u8vP9znuoYzvjNKlVGwIQ2FG06vYuieKyXu+DJAVlylL qU+RzvIkCJGs1rP1AKRg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hoQkG-0002l4-Ag; Fri, 19 Jul 2019 11:08:12 +0000 Received: from asavdk3.altibox.net ([109.247.116.14]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hoQkB-0002hk-WC; Fri, 19 Jul 2019 11:08:09 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 24E792008A; Fri, 19 Jul 2019 13:08:01 +0200 (CEST) Date: Fri, 19 Jul 2019 13:08:00 +0200 From: Sam Ravnborg To: "Koenig, Christian" Subject: Re: [PATCH v1 11/11] drm: drop uapi dependency from drm_file.h Message-ID: <20190719110800.GA3247@ravnborg.org> References: <20190718161507.2047-1-sam@ravnborg.org> <20190718161507.2047-12-sam@ravnborg.org> <57ad927c-4b7f-d6e2-edda-720386190054@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <57ad927c-4b7f-d6e2-edda-720386190054@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=eF2l136HLxNaSI10T0kA:9 a=CjuIK1q_8ugA:10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190719_040808_216702_84C76961 X-CRM114-Status: GOOD ( 14.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Daniel Vetter , Liviu Dudau , "dri-devel@lists.freedesktop.org" , Chris Wilson , Eric Anholt , "Zhou, David\(ChunMing\)" , Stefan Agner , Maxime Ripard , CK Hu , Thierry Reding , Daniel Vetter , Rob Herring , Jani Nikula , Intel Graphics Development , Maarten Lankhorst , "linux-mediatek@lists.infradead.org" , Lionel Landwerlin , Matthias Brugger , Sean Paul , "linux-arm-kernel@lists.infradead.org" , Boris Brezillon , Thomas Zimmermann , Rob Clark , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Philipp Zabel , Sean Paul Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Christian. Thanks for your comments and very valid question. On Fri, Jul 19, 2019 at 06:56:47AM +0000, Koenig, Christian wrote: > Am 18.07.19 um 18:15 schrieb Sam Ravnborg: > > drm_file used drm_magic_t from uapi/drm/drm.h. > > This is a simple unsigned int. > > Just opencode it as such to break the dependency from this header file > > to uapi. > > Mhm, why do you want to remove UAPI dependency here in the first place? The idea is to make include/drm/* independent of uapi/drm/* so the header files are less tangled up thus easier to read and comprehend. .c files that requires uapi can then include the uapi headers. For now my focus was solely on uapi/drm/drm.h - so I dunno if this is an achievable goal for include/drm/*. For uapi/drm/* headers things are more clear. They shall be independent of include/drm/* as they are exported. > I mean the type can't change because it is UAPI, but it is rather bad > for a documentation point of view. For a widely used type I would agree. For struct auth, that is ony used in drm_auth.c then the documentation impact is minor. But your point is indeed valid. (struct auth has one field of type magic_t). I will await further feedback before we decide to apply this patch or not. The patches that pushes include of drm/drm.h to the respective .c files are legit as we drop the dependency on an indirectly included header file. I will process these patches. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel