From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [RFC PATCH-for-4.1] target/i386: Correct misplaced break statement in gen_shiftd_rm_T1()
Date: Fri, 19 Jul 2019 13:23:15 +0200 [thread overview]
Message-ID: <20190719112315.14432-1-philmd@redhat.com> (raw)
Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2:
CC target/i386/translate.o
target/i386/translate.c: In function ‘gen_shiftd_rm_T1’:
target/i386/translate.c:1785:12: error: this statement may fall through [-Werror=implicit-fallthrough=]
1785 | if (is_right) {
| ^
target/i386/translate.c:1810:5: note: here
1810 | default:
| ^~~~~~~
cc1: all warnings being treated as errors
Fixes: f437d0a3c24
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
target/i386/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/translate.c b/target/i386/translate.c
index 03150a86e2..4b2b5937ca 100644
--- a/target/i386/translate.c
+++ b/target/i386/translate.c
@@ -1805,8 +1805,8 @@ static void gen_shiftd_rm_T1(DisasContext *s, TCGMemOp ot, int op1,
tcg_gen_shri_i64(s->tmp0, s->tmp0, 32);
tcg_gen_shri_i64(s->T0, s->T0, 32);
}
- break;
#endif
+ break;
default:
tcg_gen_subi_tl(s->tmp0, count, 1);
if (is_right) {
--
2.20.1
next reply other threads:[~2019-07-19 11:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 11:23 Philippe Mathieu-Daudé [this message]
2019-07-19 11:45 ` [Qemu-devel] [RFC PATCH-for-4.1] target/i386: Correct misplaced break statement in gen_shiftd_rm_T1() Paolo Bonzini
2019-07-19 11:51 ` Peter Maydell
2019-07-19 12:13 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719112315.14432-1-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.