From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03D4FC76195 for ; Fri, 19 Jul 2019 13:27:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC58C21849 for ; Fri, 19 Jul 2019 13:27:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HpH0X+dR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="PVB/5sDt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC58C21849 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9wUAnghcsInvqffG6uS8sFRUkGnAWA1vZvzldwtxRPc=; b=HpH0X+dRdjIonF yEo315IuXCmF/jDnqm4iUtsIijXyGwz2P7lmAShu7ZQt2lD4Fuy4I5xfsfOnHa0ASoV6yB6QpJmc8 fPpe3SX05g0s0oXbiUWLnZycr/YqTCPiS0bBOXyHcoJDLJkgZAwDWnbYwoY+RoIYgsyLkGgR39LaV I06S0MQ8jqoQdQGqEZ9RTfFT/Ogp33gNiDUEjndxiqns5+5FUJyZdvhB3W8XOV0oo3D1w+NIbThzA i3dJdWz0D7cZueTqyo9PCvHUBD5DYD16CJ4rW2NlE22O1IIp0qDRC+KYsHaA9T9nidVa53zITqhtc qmolKo/nhQarFTJkPUTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hoSuk-0002XO-ST; Fri, 19 Jul 2019 13:27:10 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hoSuh-0002WV-He for linux-riscv@lists.infradead.org; Fri, 19 Jul 2019 13:27:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Pky9viuD0oMDaJSoHdvUAeTOz0jBwYPwJje4fFabTHU=; b=PVB/5sDt8JO1QPzJBKxZ8mraPo F/njzXIy4mL2QNrBSOcPF5R9AhwgOgMGaDXTMT2tsinFyHLTqU0c8nC5u6ClaCqG0mE330J+R0SlS lCzgjEz167T6Wj5iAT7pFI39Hc0tYOToCZVn8xH7TpVEyfO3bYfXCELlIUMHbAtza3pg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hoSuX-0006qO-Iq; Fri, 19 Jul 2019 15:26:57 +0200 Date: Fri, 19 Jul 2019 15:26:57 +0200 From: Andrew Lunn To: Sagar Kadam Subject: Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver Message-ID: <20190719132657.GD24930@lunn.ch> References: <1563534631-15897-1-git-send-email-yash.shah@sifive.com> <1563534631-15897-3-git-send-email-yash.shah@sifive.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190719_062707_740815_58CB8D76 X-CRM114-Status: UNSURE ( 8.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Albert Ou , netdev@vger.kernel.org, Palmer Dabbelt , ynezz@true.cz, Linux Kernel Mailing List , nicolas.ferre@microchip.com, Sachin Ghadi , Yash Shah , Rob Herring , Paul Walmsley , linux-riscv@lists.infradead.org, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Jul 19, 2019 at 05:23:45PM +0530, Sagar Kadam wrote: > > +ð0 { > > + status = "okay"; > > + phy-mode = "gmii"; > > + phy-handle = <&phy1>; > > + phy1: ethernet-phy@0 { > > + reg = <0>; > > + }; Hi Sagar Is there a good reason to call it phy1? Is there a phy0? Thanks Andrew _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver Date: Fri, 19 Jul 2019 15:26:57 +0200 Message-ID: <20190719132657.GD24930@lunn.ch> References: <1563534631-15897-1-git-send-email-yash.shah@sifive.com> <1563534631-15897-3-git-send-email-yash.shah@sifive.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Sagar Kadam Cc: Yash Shah , davem@davemloft.net, Rob Herring , Paul Walmsley , netdev@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List , linux-riscv@lists.infradead.org, Mark Rutland , Albert Ou , Palmer Dabbelt , nicolas.ferre@microchip.com, Sachin Ghadi , ynezz@true.cz List-Id: devicetree@vger.kernel.org On Fri, Jul 19, 2019 at 05:23:45PM +0530, Sagar Kadam wrote: > > +ð0 { > > + status = "okay"; > > + phy-mode = "gmii"; > > + phy-handle = <&phy1>; > > + phy1: ethernet-phy@0 { > > + reg = <0>; > > + }; Hi Sagar Is there a good reason to call it phy1? Is there a phy0? Thanks Andrew