From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Date: Fri, 19 Jul 2019 17:23:35 +0000 Subject: Re: [PATCH -next] drm/i915/dsi: remove set but not used variable 'hfront_porch' Message-Id: <20190719172335.GT5942@intel.com> List-Id: References: <20190719015136.103988-1-yuehaibing@huawei.com> In-Reply-To: <20190719015136.103988-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: YueHaibing Cc: airlied@linux.ie, Hulk Robot , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org On Fri, Jul 19, 2019 at 01:51:36AM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: >=20 > drivers/gpu/drm/i915/display/icl_dsi.c: In function 'gen11_dsi_set_transc= oder_timings': > drivers/gpu/drm/i915/display/icl_dsi.c:768:6: warning: > variable 'hfront_porch' set but not used [-Wunused-but-set-variable] >=20 > It is never used and can be removed. >=20 > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Thanks. Applied to drm-intel-next-queued. > --- > drivers/gpu/drm/i915/display/icl_dsi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i91= 5/display/icl_dsi.c > index 4d952accfaaa..a42348be0438 100644 > --- a/drivers/gpu/drm/i915/display/icl_dsi.c > +++ b/drivers/gpu/drm/i915/display/icl_dsi.c > @@ -763,7 +763,7 @@ gen11_dsi_set_transcoder_timings(struct intel_encoder= *encoder, > enum transcoder dsi_trans; > /* horizontal timings */ > u16 htotal, hactive, hsync_start, hsync_end, hsync_size; > - u16 hfront_porch, hback_porch; > + u16 hback_porch; > /* vertical timings */ > u16 vtotal, vactive, vsync_start, vsync_end, vsync_shift; > =20 > @@ -772,8 +772,6 @@ gen11_dsi_set_transcoder_timings(struct intel_encoder= *encoder, > hsync_start =3D adjusted_mode->crtc_hsync_start; > hsync_end =3D adjusted_mode->crtc_hsync_end; > hsync_size =3D hsync_end - hsync_start; > - hfront_porch =3D (adjusted_mode->crtc_hsync_start - > - adjusted_mode->crtc_hdisplay); > hback_porch =3D (adjusted_mode->crtc_htotal - > adjusted_mode->crtc_hsync_end); > vactive =3D adjusted_mode->crtc_vdisplay; >=20 >=20 --=20 Ville Syrj=E4l=E4 Intel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH -next] drm/i915/dsi: remove set but not used variable 'hfront_porch' Date: Fri, 19 Jul 2019 20:23:35 +0300 Message-ID: <20190719172335.GT5942@intel.com> References: <20190719015136.103988-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190719015136.103988-1-yuehaibing@huawei.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: YueHaibing Cc: airlied@linux.ie, Hulk Robot , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKdWwgMTksIDIwMTkgYXQgMDE6NTE6MzZBTSArMDAwMCwgWXVlSGFpYmluZyB3cm90 ZToKPiBGaXhlcyBnY2MgJy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGUnIHdhcm5pbmc6Cj4gCj4g ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pY2xfZHNpLmM6IEluIGZ1bmN0aW9uICdnZW4x MV9kc2lfc2V0X3RyYW5zY29kZXJfdGltaW5ncyc6Cj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pY2xfZHNpLmM6NzY4OjY6IHdhcm5pbmc6Cj4gIHZhcmlhYmxlICdoZnJvbnRfcG9yY2gn IHNldCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdCj4gCj4gSXQgaXMg bmV2ZXIgdXNlZCBhbmQgY2FuIGJlIHJlbW92ZWQuCj4gCj4gUmVwb3J0ZWQtYnk6IEh1bGsgUm9i b3QgPGh1bGtjaUBodWF3ZWkuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFl1ZUhhaWJpbmcgPHl1ZWhh aWJpbmdAaHVhd2VpLmNvbT4KClRoYW5rcy4gQXBwbGllZCB0byBkcm0taW50ZWwtbmV4dC1xdWV1 ZWQuCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ljbF9kc2kuYyB8IDQg Ky0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDMgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaWNsX2RzaS5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pY2xfZHNpLmMKPiBpbmRleCA0ZDk1MmFjY2Zh YWEuLmE0MjM0OGJlMDQzOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNw bGF5L2ljbF9kc2kuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaWNsX2Rz aS5jCj4gQEAgLTc2Myw3ICs3NjMsNyBAQCBnZW4xMV9kc2lfc2V0X3RyYW5zY29kZXJfdGltaW5n cyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCWVudW0gdHJhbnNjb2RlciBkc2lf dHJhbnM7Cj4gIAkvKiBob3Jpem9udGFsIHRpbWluZ3MgKi8KPiAgCXUxNiBodG90YWwsIGhhY3Rp dmUsIGhzeW5jX3N0YXJ0LCBoc3luY19lbmQsIGhzeW5jX3NpemU7Cj4gLQl1MTYgaGZyb250X3Bv cmNoLCBoYmFja19wb3JjaDsKPiArCXUxNiBoYmFja19wb3JjaDsKPiAgCS8qIHZlcnRpY2FsIHRp bWluZ3MgKi8KPiAgCXUxNiB2dG90YWwsIHZhY3RpdmUsIHZzeW5jX3N0YXJ0LCB2c3luY19lbmQs IHZzeW5jX3NoaWZ0Owo+ICAKPiBAQCAtNzcyLDggKzc3Miw2IEBAIGdlbjExX2RzaV9zZXRfdHJh bnNjb2Rlcl90aW1pbmdzKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJaHN5bmNf c3RhcnQgPSBhZGp1c3RlZF9tb2RlLT5jcnRjX2hzeW5jX3N0YXJ0Owo+ICAJaHN5bmNfZW5kID0g YWRqdXN0ZWRfbW9kZS0+Y3J0Y19oc3luY19lbmQ7Cj4gIAloc3luY19zaXplICA9IGhzeW5jX2Vu ZCAtIGhzeW5jX3N0YXJ0Owo+IC0JaGZyb250X3BvcmNoID0gKGFkanVzdGVkX21vZGUtPmNydGNf aHN5bmNfc3RhcnQgLQo+IC0JCQlhZGp1c3RlZF9tb2RlLT5jcnRjX2hkaXNwbGF5KTsKPiAgCWhi YWNrX3BvcmNoID0gKGFkanVzdGVkX21vZGUtPmNydGNfaHRvdGFsIC0KPiAgCQkgICAgICAgYWRq dXN0ZWRfbW9kZS0+Y3J0Y19oc3luY19lbmQpOwo+ICAJdmFjdGl2ZSA9IGFkanVzdGVkX21vZGUt PmNydGNfdmRpc3BsYXk7Cj4gCj4gCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A5C9C7618F for ; Fri, 19 Jul 2019 17:23:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21A102186A for ; Fri, 19 Jul 2019 17:23:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731046AbfGSRXm (ORCPT ); Fri, 19 Jul 2019 13:23:42 -0400 Received: from mga07.intel.com ([134.134.136.100]:32702 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728351AbfGSRXl (ORCPT ); Fri, 19 Jul 2019 13:23:41 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2019 10:23:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,283,1559545200"; d="scan'208";a="196010773" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga002.fm.intel.com with SMTP; 19 Jul 2019 10:23:36 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 19 Jul 2019 20:23:35 +0300 Date: Fri, 19 Jul 2019 20:23:35 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: YueHaibing Cc: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch, imre.deak@intel.com, madhav.chauhan@intel.com, vandita.kulkarni@intel.com, chris@chris-wilson.co.uk, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot Subject: Re: [PATCH -next] drm/i915/dsi: remove set but not used variable 'hfront_porch' Message-ID: <20190719172335.GT5942@intel.com> References: <20190719015136.103988-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190719015136.103988-1-yuehaibing@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 19, 2019 at 01:51:36AM +0000, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/i915/display/icl_dsi.c: In function 'gen11_dsi_set_transcoder_timings': > drivers/gpu/drm/i915/display/icl_dsi.c:768:6: warning: > variable 'hfront_porch' set but not used [-Wunused-but-set-variable] > > It is never used and can be removed. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Thanks. Applied to drm-intel-next-queued. > --- > drivers/gpu/drm/i915/display/icl_dsi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c > index 4d952accfaaa..a42348be0438 100644 > --- a/drivers/gpu/drm/i915/display/icl_dsi.c > +++ b/drivers/gpu/drm/i915/display/icl_dsi.c > @@ -763,7 +763,7 @@ gen11_dsi_set_transcoder_timings(struct intel_encoder *encoder, > enum transcoder dsi_trans; > /* horizontal timings */ > u16 htotal, hactive, hsync_start, hsync_end, hsync_size; > - u16 hfront_porch, hback_porch; > + u16 hback_porch; > /* vertical timings */ > u16 vtotal, vactive, vsync_start, vsync_end, vsync_shift; > > @@ -772,8 +772,6 @@ gen11_dsi_set_transcoder_timings(struct intel_encoder *encoder, > hsync_start = adjusted_mode->crtc_hsync_start; > hsync_end = adjusted_mode->crtc_hsync_end; > hsync_size = hsync_end - hsync_start; > - hfront_porch = (adjusted_mode->crtc_hsync_start - > - adjusted_mode->crtc_hdisplay); > hback_porch = (adjusted_mode->crtc_htotal - > adjusted_mode->crtc_hsync_end); > vactive = adjusted_mode->crtc_vdisplay; > > -- Ville Syrjälä Intel