From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Quentin Perret <quentin.perret@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Morten Rasmussen <Morten.Rasmussen@arm.com>,
Phil Auld <pauld@redhat.com>
Subject: Re: [PATCH 3/5] sched/fair: rework load_balance
Date: Sat, 20 Jul 2019 13:31:23 +0200 [thread overview]
Message-ID: <20190720113123.GS3402@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAKfTPtBrogvg8Km1O9QOh=hoLM8g5Oc8gUKRoMmHpM54nueijw@mail.gmail.com>
On Fri, Jul 19, 2019 at 04:02:15PM +0200, Vincent Guittot wrote:
> On Fri, 19 Jul 2019 at 14:54, Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > On Fri, Jul 19, 2019 at 09:58:23AM +0200, Vincent Guittot wrote:
> > > -void fix_small_imbalance(struct lb_env *env, struct sd_lb_stats *sds)
> > Maybe strip this out first, in a separate patch. It's all magic doo-doo.
>
> If I remove that 1st, we will have commit in the branch that might
> regress some performance temporarily and bisect might spot it while
> looking for a culprit, isn't it ?
Maybe; but at least for review it is much better to not have it all
squashed in one patch.
next prev parent reply other threads:[~2019-07-20 11:31 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 7:58 [PATCH 0/5] sched/fair: rework the CFS load balance Vincent Guittot
2019-07-19 7:58 ` [PATCH 1/5] sched/fair: clean up asym packing Vincent Guittot
2019-07-19 7:58 ` [PATCH 2/5] sched/fair: rename sum_nr_running to sum_h_nr_running Vincent Guittot
2019-07-19 12:51 ` Peter Zijlstra
2019-07-19 13:44 ` Vincent Guittot
2019-07-26 2:17 ` Srikar Dronamraju
2019-07-26 8:41 ` Vincent Guittot
2019-07-19 7:58 ` [PATCH 3/5] sched/fair: rework load_balance Vincent Guittot
2019-07-19 12:52 ` Peter Zijlstra
2019-07-19 13:46 ` Vincent Guittot
2019-07-19 12:54 ` Peter Zijlstra
2019-07-19 14:02 ` Vincent Guittot
2019-07-20 11:31 ` Peter Zijlstra [this message]
2019-07-19 13:06 ` Peter Zijlstra
2019-07-19 13:57 ` Vincent Guittot
2019-07-19 13:12 ` Peter Zijlstra
2019-07-19 14:13 ` Vincent Guittot
2019-07-19 13:22 ` Peter Zijlstra
2019-07-19 13:55 ` Vincent Guittot
2019-07-25 17:17 ` Valentin Schneider
2019-07-26 9:01 ` Vincent Guittot
2019-07-26 10:41 ` Valentin Schneider
2019-07-26 12:30 ` Vincent Guittot
2019-07-26 14:01 ` Valentin Schneider
2019-07-26 14:47 ` Vincent Guittot
2019-07-29 14:28 ` Valentin Schneider
2019-07-26 13:58 ` Srikar Dronamraju
2019-07-26 14:09 ` Valentin Schneider
2019-07-26 14:42 ` Vincent Guittot
2019-07-31 13:43 ` Srikar Dronamraju
2019-07-31 15:37 ` Vincent Guittot
2019-07-19 7:58 ` [PATCH 4/5] sched/fair: use load instead of runnable load Vincent Guittot
2019-07-19 7:58 ` [PATCH 5/5] sched/fair: evenly spread tasks when not overloaded Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190720113123.GS3402@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Morten.Rasmussen@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=quentin.perret@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.