From: Sergei Trofimovich <slyfox@gentoo.org>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
libc-alpha@sourceware.org
Cc: Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
mtk.manpages@gmail.com, linux-man@vger.kernel.org
Subject: linux-headers-5.2 and proper use of SIOCGSTAMP
Date: Sat, 20 Jul 2019 17:48:44 +0100 [thread overview]
Message-ID: <20190720174844.4b989d34@sf> (raw)
Commit https://github.com/torvalds/linux/commit/0768e17073dc527ccd18ed5f96ce85f9985e9115
("net: socket: implement 64-bit timestamps") caused a bit of userspace breakage
for existing programs:
- firefox: https://bugs.gentoo.org/689808
- qemu: https://lists.sr.ht/~philmd/qemu/%3C20190604071915.288045-1-borntraeger%40de.ibm.com%3E
- linux-atm: https://gitweb.gentoo.org/repo/gentoo.git/tree/net-dialup/linux-atm/files/linux-atm-2.5.2-linux-5.2-SIOCGSTAMP.patch?id=408621819a85bf67a73efd33a06ea371c20ea5a2
I have a question: how a well-behaved app should include 'SIOCGSTAMP'
definition to keep being buildable against old and new linux-headers?
'man 7 socket' explicitly mentions SIOCGSTAMP and mentions only
#include <sys/socket.h>
as needed header.
Should #include <linux/sockios.h> always be included by user app?
Or should glibc tweak it's definition of '#include <sys/socket.h>'
to make it available on both old and new version of linux headers?
CCing both kernel and glibc folk as I don't understand on which
side issue should be fixed.
Thanks!
--
Sergei
next reply other threads:[~2019-07-20 16:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-20 16:48 Sergei Trofimovich [this message]
2019-07-20 18:10 ` linux-headers-5.2 and proper use of SIOCGSTAMP Florian Weimer
2019-07-20 18:50 ` Arnd Bergmann
2019-07-20 19:34 ` Florian Weimer
2019-07-20 20:40 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190720174844.4b989d34@sf \
--to=slyfox@gentoo.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=libc-alpha@sourceware.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.