From: Sam Ravnborg <sam@ravnborg.org>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: david@lechnology.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/6] drm/tinydrm: Move mipi_dbi
Date: Sat, 20 Jul 2019 22:29:08 +0200 [thread overview]
Message-ID: <20190720202908.GA23794@ravnborg.org> (raw)
In-Reply-To: <20190720134709.15186-1-noralf@tronnes.org>
Hi Noralf.
Good to see a long journey end with a very nice result.
I only entered the DRM world for the last parts of the journey,
but nevertheless impressed by all the nice refactoring done.
On Sat, Jul 20, 2019 at 03:47:03PM +0200, Noralf Trønnes wrote:
> This series ticks off the last tinydrm todo entry and moves out mipi_dbi
> to be a core helper.
>
> It splits struct mipi_dbi into an interface part and a display pipeline
> part (upload framebuffer over SPI). I also took the opportunity to
> rename the ambiguous 'mipi' variable name to 'dbi'. This lines up with
> the use of the 'dsi' variable name in the MIPI DSI helper.
>
> Note:
> This depends on series: drm/tinydrm: Remove tinydrm.ko
>
> Series is also available here:
> https://github.com/notro/linux/tree/move_mipi_dbi
>
> Noralf.
>
> Noralf Trønnes (6):
> drm/tinydrm/mipi-dbi: Move cmdlock mutex init
> drm/tinydrm: Rename variable mipi -> dbi
> drm/tinydrm: Rename remaining variable mipi -> dbidev
> drm/tinydrm: Split struct mipi_dbi in two
> drm/tinydrm: Move mipi-dbi
> MAINTAINERS: Remove tinydrm entry
I have read all patches - looks good.
In "Split struct mipi_dbi in two" the documentation for the struct
members is moved inside the struct - this makes it more readbale and is
good.
This could have been an independent patch, or at least mentioned in the
changelog.
You can for all patches add:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-07-20 20:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-20 13:47 [PATCH 0/6] drm/tinydrm: Move mipi_dbi Noralf Trønnes
2019-07-20 13:47 ` [PATCH 1/6] drm/tinydrm/mipi-dbi: Move cmdlock mutex init Noralf Trønnes
2019-07-20 13:47 ` [PATCH 2/6] drm/tinydrm: Rename variable mipi -> dbi Noralf Trønnes
2019-07-20 13:47 ` [PATCH 3/6] drm/tinydrm: Rename remaining variable mipi -> dbidev Noralf Trønnes
2019-07-20 13:47 ` [PATCH 4/6] drm/tinydrm: Split struct mipi_dbi in two Noralf Trønnes
2019-07-20 13:47 ` [PATCH 5/6] drm/tinydrm: Move mipi-dbi Noralf Trønnes
2019-07-20 13:47 ` [PATCH 6/6] MAINTAINERS: Remove tinydrm entry Noralf Trønnes
2019-07-20 20:29 ` Sam Ravnborg [this message]
2019-07-21 16:41 ` [PATCH 0/6] drm/tinydrm: Move mipi_dbi Noralf Trønnes
2019-07-22 18:06 ` Eric Anholt
2019-07-22 19:00 ` Noralf Trønnes
[not found] ` <20190723071037.GS15868@phenom.ffwll.local>
2019-07-23 13:41 ` Noralf Trønnes
2019-07-24 11:41 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190720202908.GA23794@ravnborg.org \
--to=sam@ravnborg.org \
--cc=david@lechnology.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=noralf@tronnes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.