Re: [Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi. - Marek Marczykowski-Górecki

From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: Julien Grall <julien.grall@arm.com>
Cc: "Kevin Tian" <kevin.tian@intel.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
	"Wei Liu" <wl@xen.org>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	"George Dunlap" <George.Dunlap@eu.citrix.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Ian Jackson" <ian.jackson@eu.citrix.com>,
	"Tim Deegan" <tim@xen.org>,
	"Simon Gaiser" <simon@invisiblethingslab.com>,
	"Jan Beulich" <jbeulich@suse.com>,
	xen-devel@lists.xenproject.org,
	"Brian Woods" <brian.woods@amd.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v5 4/6] xen/x86: Allow stubdom access to irq created for msi.
Date: Sat, 20 Jul 2019 23:21:02 +0200	[thread overview]
Message-ID: <20190720212102.GC1250@mail-itl> (raw)
In-Reply-To: <49a30043-1dd1-0069-1e3b-c593542f425c@arm.com>

[-- Attachment #1.1: Type: text/plain, Size: 1172 bytes --]

On Sat, Jul 20, 2019 at 05:48:56PM +0100, Julien Grall wrote:
> Hi,
> 
> Sorry for jumping late in the discussion.
> 
> On 7/17/19 2:00 AM, Marek Marczykowski-Górecki wrote:
> > diff --git a/xen/include/xen/irq.h b/xen/include/xen/irq.h
> > index 586b783..c7a6a83 100644
> > --- a/xen/include/xen/irq.h
> > +++ b/xen/include/xen/irq.h
> > @@ -91,6 +91,7 @@ typedef struct irq_desc {
> >       spinlock_t lock;
> >       struct arch_irq_desc arch;
> >       cpumask_var_t affinity;
> > +    domid_t creator_domid; /* weak reference to domain handling this IRQ */
> 
> This x86 only. Can this be moved in arch_irq_desc to avoid increasing the
> structure on Arm?

How (if at all) PCI passthrough is supported on ARM? Is qemu involved?
If so, and if that qemu would be isolated in stubdomain, I think ARM
would need a similar feature. If it not the case right now, but it is
planned, do you think it's worth moving it to arch_irq_desc and possibly
move back later?

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel