From: Phil Sutter <phil@nwl.cc>
To: Fernando Fernandez Mancera <ffmancera@riseup.net>
Cc: netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH nft] src: osf: fix snprintf -Wformat-truncation warning
Date: Sun, 21 Jul 2019 12:43:09 +0200 [thread overview]
Message-ID: <20190721104309.GD22661@orbyte.nwl.cc> (raw)
In-Reply-To: <00a4ebbb-a571-b00a-83ac-ad198ccbd263@riseup.net>
Hi,
On Sun, Jul 21, 2019 at 11:59:14AM +0200, Fernando Fernandez Mancera wrote:
[...]
> I think your code is more readable than mine. I am going to send a v2
> patch with your code but also adding the following fix.
>
> - while (tmp && tmp + 1 && isspace(*(tmp + 1)))
> + while (tmp && isspace(*(tmp + 1)))
>
> I am going to send a similar patch for the iptables tree because this
> file was imported from iptables.git/utils/nfnl_osf.c.
Sounds great, thanks a lot!
Cheers, Phil
prev parent reply other threads:[~2019-07-21 10:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 11:01 [PATCH nft] src: osf: fix snprintf -Wformat-truncation warning Fernando Fernandez Mancera
2019-07-20 20:21 ` Phil Sutter
2019-07-21 9:59 ` Fernando Fernandez Mancera
2019-07-21 10:43 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190721104309.GD22661@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=ffmancera@riseup.net \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.