From: Christoph Hellwig <hch@lst.de>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Minwoo Im <minwoo.im.dev@gmail.com>,
MSM <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
Rob Clark <robdclark@gmail.com>, Stephen Boyd <sboyd@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] firmware: qcom_scm: fix error for incompatible pointer
Date: Mon, 22 Jul 2019 11:30:59 +0200 [thread overview]
Message-ID: <20190722093059.GA29538@lst.de> (raw)
In-Reply-To: <7ea51e42-ab8a-e4e2-1833-651e2dabca3c@free.fr>
On Mon, Jul 22, 2019 at 10:38:55AM +0200, Marc Gonzalez wrote:
> > In file included from drivers/firmware/qcom_scm.c:12:0:
> > ./include/linux/dma-mapping.h:636:21: note: expected ‘dma_addr_t * {aka long long unsigned int *}’ but argument is of type ‘phys_addr_t * {aka unsigned int *}’
> > static inline void *dma_alloc_coherent(struct device *dev, size_t size,
> > ^~~~~~~~~~~~~~~~~~
> > ```
> >
> > We just can cast phys_addr_t to dma_addr_t here.
>
> IME, casting is rarely a proper solution.
*nod*
ptr_phys probably should be a dma_addr_t. Unless this driver is so
magic that it really wants a physical and not a dma address, in which
case it needs to use alloc_pages instead of dma_alloc_coherent
and then call page_to_phys on the returned page, and a very big comment
explaining why it is so special.
next prev parent reply other threads:[~2019-07-22 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 13:43 [PATCH] firmware: qcom_scm: fix error for incompatible pointer Minwoo Im
2019-07-22 8:38 ` Marc Gonzalez
2019-07-22 9:30 ` Christoph Hellwig [this message]
2019-07-22 15:12 ` Bjorn Andersson
2019-07-23 13:28 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722093059.GA29538@lst.de \
--to=hch@lst.de \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=minwoo.im.dev@gmail.com \
--cc=robdclark@gmail.com \
--cc=sboyd@kernel.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.