diff for duplicates of <20190722134108.22151-3-david@redhat.com> diff --git a/a/1.txt b/N1/1.txt index d0863ae..5b60dd8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,3 +1,5 @@ +From: David Hildenbrand <david@redhat.com> + We are using the wrong functions to set/clear bits, effectively touching multiple bits, writing out of range of the bitmap, resulting in memory corruptions. We have to use set_bit()/clear_bit() instead. @@ -12,13 +14,14 @@ to discard a page - the guest just frees the 4k sub-pages in random order most of the time. I was only able to discard a hugepage a handful of times - so I hope that now works correctly. -Fixes: ed48c59875b6 ("virtio-balloon: Safely handle BALLOON_PAGE_SIZE < - host page size") -Fixes: b27b32391404 ("virtio-balloon: Fix possible guest memory corruption - with inflates & deflates") +Fixes: ed48c59875b6 ("virtio-balloon: Safely handle BALLOON_PAGE_SIZE < host page size") +Fixes: b27b32391404 ("virtio-balloon: Fix possible guest memory corruption with inflates & deflates") Cc: qemu-stable@nongnu.org #v4.0.0 Acked-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: David Hildenbrand <david@redhat.com> +Message-Id: <20190722134108.22151-3-david@redhat.com> +Reviewed-by: Michael S. Tsirkin <mst@redhat.com> +Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- hw/virtio/virtio-balloon.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) @@ -52,4 +55,4 @@ index 515abf6553..a78d2d2184 100644 if (bitmap_empty(balloon->pbp->bitmap, subpages)) { g_free(balloon->pbp); -- -2.21.0 +MST diff --git a/a/content_digest b/N1/content_digest index c315f43..3a48c93 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,16 +1,16 @@ - "ref\020190722134108.22151-1-david@redhat.com\0" - "From\0David Hildenbrand <david@redhat.com>\0" - "Subject\0[Qemu-devel] [PATCH-for-4.1 v3 2/6] virtio-balloon: Fix QEMU crashes on pagesize > BALLOON_PAGE_SIZE\0" - "Date\0Mon, 22 Jul 2019 15:41:04 +0200\0" + "ref\020190725153059.7313-1-mst@redhat.com\0" + "From\0Michael S. Tsirkin <mst@redhat.com>\0" + "Subject\0[Qemu-devel] [PULL 06/12] virtio-balloon: Fix QEMU crashes on pagesize > BALLOON_PAGE_SIZE\0" + "Date\0Thu, 25 Jul 2019 11:31:55 -0400\0" "To\0qemu-devel@nongnu.org\0" - "Cc\0Michael S . Tsirkin <mst@redhat.com>" - David Hildenbrand <david@redhat.com> + "Cc\0Peter Maydell <peter.maydell@linaro.org>" + David Gibson <david@gibson.dropbear.id.au> qemu-stable@nongnu.org - Stefan Hajnoczi <stefanha@redhat.com> - Igor Mammedov <imammedo@redhat.com> - " David Gibson <david@gibson.dropbear.id.au>\0" + " David Hildenbrand <david@redhat.com>\0" "\00:1\0" "b\0" + "From: David Hildenbrand <david@redhat.com>\n" + "\n" "We are using the wrong functions to set/clear bits, effectively touching\n" "multiple bits, writing out of range of the bitmap, resulting in memory\n" "corruptions. We have to use set_bit()/clear_bit() instead.\n" @@ -25,13 +25,14 @@ "most of the time. I was only able to discard a hugepage a handful of\n" "times - so I hope that now works correctly.\n" "\n" - "Fixes: ed48c59875b6 (\"virtio-balloon: Safely handle BALLOON_PAGE_SIZE <\n" - " host page size\")\n" - "Fixes: b27b32391404 (\"virtio-balloon: Fix possible guest memory corruption\n" - " with inflates & deflates\")\n" + "Fixes: ed48c59875b6 (\"virtio-balloon: Safely handle BALLOON_PAGE_SIZE < host page size\")\n" + "Fixes: b27b32391404 (\"virtio-balloon: Fix possible guest memory corruption with inflates & deflates\")\n" "Cc: qemu-stable@nongnu.org #v4.0.0\n" "Acked-by: David Gibson <david@gibson.dropbear.id.au>\n" "Signed-off-by: David Hildenbrand <david@redhat.com>\n" + "Message-Id: <20190722134108.22151-3-david@redhat.com>\n" + "Reviewed-by: Michael S. Tsirkin <mst@redhat.com>\n" + "Signed-off-by: Michael S. Tsirkin <mst@redhat.com>\n" "---\n" " hw/virtio/virtio-balloon.c | 10 ++++------\n" " 1 file changed, 4 insertions(+), 6 deletions(-)\n" @@ -65,6 +66,6 @@ " if (bitmap_empty(balloon->pbp->bitmap, subpages)) {\n" " g_free(balloon->pbp);\n" "-- \n" - 2.21.0 + MST -48eab63892e5fde07ccb3ab64dfdf2b1e4621b610561206f3f8d5d1b57ee40f2 +5da2808828a5f154c51c8626fa942015567f343aa4bf2ca3c0a56f7d0a2ddde7
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.