From: Bjorn Helgaas <helgaas@kernel.org>
To: "Chocron, Jonathan" <jonnyc@amazon.com>
Cc: "jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"Gustavo.Pimentel@synopsys.com" <Gustavo.Pimentel@synopsys.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"Hanoch, Uri" <hanochu@amazon.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Wasserstrom, Barak" <barakw@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Hawa, Hanna" <hhhawa@amazon.com>,
"Shenhar, Talel" <talel@amazon.com>,
"Krupnik, Ronen" <ronenk@amazon.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>
Subject: Re: [PATCH v2 6/8] PCI: al: Add support for DW based driver type
Date: Mon, 22 Jul 2019 16:15:42 -0500 [thread overview]
Message-ID: <20190722211542.GB203187@google.com> (raw)
In-Reply-To: <d323007c6bf14cb9f90a497a26b66dac151164fc.camel@amazon.com>
On Sun, Jul 21, 2019 at 03:08:18PM +0000, Chocron, Jonathan wrote:
> On Fri, 2019-07-19 at 08:55 +0000, Gustavo Pimentel wrote:
> > On Thu, Jul 18, 2019 at 10:47:16, Jonathan Chocron <jonnyc@amazon.com> wrote:
> > > +static int al_pcie_probe(struct platform_device *pdev)
> > > +{
> > > + struct device *dev = &pdev->dev;
> > > + struct al_pcie *al_pcie;
> > > + struct dw_pcie *pci;
> > > + struct resource *dbi_res;
> > > + struct resource *controller_res;
> > > + struct resource *ecam_res;
> > > + int ret;
> >
> > Please sort the variables following the reverse tree order.
> >
> Done.
>
> I'd think that it would make sense to group variables which have a
> common characteristic (e.g. resources read from the DT), even if it
> mildly breaks the convention (as long as the general frame is longest
> to shortest). Does this sound ok?
>
> BTW, I couldn't find any documentation regarding the reverse-tree
> convention, do you have a pointer to some?
What I personally do is sort declarations in the order they're used.
next prev parent reply other threads:[~2019-07-22 21:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 9:45 [PATCH v2 0/8] Amazon's Annapurna Labs DT-based PCIe host controller driver Jonathan Chocron
2019-07-18 9:45 ` Jonathan Chocron
2019-07-18 9:45 ` [PATCH v2 1/8] PCI: Add Amazon's Annapurna Labs vendor ID Jonathan Chocron
2019-07-18 9:45 ` Jonathan Chocron
2019-07-18 9:45 ` [PATCH v2 2/8] PCI: Add ACS quirk for Amazon Annapurna Labs root ports Jonathan Chocron
2019-07-18 9:45 ` Jonathan Chocron
2019-07-19 8:25 ` Gustavo Pimentel
2019-07-18 9:45 ` [PATCH v2 3/8] PCI/VPD: Add VPD release quirk for Amazon's Annapurna Labs Root Port Jonathan Chocron
2019-07-18 9:45 ` Jonathan Chocron
2019-07-19 8:24 ` Gustavo Pimentel
2019-07-18 9:45 ` [PATCH v2 4/8] PCI: Add quirk to disable MSI-X support " Jonathan Chocron
2019-07-18 9:45 ` Jonathan Chocron
2019-07-19 9:17 ` Gustavo Pimentel
2019-07-18 9:47 ` [PATCH v2 5/8] dt-bindings: PCI: Add Amazon's Annapurna Labs PCIe host bridge binding Jonathan Chocron
2019-07-18 9:47 ` Jonathan Chocron
2019-07-18 9:47 ` [PATCH v2 6/8] PCI: al: Add support for DW based driver type Jonathan Chocron
2019-07-18 9:47 ` Jonathan Chocron
2019-07-19 8:55 ` Gustavo Pimentel
2019-07-19 8:55 ` Gustavo Pimentel
2019-07-21 15:08 ` Chocron, Jonathan
2019-07-22 0:47 ` Benjamin Herrenschmidt
2019-07-22 8:54 ` Gustavo Pimentel
2019-07-22 15:38 ` Chocron, Jonathan
2019-07-22 21:15 ` Bjorn Helgaas [this message]
2019-07-18 9:47 ` [PATCH v2 7/8] PCI: dw: Add validation that PCIe core is set to correct mode Jonathan Chocron
2019-07-18 9:47 ` Jonathan Chocron
2019-07-19 9:15 ` Gustavo Pimentel
2019-07-18 9:47 ` [PATCH v2 8/8] PCI: dw: Add support for PCI_PROBE_ONLY/PCI_REASSIGN_ALL_BUS flags Jonathan Chocron
2019-07-18 9:47 ` Jonathan Chocron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722211542.GB203187@google.com \
--to=helgaas@kernel.org \
--cc=Gustavo.Pimentel@synopsys.com \
--cc=alisaidi@amazon.com \
--cc=barakw@amazon.com \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=jingoohan1@gmail.com \
--cc=jonnyc@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.