From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Date: Mon, 22 Jul 2019 21:53:13 +0000 Subject: Re: [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den Message-Id: <20190722215314.9F4F121951@mail.kernel.org> List-Id: References: <20190701165020.19840-1-colin.king@canonical.com> <20190722212414.6EF8D21900@mail.kernel.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Christophe JAILLET , Colin King , linux-clk@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Quoting Christophe JAILLET (2019-07-22 14:43:32) > Le 22/07/2019 à 23:24, Stephen Boyd a écrit : > > Please Cc authors of drivers so they can ack/review. > > > > Adding Mike to take a look. > > > > Quoting Colin King (2019-07-01 09:50:20) > >> From: Colin Ian King > >> > >> The variable n_den is initialized however that value is never read > >> as n_den is re-assigned a little later in the two paths of a > >> following if-statement. Remove the redundant assignment. > >> > >> Addresses-Coverity: ("Unused value") > >> Signed-off-by: Colin Ian King > >> --- > >> drivers/clk/clk-si5341.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c > >> index 72424eb7e5f8..6e780c2a9e6b 100644 > >> --- a/drivers/clk/clk-si5341.c > >> +++ b/drivers/clk/clk-si5341.c > >> @@ -547,7 +547,6 @@ static int si5341_synth_clk_set_rate(struct clk_hw *hw, unsigned long rate, > >> bool is_integer; > >> > >> n_num = synth->data->freq_vco; > >> - n_den = rate; > >> > >> /* see if there's an integer solution */ > >> r = do_div(n_num, rate); > > > Hi, > > I got the same advise from some else no later than yesterday (i.e. email > the author...) > Maybe 'get_maintainer.pl' could be improved to search for it and propose > the mail automatically? > > just my 2c. > Use --git option of get_maintainer.pl? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DD11C7618F for ; Mon, 22 Jul 2019 21:53:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CA2E21955 for ; Mon, 22 Jul 2019 21:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563832396; bh=N/aG7525RXZijdwbJGyunKRAEhR9IYfXPRMh+ImE0p0=; h=In-Reply-To:References:Subject:To:Cc:From:Date:List-ID:From; b=ddqONTJF/Xy0Mzbnz8wOWQLuTfdilIL36wb9EJcJyUKx/+QWq43edXAnNF7UAtUsb uOWPCe7UEehL8LMvh55EdxVIC6LZaGJ2YxlWuu6J5aqY6CXh6sgQLwlV2C2sI83lmB eFxf/MtudJX8XrpXvXoxteOKaIa2W1Vd2+5rB2Bg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732942AbfGVVxP (ORCPT ); Mon, 22 Jul 2019 17:53:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:44100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730704AbfGVVxP (ORCPT ); Mon, 22 Jul 2019 17:53:15 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9F4F121951; Mon, 22 Jul 2019 21:53:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563832394; bh=N/aG7525RXZijdwbJGyunKRAEhR9IYfXPRMh+ImE0p0=; h=In-Reply-To:References:Subject:To:Cc:From:Date:From; b=0YGM3auUNRWmWMAPu/v1w+jKC4qRGTLk5dziMHVPpoADcDlUxpDe/c2XaUgo82zCS erm45DJexo99LqTONLo/8jZbPJtGKhtEDUCCabdGxcf0EV0XV+Ow4DBTEgRCUyeVLr paPF8H1gVDBzIAzrUqcPSNq6aAuqYEV1iVkn+A7I= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20190701165020.19840-1-colin.king@canonical.com> <20190722212414.6EF8D21900@mail.kernel.org> Subject: Re: [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den To: Christophe JAILLET , Colin King , linux-clk@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Stephen Boyd User-Agent: alot/0.8.1 Date: Mon, 22 Jul 2019 14:53:13 -0700 Message-Id: <20190722215314.9F4F121951@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Christophe JAILLET (2019-07-22 14:43:32) > Le 22/07/2019 =C3=A0 23:24, Stephen Boyd a =C3=A9crit=C2=A0: > > Please Cc authors of drivers so they can ack/review. > > > > Adding Mike to take a look. > > > > Quoting Colin King (2019-07-01 09:50:20) > >> From: Colin Ian King > >> > >> The variable n_den is initialized however that value is never read > >> as n_den is re-assigned a little later in the two paths of a > >> following if-statement. Remove the redundant assignment. > >> > >> Addresses-Coverity: ("Unused value") > >> Signed-off-by: Colin Ian King > >> --- > >> drivers/clk/clk-si5341.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c > >> index 72424eb7e5f8..6e780c2a9e6b 100644 > >> --- a/drivers/clk/clk-si5341.c > >> +++ b/drivers/clk/clk-si5341.c > >> @@ -547,7 +547,6 @@ static int si5341_synth_clk_set_rate(struct clk_hw= *hw, unsigned long rate, > >> bool is_integer; > >> =20 > >> n_num =3D synth->data->freq_vco; > >> - n_den =3D rate; > >> =20 > >> /* see if there's an integer solution */ > >> r =3D do_div(n_num, rate); > > > Hi, >=20 > I got the same advise from some else no later than yesterday (i.e. email = > the author...) > Maybe 'get_maintainer.pl' could be improved to search for it and propose = > the mail automatically? >=20 > just my 2c. >=20 Use --git option of get_maintainer.pl?