From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [Intel-gfx] [PATCH] drm/i915: Mark expected switch fall-throughs Date: Mon, 22 Jul 2019 17:00:44 -0700 Message-ID: <20190723000044.GA29820@intel.com> References: <20190722181244.GA2085@embeddedor> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190722181244.GA2085@embeddedor> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Gustavo A. R. Silva" Cc: Kees Cook , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgR3VzdGF2bywKCmNvdWxkIHlvdSBwbGVhc2UgcmViYXNlIG9uIHRvcCBvZiBkcm0tdGlwIGFu ZCByZXNlbmQgaXQgcGxlYXNlPwoKVGhhbmtzLApSb2RyaWdvLgoKT24gTW9uLCBKdWwgMjIsIDIw MTkgYXQgMDE6MTI6NDRQTSAtMDUwMCwgR3VzdGF2byBBLiBSLiBTaWx2YSB3cm90ZToKPiBJbiBw cmVwYXJhdGlvbiB0byBlbmFibGluZyAtV2ltcGxpY2l0LWZhbGx0aHJvdWdoLCBtYXJrIHN3aXRj aAo+IGNhc2VzIHdoZXJlIHdlIGFyZSBleHBlY3RpbmcgdG8gZmFsbCB0aHJvdWdoLgo+IAo+IFRo aXMgcGF0Y2ggZml4ZXMgdGhlIGZvbGxvd2luZyB3YXJuaW5nczoKPiAKPiBkcml2ZXJzL2dwdS9k cm0vaTkxNS9nZW0vaTkxNV9nZW1fbW1hbi5jOiBJbiBmdW5jdGlvbiDigJhpOTE1X2dlbV9mYXVs dOKAmToKPiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9nZW0vaTkxNV9nZW1fbW1hbi5jOjM0Mjo2OiB3 YXJuaW5nOiB0aGlzIHN0YXRlbWVudCBtYXkgZmFsbCB0aHJvdWdoIFstV2ltcGxpY2l0LWZhbGx0 aHJvdWdoPV0KPiAgICBpZiAoIWk5MTVfdGVybWluYWxseV93ZWRnZWQoaTkxNSkpCj4gICAgICAg Xgo+IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2dlbS9pOTE1X2dlbV9tbWFuLmM6MzQ1OjI6IG5vdGU6 IGhlcmUKPiAgIGNhc2UgLUVBR0FJTjoKPiAgIF5+fn4KPiAKPiBkcml2ZXJzL2dwdS9kcm0vaTkx NS9nZW0vaTkxNV9nZW1fcGFnZXMuYzogSW4gZnVuY3Rpb24g4oCYaTkxNV9nZW1fb2JqZWN0X21h cOKAmToKPiAuL2luY2x1ZGUvbGludXgvY29tcGlsZXIuaDo3ODoyMjogd2FybmluZzogdGhpcyBz dGF0ZW1lbnQgbWF5IGZhbGwgdGhyb3VnaCBbLVdpbXBsaWNpdC1mYWxsdGhyb3VnaD1dCj4gICMg ZGVmaW5lIHVubGlrZWx5KHgpIF9fYnVpbHRpbl9leHBlY3QoISEoeCksIDApCj4gICAgICAgICAg ICAgICAgICAgICAgIF5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+Cj4gLi9pbmNsdWRlL2FzbS1n ZW5lcmljL2J1Zy5oOjEzNjoyOiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCYdW5saWtl bHnigJkKPiAgIHVubGlrZWx5KF9fcmV0X3dhcm5fb24pOyAgICAgXAo+ICAgXn5+fn5+fn4KPiBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3V0aWxzLmg6NDk6MjU6IG5vdGU6IGluIGV4cGFuc2lv biBvZiBtYWNybyDigJhXQVJO4oCZCj4gICNkZWZpbmUgTUlTU0lOR19DQVNFKHgpIFdBUk4oMSwg Ik1pc3NpbmcgY2FzZSAoJXMgPT0gJWxkKVxuIiwgXAo+ICAgICAgICAgICAgICAgICAgICAgICAg ICBefn5+Cj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvZ2VtL2k5MTVfZ2VtX3BhZ2VzLmM6MjcwOjM6 IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyDigJhNSVNTSU5HX0NBU0XigJkKPiAgICBNSVNT SU5HX0NBU0UodHlwZSk7Cj4gICAgXn5+fn5+fn5+fn5+Cj4gZHJpdmVycy9ncHUvZHJtL2k5MTUv Z2VtL2k5MTVfZ2VtX3BhZ2VzLmM6MjcyOjI6IG5vdGU6IGhlcmUKPiAgIGNhc2UgSTkxNV9NQVBf V0I6Cj4gICBefn5+Cj4gCj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3IuYzog SW4gZnVuY3Rpb24g4oCYZXJyb3JfcmVjb3JkX2VuZ2luZV9yZWdpc3RlcnPigJk6Cj4gLi9pbmNs dWRlL2xpbnV4L2NvbXBpbGVyLmg6Nzg6MjI6IHdhcm5pbmc6IHRoaXMgc3RhdGVtZW50IG1heSBm YWxsIHRocm91Z2ggWy1XaW1wbGljaXQtZmFsbHRocm91Z2g9XQo+ICAjIGRlZmluZSB1bmxpa2Vs eSh4KSBfX2J1aWx0aW5fZXhwZWN0KCEhKHgpLCAwKQo+ICAgICAgICAgICAgICAgICAgICAgICBe fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fgo+IC4vaW5jbHVkZS9hc20tZ2VuZXJpYy9idWcuaDox MzY6Mjogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmHVubGlrZWx54oCZCj4gICB1bmxp a2VseShfX3JldF93YXJuX29uKTsgICAgIFwKPiAgIF5+fn5+fn5+Cj4gZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV91dGlscy5oOjQ5OjI1OiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCY V0FSTuKAmQo+ICAjZGVmaW5lIE1JU1NJTkdfQ0FTRSh4KSBXQVJOKDEsICJNaXNzaW5nIGNhc2Ug KCVzID09ICVsZClcbiIsIFwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fgo+IGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmM6MTE5Njo1OiBub3RlOiBpbiBleHBhbnNp b24gb2YgbWFjcm8g4oCYTUlTU0lOR19DQVNF4oCZCj4gICAgICBNSVNTSU5HX0NBU0UoZW5naW5l LT5pZCk7Cj4gICAgICBefn5+fn5+fn5+fn4KPiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dw dV9lcnJvci5jOjExOTc6NDogbm90ZTogaGVyZQo+ICAgICBjYXNlIFJDUzA6Cj4gICAgIF5+fn4K PiAKPiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RwLmM6IEluIGZ1bmN0aW9u IOKAmGludGVsX2RwX2dldF9maWFfc3VwcG9ydGVkX2xhbmVfY291bnTigJk6Cj4gLi9pbmNsdWRl L2xpbnV4L2NvbXBpbGVyLmg6Nzg6MjI6IHdhcm5pbmc6IHRoaXMgc3RhdGVtZW50IG1heSBmYWxs IHRocm91Z2ggWy1XaW1wbGljaXQtZmFsbHRocm91Z2g9XQo+ICAjIGRlZmluZSB1bmxpa2VseSh4 KSBfX2J1aWx0aW5fZXhwZWN0KCEhKHgpLCAwKQo+ICAgICAgICAgICAgICAgICAgICAgICBefn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fgo+IC4vaW5jbHVkZS9hc20tZ2VuZXJpYy9idWcuaDoxMzY6 Mjogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmHVubGlrZWx54oCZCj4gICB1bmxpa2Vs eShfX3JldF93YXJuX29uKTsgICAgIFwKPiAgIF5+fn5+fn5+Cj4gZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV91dGlscy5oOjQ5OjI1OiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCYV0FS TuKAmQo+ICAjZGVmaW5lIE1JU1NJTkdfQ0FTRSh4KSBXQVJOKDEsICJNaXNzaW5nIGNhc2UgKCVz ID09ICVsZClcbiIsIFwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fgo+IGRyaXZlcnMv Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHAuYzoyMzM6Mzogbm90ZTogaW4gZXhwYW5zaW9u IG9mIG1hY3JvIOKAmE1JU1NJTkdfQ0FTReKAmQo+ICAgIE1JU1NJTkdfQ0FTRShsYW5lX2luZm8p Owo+ICAgIF5+fn5+fn5+fn5+fgo+IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf ZHAuYzoyMzQ6Mjogbm90ZTogaGVyZQo+ICAgY2FzZSAxOgo+ICAgXn5+fgo+IAo+IGRyaXZlcnMv Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jOiBJbiBmdW5jdGlvbiDigJhjaGVj a19kaWdpdGFsX3BvcnRfY29uZmxpY3Rz4oCZOgo+ICAgQ0MgW01dICBkcml2ZXJzL2dwdS9kcm0v bm91dmVhdS9udmttL2VuZ2luZS9kaXNwL2N1cnNndjEwMC5vCj4gZHJpdmVycy9ncHUvZHJtL2k5 MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmM6MTIwNDM6Nzogd2FybmluZzogdGhpcyBzdGF0ZW1l bnQgbWF5IGZhbGwgdGhyb3VnaCBbLVdpbXBsaWNpdC1mYWxsdGhyb3VnaD1dCj4gICAgIGlmIChX QVJOX09OKCFIQVNfRERJKHRvX2k5MTUoZGV2KSkpKQo+ICAgICAgICBeCj4gZHJpdmVycy9ncHUv ZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmM6MTIwNDY6Mzogbm90ZTogaGVyZQo+ICAg IGNhc2UgSU5URUxfT1VUUFVUX0RQOgo+ICAgIF5+fn4KPiAKPiBBbHNvLCBub3RpY2UgdGhhdCB0 aGUgTWFrZWZpbGUgaXMgbW9kaWZpZWQgaW4gb3JkZXIgdG8gc3RvcAo+IGlnbm9yaW5nIGZhbGwt dGhyb3VnaCB3YXJuaW5ncy4gVGhlIC1XaW1wbGljaXQtZmFsbHRocm91Z2gKPiBvcHRpb24gd2ls bCBiZSBlbmFibGVkIGdsb2JhbGx5IGluIHY1LjMuCj4gCj4gV2FybmluZyBsZXZlbCAzIHdhcyB1 c2VkOiAtV2ltcGxpY2l0LWZhbGx0aHJvdWdoPTMKPiAKPiBUaGlzIHBhdGNoIGlzIHBhcnQgb2Yg dGhlIG9uZ29pbmcgZWZmb3J0cyB0byBlbmFibGUKPiAtV2ltcGxpY2l0LWZhbGx0aHJvdWdoLgo+ IAo+IFNpZ25lZC1vZmYtYnk6IEd1c3Rhdm8gQS4gUi4gU2lsdmEgPGd1c3Rhdm9AZW1iZWRkZWRv ci5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L01ha2VmaWxlICAgICAgICAgICAg ICAgIHwgMSAtCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5j IHwgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RwLmMgICAgICB8 IDEgKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9nZW0vaTkxNV9nZW1fbW1hbi5jICAgICB8IDIg Ky0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZ2VtL2k5MTVfZ2VtX3BhZ2VzLmMgICAgfCAyICst Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmMgICAgICAgIHwgMSArCj4g IDYgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9NYWtlZmlsZSBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L01ha2VmaWxlCj4gaW5kZXggOTEzNTVjMmVhOGE1Li44Y2FjZTY1ZjUwY2UgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvTWFrZWZpbGUKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9NYWtlZmlsZQo+IEBAIC0xNiw3ICsxNiw2IEBAIHN1YmRpci1jY2ZsYWdzLXkg Oj0gLVdhbGwgLVdleHRyYQo+ICBzdWJkaXItY2NmbGFncy15ICs9ICQoY2FsbCBjYy1kaXNhYmxl LXdhcm5pbmcsIHVudXNlZC1wYXJhbWV0ZXIpCj4gIHN1YmRpci1jY2ZsYWdzLXkgKz0gJChjYWxs IGNjLWRpc2FibGUtd2FybmluZywgdHlwZS1saW1pdHMpCj4gIHN1YmRpci1jY2ZsYWdzLXkgKz0g JChjYWxsIGNjLWRpc2FibGUtd2FybmluZywgbWlzc2luZy1maWVsZC1pbml0aWFsaXplcnMpCj4g LXN1YmRpci1jY2ZsYWdzLXkgKz0gJChjYWxsIGNjLWRpc2FibGUtd2FybmluZywgaW1wbGljaXQt ZmFsbHRocm91Z2gpCj4gIHN1YmRpci1jY2ZsYWdzLXkgKz0gJChjYWxsIGNjLWRpc2FibGUtd2Fy bmluZywgdW51c2VkLWJ1dC1zZXQtdmFyaWFibGUpCj4gICMgY2xhbmcgd2FybmluZ3MKPiAgc3Vi ZGlyLWNjZmxhZ3MteSArPSAkKGNhbGwgY2MtZGlzYWJsZS13YXJuaW5nLCBzaWduLWNvbXBhcmUp Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxh eS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRl eCA4NTkyYTdkNDIyZGUuLjMwYjk3ZGVkNmZkZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTEyMDQyLDcgKzEyMDQyLDcgQEAgc3Rh dGljIGJvb2wgY2hlY2tfZGlnaXRhbF9wb3J0X2NvbmZsaWN0cyhzdHJ1Y3QgaW50ZWxfYXRvbWlj X3N0YXRlICpzdGF0ZSkKPiAgCQljYXNlIElOVEVMX09VVFBVVF9EREk6Cj4gIAkJCWlmIChXQVJO X09OKCFIQVNfRERJKHRvX2k5MTUoZGV2KSkpKQo+ICAJCQkJYnJlYWs7Cj4gLQkJCS8qIGVsc2U6 IGZhbGwgdGhyb3VnaCAqLwo+ICsJCQkvKiBlbHNlLCBmYWxsIHRocm91Z2ggKi8KPiAgCQljYXNl IElOVEVMX09VVFBVVF9EUDoKPiAgCQljYXNlIElOVEVMX09VVFBVVF9IRE1JOgo+ICAJCWNhc2Ug SU5URUxfT1VUUFVUX0VEUDoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcC5j Cj4gaW5kZXggNDMzNmRmNDZmZTc4Li5kMGZjMzQ4MjY3NzEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvZGlzcGxheS9pbnRlbF9kcC5jCj4gQEAgLTIzMSw2ICsyMzEsNyBAQCBzdGF0aWMgaW50 IGludGVsX2RwX2dldF9maWFfc3VwcG9ydGVkX2xhbmVfY291bnQoc3RydWN0IGludGVsX2RwICpp bnRlbF9kcCkKPiAgCXN3aXRjaCAobGFuZV9pbmZvKSB7Cj4gIAlkZWZhdWx0Ogo+ICAJCU1JU1NJ TkdfQ0FTRShsYW5lX2luZm8pOwo+ICsJCS8qIGZhbGwgdGhyb3VnaCAqLwo+ICAJY2FzZSAxOgo+ ICAJY2FzZSAyOgo+ICAJY2FzZSA0Ogo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9nZW0vaTkxNV9nZW1fbW1hbi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ2VtL2k5MTVfZ2Vt X21tYW4uYwo+IGluZGV4IDM5MTYyMWVlM2NiYi4uMzlhNjYxOTI3ZDhlIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2dlbS9pOTE1X2dlbV9tbWFuLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9nZW0vaTkxNV9nZW1fbW1hbi5jCj4gQEAgLTM0MSw3ICszNDEsNyBAQCB2 bV9mYXVsdF90IGk5MTVfZ2VtX2ZhdWx0KHN0cnVjdCB2bV9mYXVsdCAqdm1mKQo+ICAJCSAqLwo+ ICAJCWlmICghaTkxNV90ZXJtaW5hbGx5X3dlZGdlZChpOTE1KSkKPiAgCQkJcmV0dXJuIFZNX0ZB VUxUX1NJR0JVUzsKPiAtCQkvKiBlbHNlOiBmYWxsIHRocm91Z2ggKi8KPiArCQkvKiBlbHNlLCBm YWxsIHRocm91Z2ggKi8KPiAgCWNhc2UgLUVBR0FJTjoKPiAgCQkvKgo+ICAJCSAqIEVBR0FJTiBt ZWFucyB0aGUgZ3B1IGlzIGh1bmcgYW5kIHdlJ2xsIHdhaXQgZm9yIHRoZSBlcnJvcgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9nZW0vaTkxNV9nZW1fcGFnZXMuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2dlbS9pOTE1X2dlbV9wYWdlcy5jCj4gaW5kZXggYjM2YWQyNjlmNGVh Li42NWViNDMwY2VkYmEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ2VtL2k5 MTVfZ2VtX3BhZ2VzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9nZW0vaTkxNV9nZW1f cGFnZXMuYwo+IEBAIC0yNjgsNyArMjY4LDcgQEAgc3RhdGljIHZvaWQgKmk5MTVfZ2VtX29iamVj dF9tYXAoY29uc3Qgc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAgCXN3aXRjaCAo dHlwZSkgewo+ICAJZGVmYXVsdDoKPiAgCQlNSVNTSU5HX0NBU0UodHlwZSk7Cj4gLQkJLyogZmFs bHRocm91Z2ggdG8gdXNlIFBBR0VfS0VSTkVMIGFueXdheSAqLwo+ICsJCS8qIGZhbGx0aHJvdWdo IC0gdG8gdXNlIFBBR0VfS0VSTkVMIGFueXdheSAqLwo+ICAJY2FzZSBJOTE1X01BUF9XQjoKPiAg CQlwZ3Byb3QgPSBQQUdFX0tFUk5FTDsKPiAgCQlicmVhazsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ3B1X2Vycm9yLmMKPiBpbmRleCBiN2U5ZmRkZWYyNzAuLjQxYTUxMWQ1MjY3ZiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3IuYwo+IEBAIC0xMTk0LDYgKzExOTQsNyBA QCBzdGF0aWMgdm9pZCBlcnJvcl9yZWNvcmRfZW5naW5lX3JlZ2lzdGVycyhzdHJ1Y3QgaTkxNV9n cHVfc3RhdGUgKmVycm9yLAo+ICAJCQlzd2l0Y2ggKGVuZ2luZS0+aWQpIHsKPiAgCQkJZGVmYXVs dDoKPiAgCQkJCU1JU1NJTkdfQ0FTRShlbmdpbmUtPmlkKTsKPiArCQkJCS8qIGZhbGwgdGhyb3Vn aCAqLwo+ICAJCQljYXNlIFJDUzA6Cj4gIAkJCQltbWlvID0gUkVOREVSX0hXU19QR0FfR0VONzsK PiAgCQkJCWJyZWFrOwo+IC0tIAo+IDIuMjIuMAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6BB5C7618F for ; Tue, 23 Jul 2019 00:00:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75A56218BE for ; Tue, 23 Jul 2019 00:00:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387568AbfGWAAL (ORCPT ); Mon, 22 Jul 2019 20:00:11 -0400 Received: from mga05.intel.com ([192.55.52.43]:50651 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730693AbfGWAAK (ORCPT ); Mon, 22 Jul 2019 20:00:10 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jul 2019 17:00:09 -0700 X-IronPort-AV: E=Sophos;i="5.64,296,1559545200"; d="scan'208";a="160027458" Received: from rdvivi-losangeles.jf.intel.com (HELO intel.com) ([10.7.196.65]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jul 2019 17:00:09 -0700 Date: Mon, 22 Jul 2019 17:00:44 -0700 From: Rodrigo Vivi To: "Gustavo A. R. Silva" Cc: Jani Nikula , Joonas Lahtinen , David Airlie , Daniel Vetter , Kees Cook , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Mark expected switch fall-throughs Message-ID: <20190723000044.GA29820@intel.com> References: <20190722181244.GA2085@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190722181244.GA2085@embeddedor> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gustavo, could you please rebase on top of drm-tip and resend it please? Thanks, Rodrigo. On Mon, Jul 22, 2019 at 01:12:44PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/gpu/drm/i915/gem/i915_gem_mman.c: In function ‘i915_gem_fault’: > drivers/gpu/drm/i915/gem/i915_gem_mman.c:342:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (!i915_terminally_wedged(i915)) > ^ > drivers/gpu/drm/i915/gem/i915_gem_mman.c:345:2: note: here > case -EAGAIN: > ^~~~ > > drivers/gpu/drm/i915/gem/i915_gem_pages.c: In function ‘i915_gem_object_map’: > ./include/linux/compiler.h:78:22: warning: this statement may fall through [-Wimplicit-fallthrough=] > # define unlikely(x) __builtin_expect(!!(x), 0) > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > ./include/asm-generic/bug.h:136:2: note: in expansion of macro ‘unlikely’ > unlikely(__ret_warn_on); \ > ^~~~~~~~ > drivers/gpu/drm/i915/i915_utils.h:49:25: note: in expansion of macro ‘WARN’ > #define MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \ > ^~~~ > drivers/gpu/drm/i915/gem/i915_gem_pages.c:270:3: note: in expansion of macro ‘MISSING_CASE’ > MISSING_CASE(type); > ^~~~~~~~~~~~ > drivers/gpu/drm/i915/gem/i915_gem_pages.c:272:2: note: here > case I915_MAP_WB: > ^~~~ > > drivers/gpu/drm/i915/i915_gpu_error.c: In function ‘error_record_engine_registers’: > ./include/linux/compiler.h:78:22: warning: this statement may fall through [-Wimplicit-fallthrough=] > # define unlikely(x) __builtin_expect(!!(x), 0) > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > ./include/asm-generic/bug.h:136:2: note: in expansion of macro ‘unlikely’ > unlikely(__ret_warn_on); \ > ^~~~~~~~ > drivers/gpu/drm/i915/i915_utils.h:49:25: note: in expansion of macro ‘WARN’ > #define MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \ > ^~~~ > drivers/gpu/drm/i915/i915_gpu_error.c:1196:5: note: in expansion of macro ‘MISSING_CASE’ > MISSING_CASE(engine->id); > ^~~~~~~~~~~~ > drivers/gpu/drm/i915/i915_gpu_error.c:1197:4: note: here > case RCS0: > ^~~~ > > drivers/gpu/drm/i915/display/intel_dp.c: In function ‘intel_dp_get_fia_supported_lane_count’: > ./include/linux/compiler.h:78:22: warning: this statement may fall through [-Wimplicit-fallthrough=] > # define unlikely(x) __builtin_expect(!!(x), 0) > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > ./include/asm-generic/bug.h:136:2: note: in expansion of macro ‘unlikely’ > unlikely(__ret_warn_on); \ > ^~~~~~~~ > drivers/gpu/drm/i915/i915_utils.h:49:25: note: in expansion of macro ‘WARN’ > #define MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \ > ^~~~ > drivers/gpu/drm/i915/display/intel_dp.c:233:3: note: in expansion of macro ‘MISSING_CASE’ > MISSING_CASE(lane_info); > ^~~~~~~~~~~~ > drivers/gpu/drm/i915/display/intel_dp.c:234:2: note: here > case 1: > ^~~~ > > drivers/gpu/drm/i915/display/intel_display.c: In function ‘check_digital_port_conflicts’: > CC [M] drivers/gpu/drm/nouveau/nvkm/engine/disp/cursgv100.o > drivers/gpu/drm/i915/display/intel_display.c:12043:7: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (WARN_ON(!HAS_DDI(to_i915(dev)))) > ^ > drivers/gpu/drm/i915/display/intel_display.c:12046:3: note: here > case INTEL_OUTPUT_DP: > ^~~~ > > Also, notice that the Makefile is modified in order to stop > ignoring fall-through warnings. The -Wimplicit-fallthrough > option will be enabled globally in v5.3. > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/gpu/drm/i915/Makefile | 1 - > drivers/gpu/drm/i915/display/intel_display.c | 2 +- > drivers/gpu/drm/i915/display/intel_dp.c | 1 + > drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +- > drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 +- > drivers/gpu/drm/i915/i915_gpu_error.c | 1 + > 6 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > index 91355c2ea8a5..8cace65f50ce 100644 > --- a/drivers/gpu/drm/i915/Makefile > +++ b/drivers/gpu/drm/i915/Makefile > @@ -16,7 +16,6 @@ subdir-ccflags-y := -Wall -Wextra > subdir-ccflags-y += $(call cc-disable-warning, unused-parameter) > subdir-ccflags-y += $(call cc-disable-warning, type-limits) > subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers) > -subdir-ccflags-y += $(call cc-disable-warning, implicit-fallthrough) > subdir-ccflags-y += $(call cc-disable-warning, unused-but-set-variable) > # clang warnings > subdir-ccflags-y += $(call cc-disable-warning, sign-compare) > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index 8592a7d422de..30b97ded6fdd 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -12042,7 +12042,7 @@ static bool check_digital_port_conflicts(struct intel_atomic_state *state) > case INTEL_OUTPUT_DDI: > if (WARN_ON(!HAS_DDI(to_i915(dev)))) > break; > - /* else: fall through */ > + /* else, fall through */ > case INTEL_OUTPUT_DP: > case INTEL_OUTPUT_HDMI: > case INTEL_OUTPUT_EDP: > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 4336df46fe78..d0fc34826771 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -231,6 +231,7 @@ static int intel_dp_get_fia_supported_lane_count(struct intel_dp *intel_dp) > switch (lane_info) { > default: > MISSING_CASE(lane_info); > + /* fall through */ > case 1: > case 2: > case 4: > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c > index 391621ee3cbb..39a661927d8e 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c > @@ -341,7 +341,7 @@ vm_fault_t i915_gem_fault(struct vm_fault *vmf) > */ > if (!i915_terminally_wedged(i915)) > return VM_FAULT_SIGBUS; > - /* else: fall through */ > + /* else, fall through */ > case -EAGAIN: > /* > * EAGAIN means the gpu is hung and we'll wait for the error > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c > index b36ad269f4ea..65eb430cedba 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c > @@ -268,7 +268,7 @@ static void *i915_gem_object_map(const struct drm_i915_gem_object *obj, > switch (type) { > default: > MISSING_CASE(type); > - /* fallthrough to use PAGE_KERNEL anyway */ > + /* fallthrough - to use PAGE_KERNEL anyway */ > case I915_MAP_WB: > pgprot = PAGE_KERNEL; > break; > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > index b7e9fddef270..41a511d5267f 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -1194,6 +1194,7 @@ static void error_record_engine_registers(struct i915_gpu_state *error, > switch (engine->id) { > default: > MISSING_CASE(engine->id); > + /* fall through */ > case RCS0: > mmio = RENDER_HWS_PGA_GEN7; > break; > -- > 2.22.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx