From: Oscar Salvador <osalvador@suse.de>
To: Weitao Hou <houweitaoo@gmail.com>
Cc: akpm@linux-foundation.org, mhocko@suse.com, david@redhat.com,
pasha.tatashin@soleen.com, dan.j.williams@intel.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/hotplug: remove unneeded return for void function
Date: Tue, 23 Jul 2019 15:14:10 +0200 [thread overview]
Message-ID: <20190723131401.GA24690@linux> (raw)
In-Reply-To: <20190723130814.21826-1-houweitaoo@gmail.com>
On Tue, Jul 23, 2019 at 09:08:14PM +0800, Weitao Hou wrote:
> return is unneeded in void function
>
> Signed-off-by: Weitao Hou <houweitaoo@gmail.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
> ---
> mm/memory_hotplug.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 2a9bbddb0e55..c73f09913165 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -132,7 +132,6 @@ static void release_memory_resource(struct resource *res)
> return;
> release_resource(res);
> kfree(res);
> - return;
> }
>
> #ifdef CONFIG_MEMORY_HOTPLUG_SPARSE
> @@ -979,7 +978,6 @@ static void rollback_node_hotadd(int nid)
> arch_refresh_nodedata(nid, NULL);
> free_percpu(pgdat->per_cpu_nodestats);
> arch_free_nodedata(pgdat);
> - return;
> }
>
>
> --
> 2.18.0
>
--
Oscar Salvador
SUSE L3
prev parent reply other threads:[~2019-07-23 13:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 13:08 [PATCH] mm/hotplug: remove unneeded return for void function Weitao Hou
2019-07-23 13:13 ` David Hildenbrand
2019-07-23 13:14 ` Oscar Salvador [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723131401.GA24690@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=houweitaoo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pasha.tatashin@soleen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.