From: Dan Carpenter <dan.carpenter@oracle.com>
To: daniele.ceraolospurio@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: [bug report] drm/i915/uc: prefer intel_gt over i915 in GuC/HuC paths
Date: Tue, 23 Jul 2019 18:00:31 +0300 [thread overview]
Message-ID: <20190723150031.GA16689@mwanda> (raw)
Hello Daniele Ceraolo Spurio,
The patch 84b1ca2f0e68: "drm/i915/uc: prefer intel_gt over i915 in
GuC/HuC paths" from Jul 13, 2019, leads to the following static
checker warning:
drivers/gpu/drm/i915/gt/uc/intel_huc.c:173 intel_huc_check_status()
warn: masking a bool
drivers/gpu/drm/i915/gt/uc/intel_huc.c
161 int intel_huc_check_status(struct intel_huc *huc)
162 {
163 struct intel_gt *gt = huc_to_gt(huc);
164 intel_wakeref_t wakeref;
165 bool status = false;
^^^^^^^^^^^^^^^^^^^
166
167 if (!intel_uc_is_using_huc(>->uc))
168 return -ENODEV;
169
170 with_intel_runtime_pm(>->i915->runtime_pm, wakeref)
171 status = intel_uncore_read(gt->uncore, huc->status.reg);
172
173 return (status & huc->status.mask) == huc->status.value;
^^^^^^
It definitely looks like status should be a u32 or something.
174 }
regards,
dan carpenter
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2019-07-23 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 15:00 Dan Carpenter [this message]
2019-07-23 15:08 ` [bug report] drm/i915/uc: prefer intel_gt over i915 in GuC/HuC paths Daniele Ceraolo Spurio
2019-07-23 15:17 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723150031.GA16689@mwanda \
--to=dan.carpenter@oracle.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.