From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbusch@kernel.org (Keith Busch) Date: Tue, 23 Jul 2019 10:01:42 -0600 Subject: [PATCH V2 0/4] lnvm: minor clean-ups In-Reply-To: <744d9561-0710-6428-6135-cb1902fc66ad@lightnvm.io> References: <20190721153219.5730-1-minwoo.im.dev@gmail.com> <744d9561-0710-6428-6135-cb1902fc66ad@lightnvm.io> Message-ID: <20190723160141.GA4002@localhost.localdomain> On Tue, Jul 23, 2019@10:58:11AM +0200, Matias Bj?rling wrote: > On 7/21/19 5:32 PM, Minwoo Im wrote: > > Hi, > > > > This series is nothing but a clean-up patch series. I hope it's not a > > just code churns, but a good start to do something for lnvm. > > > > The first one removed a redundant whitespace in the command description. > > The second one removed unnecessary print for the sizeof(dev) which will > > always be zero in case user does not give any argument for the device. > > The third patch removed temp variable instead casting the pinter > > directly. The last one just sync-up the kernel UAPI header file to the > > latest. > > > > Please review. > > > > Thanks, > > > > Changes to V2: > > - Resend the series with the latest patch commits. > > > > Minwoo Im (4): > > lnvm: remove redundant whitespace in lnvm_init() > > lnvm: do not print 0 when the arg is not given > > lnvm: cast identity structure to (void *) directly > > lnvm: sync-up uapi lightnvm.h header from kernel > > > > linux/lightnvm.h | 52 +++++++++++++++++++++++++++++++++++++++- > > nvme-lightnvm.c | 7 +++--- > > plugins/lnvm/lnvm-nvme.c | 8 +++---- > > 3 files changed, 58 insertions(+), 9 deletions(-) > > > > Thanks Minwoo. > > Patch 1-3 looks good to me. Keith, feel free to pick them up. > > Patch 4 can wait until there is a use for the data structures. Sounds good, series applied from the pull-request.