From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F96CC76186 for ; Tue, 23 Jul 2019 20:03:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BE60229EC for ; Tue, 23 Jul 2019 20:03:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403899AbfGWUDZ (ORCPT ); Tue, 23 Jul 2019 16:03:25 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:42345 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726384AbfGWUDY (ORCPT ); Tue, 23 Jul 2019 16:03:24 -0400 X-Originating-IP: 90.65.161.137 Received: from localhost (lfbn-1-1545-137.w90-65.abo.wanadoo.fr [90.65.161.137]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 82CF71BF206; Tue, 23 Jul 2019 20:03:21 +0000 (UTC) Date: Tue, 23 Jul 2019 22:03:21 +0200 From: Alexandre Belloni To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Alessandro Zummo , linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tbm@cyrius.com, Oliver Hartkopp , Andrew Lunn Subject: Re: [PATCH] ARM: kirkwood: ts219: disable the SoC's RTC Message-ID: <20190723200321.GN24911@piout.net> References: <20190723194505.28060-1-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190723194505.28060-1-uwe@kleine-koenig.org> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 23/07/2019 21:45:05+0200, Uwe Kleine-König wrote: > The internal RTC doesn't work, loading the driver only yields > > rtc-mv f1010300.rtc: internal RTC not ticking > > . So disable it. > > Signed-off-by: Uwe Kleine-König > --- > arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi > index a88eb22070a1..994cabcf4b51 100644 > --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi > +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi > @@ -104,3 +104,11 @@ > &pcie0 { > status = "okay"; > }; > + > +&rtc { > + /* > + * There is a s35390a available on the i2c bus, the internal rtc isn't > + * working (probably no crystal assembled). > + */ > + status = "disabled"; > +}; You could also use the aliases to ensure rtc0 is the s35390a. This would solve the initial issue. > -- > 2.20.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 968A0C76186 for ; Tue, 23 Jul 2019 20:03:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F9B1229EC for ; Tue, 23 Jul 2019 20:03:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XqUA7bOP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F9B1229EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NIC268tWu78fkGFE+AQWmDSDIkQ3uaodCFjJ+MuuP8c=; b=XqUA7bOPmX0raK tZoNV7+itie2pAl713lo/FJXAJ26ooDIKfaxXHx4JfTDBM4+VqY/sUOrPG5UTgiMumAHY7maRpMPb caDL3tYC4qhZx01RWfy4JxFWuuK1EoyFG2YiItuNY4m6eRr8C4IjTpzEbHBWeScrUAjPZpVYAovAL /jkiZ06jJbqj0WckAOwJLe05NE6/8q25icY2njEBm3fboUJsl6oWMf0fV1YUovvgAb8+buB3CMf1L S/5JOLjApBRqxNIdTZl+WGJ7we2patDrBsDJkHbYrBbF25wXVxCL0cAO77lzLLHd2zLzuPwqJaemN PRajE/Sby7J1BPSQdcPA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hq10a-0007g8-KL; Tue, 23 Jul 2019 20:03:36 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hq10W-0007fA-PG for linux-arm-kernel@lists.infradead.org; Tue, 23 Jul 2019 20:03:35 +0000 X-Originating-IP: 90.65.161.137 Received: from localhost (lfbn-1-1545-137.w90-65.abo.wanadoo.fr [90.65.161.137]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 82CF71BF206; Tue, 23 Jul 2019 20:03:21 +0000 (UTC) Date: Tue, 23 Jul 2019 22:03:21 +0200 From: Alexandre Belloni To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] ARM: kirkwood: ts219: disable the SoC's RTC Message-ID: <20190723200321.GN24911@piout.net> References: <20190723194505.28060-1-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190723194505.28060-1-uwe@kleine-koenig.org> User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190723_130332_980706_152D572A X-CRM114-Status: GOOD ( 15.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , Andrew Lunn , Oliver Hartkopp , tbm@cyrius.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/07/2019 21:45:05+0200, Uwe Kleine-K=F6nig wrote: > The internal RTC doesn't work, loading the driver only yields > = > rtc-mv f1010300.rtc: internal RTC not ticking > = > . So disable it. > = > Signed-off-by: Uwe Kleine-K=F6nig > --- > arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > = > diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/ki= rkwood-ts219.dtsi > index a88eb22070a1..994cabcf4b51 100644 > --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi > +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi > @@ -104,3 +104,11 @@ > &pcie0 { > status =3D "okay"; > }; > + > +&rtc { > + /* > + * There is a s35390a available on the i2c bus, the internal rtc isn't > + * working (probably no crystal assembled). > + */ > + status =3D "disabled"; > +}; You could also use the aliases to ensure rtc0 is the s35390a. This would solve the initial issue. > -- = > 2.20.1 > = -- = Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel