fstests: cannot allocate memory - false negatives xfs/059

[Luis Chamberlain <mcgrof@kernel.org>]

I'm seeing at least one test fail but in reality it doesn't
seem like a real failure, only memory pressure for a small
period of time, and the test actually passed. But it failed
since there was a difference in output.

I see this has been discussed but the emails date back years ago
and then refer to discussions using a URL which no longer exists.
As such I cannot determine what the conclusion was.

For example, the test below actually is fine, but just because it
display two extra lines of "Cannot allocate memory" its reported as a
failure.

What was the agreement to deal with this? Was there any? If no
agreement was reached, what about just excluding these lines from
the output, or modifying the utilities to not display such messages
unless a verbsose flag was passed.

I tried looking for xfsrestore to see where this would be coming from
and don't see that... so again.. still not sure what to do yet.

Thoughts?

SECTION       -- xfs_nocrc_512
FSTYP         -- xfs (non-debug)
PLATFORM      -- Linux/x86_64 oscheck-xfs-nocrc-512 4.19.58 #1 SMP Wed
Jul 17 06:37:34 UTC 2019
MKFS_OPTIONS  -- -f -f -m crc=0,reflink=0,rmapbt=0, -i sparse=0, -b
size=512, /dev/loop5
MOUNT_OPTIONS -- /dev/loop5 /media/scratch

xfs/059 14s ... - output mismatch (see
/var/lib/xfstests/results/oscheck-xfs-nocrc-512/4.19.58/xfs_nocrc_512/xfs/059.out.bad)
--- tests/xfs/059.out       2019-07-17 06:53:54.439742882 +0000
+++
/var/lib/xfstests/results/oscheck-xfs-nocrc-512/4.19.58/xfs_nocrc_512/xfs/059.out.bad
2019-07-23 18:36:06.530062007 +0000
@@ -29,6 +29,8 @@
xfsrestore: using file dump (drive_simple) strategy
xfsrestore: using file dump (drive_simple)
strategy
xfsrestore: using file dump (drive_simple)
strategy
+ Cannot allocate memory
+ Cannot allocate memory
xfsrestore: restore complete:
SECS seconds elapsed
xfsrestore: Restore Status:
SUCCESS
...
(Run 'diff -u
/var/lib/xfstests/tests/xfs/059.out
/var/lib/xfstests/results/oscheck-xfs-nocrc-512/4.19.58/xfs_nocrc_512/xfs/059.out.bad'
to see the entire
diff)
Ran: xfs/059
Failures: xfs/059
Failed 1 of 1 tests