From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/8] ARM: OMAP2+: Remove unconfigured midlemode for am3 lcdc Date: Tue, 23 Jul 2019 23:31:10 -0700 Message-ID: <20190724063110.GT5447@atomide.com> References: <20190723112811.44381-1-tony@atomide.com> <20190723112811.44381-3-tony@atomide.com> <52328e14-58b2-2ea1-8b0a-33548a1c6a7a@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <52328e14-58b2-2ea1-8b0a-33548a1c6a7a@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Keerthy Cc: Suman Anna , linux-omap@vger.kernel.org, Jyri Sarha , Dave Gerlach , Faiz Abbas , Greg Kroah-Hartman , Nishanth Menon , Peter Ujfalusi , Roger Quadros , Tero Kristo , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org * Keerthy [190724 05:50]: > > On 24/07/19 12:33 AM, Suman Anna wrote: > > + Jyri > > > > On 7/23/19 6:28 AM, Tony Lindgren wrote: > > > We currently get a warning for lcdc because of a difference > > > with dts provided configuration compared to the legacy platform > > > data. This is because lcdc has SYSC_HAS_MIDLEMODE configured in > > > the platform data without configuring the modes. > > > > Hi Tony, > > While I understand that you are trying to match the DT data with the > > existing legacy data, do you know if there was a reason why this was > > omitted in the first place? Should we be really adding the MSTANDBY_ > > flags and fix up the DTS node accordingly? I tried looking through the > > git log, and the initial commit itself didn't add the MSTANDBY_ flags > > but used the SYSC_HAS_MIDLEMODE. Yes the goal is to get rid of all errors and warnings in dmesg output so we can spot the real issues. > > Jyri, > > Do you know the history? > > Tony/Suman, > > This patch breaks DS0 on am3. OK thanks for testing. Let's drop this for now, sounds like there is some midlemode configuration happening even with no flags set. Probably the right fix is to configure the usable midlemodes instead both for platform data and dts data and then drop the platform data. Regards, Tony > > > Let's fix the warning by removing SYSC_HAS_MIDLEMODE. Note that > > > the am335x TRM lists SYSC_HAS_MIDLEMODE, but it is unused. > > > > > > > > > > > > Signed-off-by: Tony Lindgren > > > --- > > > arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > > > --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > > > +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > > > @@ -231,7 +231,7 @@ static struct omap_hwmod am33xx_control_hwmod = { > > > static struct omap_hwmod_class_sysconfig lcdc_sysc = { > > > .rev_offs = 0x0, > > > .sysc_offs = 0x54, > > > - .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE), > > > + .sysc_flags = SYSC_HAS_SIDLEMODE, > > > .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), > > > .sysc_fields = &omap_hwmod_sysc_type2, > > > }; > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFF52C7618B for ; Wed, 24 Jul 2019 06:31:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A653A2064A for ; Wed, 24 Jul 2019 06:31:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C2/auK0B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A653A2064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HTaM7CvD2ElpqdZ/YvFdPG6KurEZx4YHEGZ2nyIoqLU=; b=C2/auK0BgAMn/G C0RsuTJMiZdNlYKVrWzn5EUz35VXfMQXVMp+60hySxGL4ZdOY5KbBZ5WT7vWALzL7LmQTIZQaJe9g rTEwjfI8IgW5SsvJJKD+AnWdmoqwWFFC7FVPZzzzNgzbezD+mcXhBp6BgkEGc14qs+iTg2hNIJ0TI YP/D7gerJuMFpL6A12WHu+OdPSIo2P+yKTQVACu3UHJOksNqT1pA+uVXH8m+NUmI0Vc1t2aVHojW9 bUDa4VMeWZPhW8MCvXseqIJTQaE4BznM0gBa8M66KjZm8AiF6jUjYkS1TotXLAenHpBGGkXXQijA9 4UBT6Z27Gw3s39hgZKjA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqAo3-0003ll-Ov; Wed, 24 Jul 2019 06:31:19 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqAo1-0003g0-1a for linux-arm-kernel@lists.infradead.org; Wed, 24 Jul 2019 06:31:18 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 01D51816A; Wed, 24 Jul 2019 06:31:38 +0000 (UTC) Date: Tue, 23 Jul 2019 23:31:10 -0700 From: Tony Lindgren To: Keerthy Subject: Re: [PATCH 2/8] ARM: OMAP2+: Remove unconfigured midlemode for am3 lcdc Message-ID: <20190724063110.GT5447@atomide.com> References: <20190723112811.44381-1-tony@atomide.com> <20190723112811.44381-3-tony@atomide.com> <52328e14-58b2-2ea1-8b0a-33548a1c6a7a@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <52328e14-58b2-2ea1-8b0a-33548a1c6a7a@ti.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190723_233117_128318_B901D9D5 X-CRM114-Status: GOOD ( 22.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Tero Kristo , Dave Gerlach , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Jyri Sarha , Peter Ujfalusi , Faiz Abbas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Keerthy [190724 05:50]: > > On 24/07/19 12:33 AM, Suman Anna wrote: > > + Jyri > > > > On 7/23/19 6:28 AM, Tony Lindgren wrote: > > > We currently get a warning for lcdc because of a difference > > > with dts provided configuration compared to the legacy platform > > > data. This is because lcdc has SYSC_HAS_MIDLEMODE configured in > > > the platform data without configuring the modes. > > > > Hi Tony, > > While I understand that you are trying to match the DT data with the > > existing legacy data, do you know if there was a reason why this was > > omitted in the first place? Should we be really adding the MSTANDBY_ > > flags and fix up the DTS node accordingly? I tried looking through the > > git log, and the initial commit itself didn't add the MSTANDBY_ flags > > but used the SYSC_HAS_MIDLEMODE. Yes the goal is to get rid of all errors and warnings in dmesg output so we can spot the real issues. > > Jyri, > > Do you know the history? > > Tony/Suman, > > This patch breaks DS0 on am3. OK thanks for testing. Let's drop this for now, sounds like there is some midlemode configuration happening even with no flags set. Probably the right fix is to configure the usable midlemodes instead both for platform data and dts data and then drop the platform data. Regards, Tony > > > Let's fix the warning by removing SYSC_HAS_MIDLEMODE. Note that > > > the am335x TRM lists SYSC_HAS_MIDLEMODE, but it is unused. > > > > > > > > > > > > Signed-off-by: Tony Lindgren > > > --- > > > arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > > > --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > > > +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > > > @@ -231,7 +231,7 @@ static struct omap_hwmod am33xx_control_hwmod = { > > > static struct omap_hwmod_class_sysconfig lcdc_sysc = { > > > .rev_offs = 0x0, > > > .sysc_offs = 0x54, > > > - .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE), > > > + .sysc_flags = SYSC_HAS_SIDLEMODE, > > > .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), > > > .sysc_fields = &omap_hwmod_sysc_type2, > > > }; > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel