All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] utils/test-pkg: add option to enable NLS support
Date: Wed, 24 Jul 2019 09:17:55 +0200	[thread overview]
Message-ID: <20190724091755.534a0136@windsurf> (raw)
In-Reply-To: <CAMw6YJKnpyUs_24FqopnwJQke-G=D_LNUwcsCvpDUJH5c5qFvg@mail.gmail.com>

On Wed, 24 Jul 2019 10:03:24 +0300
Vadim Kochan <vadim4j@gmail.com> wrote:

> > So I think we should instead ensure that test-pkg by default tests the
> > different combinations that we think are useful to test.
> >  
> 
> OK, I see, I can only say that usually I use test-pkg for version
> bumping or checking
> the package compilation issue reported in 'Buildroot results' mailing
> if it pass, for *.mk changing and of course
> for the new packages. So I was thinking that others also use it in
> such way, and my
> assumption was that --with-nls option would be useful :)

Yes, others also use it for the same reason. What I meant is only that
others will most likely not remember they should test with and without
the --with-nls option. So we should test both NLS enabled and NLS
disabled configurations in the default test-pkg run perhaps.

But of course then, should we test sysvinit/systemd configurations, to
make sure the init script installation logic works ? Should we test
hardening options ? etc. We can't test everything in test-pkg as it
would make the test too long, and making the test too long will reduce
the incentive to use this tool.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-07-24  7:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 17:23 [Buildroot] [PATCH 1/1] utils/test-pkg: add option to enable NLS support Vadim Kochan
2019-07-23 22:13 ` Thomas Petazzoni
2019-07-24  7:03   ` Vadim Kochan
2019-07-24  7:17     ` Thomas Petazzoni [this message]
2019-07-24  7:32       ` Vadim Kochan
2019-08-03  8:22 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190724091755.534a0136@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.